aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #34825 from ↵George Claghorn2018-12-294-4/+4
|\ | | | | | | | | bogdanvlviv/change-migration-version-of-actionmailbox Use 6.0 version of `ActiveRecord::Migration` for Action Mailbox
| * Use 6.0 default configs in Active Storage test dummy appbogdanvlviv2018-12-301-1/+1
| |
| * Use 6.0 version of ActiveRecord::Migration for Action Mailboxbogdanvlviv2018-12-303-3/+3
| | | | | | | | | | | | Since Action Mailbox will be introduced in Rails 6.0, it makes more sense to generate migration of that version. Also I changed its test dummy app to use default 6.0 configs.
* | Merge pull request #34812 from bogdanvlviv/action_mailbox-guides-docsGeorge Claghorn2018-12-295-314/+324
|\ \ | |/ |/| Add Action Mailbox to guides
| * Add Action Mailbox to Major Features of Rails 6.0 [ci skip]bogdanvlviv2018-12-301-0/+9
| |
| * Fix Action Mailer Basics [ci skip]bogdanvlviv2018-12-302-47/+7
| | | | | | | | Now Action Mailbox is responsible for receiving emails.
| * Move some `actionmailbox/README.md` content to Action Mailbox Basics guide ↵bogdanvlviv2018-12-303-267/+308
| | | | | | | | | | | | | | [ci skip] I added WIP label to that guide since we definitely want to complement it.
* | Don't load Action Mailbox when Active Storage is skippedGeorge Claghorn2018-12-292-1/+6
| |
* | Do not show suggestion message when not exist suggestionyuuji.yaginuma2018-12-294-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | **before** ``` $ ./bin/rails g g Could not find generator 'g'. Maybe you meant nil? Run `rails generate --help` for more options. ``` **after** ``` $ ./bin/rails g g Could not find generator 'g'. Run `rails generate --help` for more options. ```
* | Require railties for all Action Mailbox dependenciesGeorge Claghorn2018-12-281-1/+6
| |
* | Merge pull request #34820 from bogdanvlviv/extract-text-from-34816George Claghorn2018-12-281-0/+5
|\ \ | | | | | | Ensure that the app generator skips action mailbox when `--skip-active-record` is given
| * | Ensure that the app generator skips action mailbox when ↵bogdanvlviv2018-12-281-0/+5
| | | | | | | | | | | | | | | | | | | | | `--skip-active-record` is given Related to https://github.com/rails/rails/pull/34816#issuecomment-450378366 Follow up https://github.com/rails/rails/commit/ddaf06779aa51d5d1ca462c21c53f2ed169a0d2f
* | | Remove frozen_string_literal pragma from Action Mailbox templatesGeorge Claghorn2018-12-282-4/+0
|/ /
* | Label Action Mailbox PRsGeorge Claghorn2018-12-281-0/+2
| |
* | Merge pull request #34814 from bogdanvlviv/follow-up-e3f832a7433aGeorge Claghorn2018-12-282-29/+4
|\ \ | | | | | | Remove mention about `receive.action_mailer` from the AS instrumentation guide
| * | Remove mention about `receive.action_mailer` from the AS instrumentation guidebogdanvlviv2018-12-282-29/+4
|/ / | | | | | | | | Since e3f832a7433a291a51c5df397dc3dd654c1858cb `ActionMailer::Base.receive` is deprecated.
* | Fix broken Mailbox generator testyuuji.yaginuma2018-12-281-2/+2
| | | | | | | | Follow up to d082439cf7e577e266bfeb7b443569f323df1673
* | Add missing quotes on Mailbox test templateyuuji.yaginuma2018-12-281-1/+1
| |
* | Don't load Action Mailbox when Active Record is skippedGeorge Claghorn2018-12-282-2/+7
| |
* | Load Action Mailbox when other components are skippedGeorge Claghorn2018-12-281-0/+1
| |
* | Deprecate ActionMailer::Base.receive in favor of Action MailboxGeorge Claghorn2018-12-275-40/+14
| |
* | Use high level API on `migration_context` instead of using low level API ↵Ryuta Kamizono2018-12-282-13/+11
| | | | | | | | | | | | | | | | directly Since `migration_context` has `migrations_paths` itself and provides methods which returning values from parsed migration files, so there is no reason to use the `parse_migration_filename` low level API directly.
* | Deprecate passing `migrations_paths` to ↵Ryuta Kamizono2018-12-284-12/+20
| | | | | | | | | | | | | | `connection.assume_migrated_upto_version` Since #31727, `migrations_paths` in `assume_migrated_upto_version` is no longer used.
* | Remove redundant assignning to `current_env`Ryuta Kamizono2018-12-281-1/+0
| | | | | | | | This was introduced at https://github.com/rails/rails/commit/cfa1df4b07bee5b2bbcbf9edd2ac287b4fb23c18#diff-b36b9c41be30b05dc14d09d7f3b192efR436.
* | Enable `Lint/ShadowingOuterLocalVariable` cop to avoid newly adding the warningRyuta Kamizono2018-12-281-0/+3
| | | | | | | | | | | | | | | | | | | | | | Since we've addressed the warning "warning: shadowing outer local variable" frequently. 2c325182b84ea4c75855c777b25de0f15fd218e5 df76eaa4f1619dfbc024235f444c602eb6d6775a b86c2a6767b939c420687db7df078625c702dc7a b658743ac2a69d196d283e780816f5ad4a305753 b18f2fe96debdcd0744f99101d1a1e0d42c41eaa
* | Merge pull request #34810 from cbothner/activestorage-no-undefined-csrf-headerGeorge Claghorn2018-12-273-2/+15
|\ \ | | | | | | ActiveStorage: Don’t include an undefined X-CSRF-Token header when creating a blob record
| * | Don’t include an undefined X-CSRF-Token headerCameron Bothner2018-12-273-2/+15
|/ / | | | | | | | | | | | | If there is not a `csrf-token` meta tag in the document, the blob record XHR was including an `X-CSRF-Token` header set to the string "undefined." Instead of setting it to undefined, it should not be included in the absence of a meta tag.
* | Merge pull request #34806 from bogdan/reuse-find-targetRyuta Kamizono2018-12-274-30/+20
|\ \ | | | | | | | | | Reuse AR::Association#find_target method
| * | Reuse AR::Association#find_target methodBogdan Gusiev2018-12-274-29/+21
| | |
* | | Only run isolated tests on the latest stable ruby: that's now 2.6Ryuta Kamizono2018-12-271-1/+1
| |/ |/| | | | | | | | | Follow up #34795. See also f1a30d8ad5ae17e6202fd3a126027378773dcaea.
* | Merge pull request #34801 from bogdanvlviv/follow-up-34786George Claghorn2018-12-266-52/+5
|\ \ | | | | | | Follow up 34786
| * | Fix Ruby warnings in actionmailboxbogdanvlviv2018-12-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ``` rails/actionmailbox$ bundle exec rake tests (snip) ... rails/activerecord/lib/active_record/persistence.rb:48: warning: in `create!': the last argument was passed as a single Hash rails/actionmailbox/app/models/action_mailbox/inbound_email/message_id.rb:21: warning: although a splat keyword arguments here ... (snip) ```
| * | Improve actionmailbox's .gitignore and remove redundant filesbogdanvlviv2018-12-275-51/+4
|/ / | | | | | | Follow up #34786
* | Nest ActionMailbox::Base in the API docs (missed in 6c168aa)George Claghorn2018-12-261-93/+95
| |
* | Nest Action Mailbox classes in the API docsGeorge Claghorn2018-12-2619-508/+546
| |
* | Generate Action Mailbox's API docsGeorge Claghorn2018-12-261-0/+8
| |
* | Start an Action Mailbox changelogGeorge Claghorn2018-12-261-0/+3
| |
* | Test against Ruby 2.6.0George Claghorn2018-12-261-0/+36
| |
* | Merge pull request #34786 from georgeclaghorn/actionmailboxGeorge Claghorn2018-12-26162-182/+10911
|\ \ | | | | | | Import Action Mailbox
| * \ Import Action MailboxGeorge Claghorn2018-12-25162-182/+10911
| |\ \
| | * | Bump the minimum Ruby version to match Rails masterGeorge Claghorn2018-12-201-1/+1
| | | |
| | * | Remove Ruby 2.4 from the test matrixGeorge Claghorn2018-12-191-1/+0
| | | | | | | | | | | | | | | | Rails 6 will require Ruby 2.5 or newer. See rails/rails#34754.
| | * | Use class_methods throughout codebase.Kasper Timm Hansen2018-12-192-4/+4
| | | |
| | * | [ci skip] Docs: fix spelling, routing setup call and formatting.Kasper Timm Hansen2018-12-192-9/+9
| | | |
| | * | Merge pull request #12 from dixpac/add_logger_when_auto_generating_message_idKasper Timm Hansen2018-12-191-4/+4
| | |\ \ | | | | | | | | | | Added logging when Message ID wasn't extracted
| | | * | Added logging when Message ID wasn't extractedDino Maric2018-12-191-4/+4
| | |/ /
| | * | Resurrect installer.Kasper Timm Hansen2018-12-184-3/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Running `./bin/rails generate mailbox application --no-test-framework` generates: ``` class ApplicationMailbox < ApplicationMailbox def process end end ``` which is not correct for the application mailbox. It shouldn't respond to process but it should contain a routing hint. Generally generators aren't meant to be used like the previous commit. The mailbox generator can certainly add in the ApplicationMailbox if missing, but it shouldn't be called with "application" as an argument. Also adds back auto inserting an `ingress` config line in `config/environmnets/production.rb`. Fixes #13. [Kasper Timm Hansen, Andrew Babichev]
| | * | Refit generator file structure to match Action Cable.Kasper Timm Hansen2018-12-187-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fits with rails/generators/channel containing: - channel_generator.rb - templates/ - USAGE
| | * | Remove actions argument from Mailbox generator.Kasper Timm Hansen2018-12-183-15/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Generators only have the public `process` action, so there's nothing else to generate here. Skip the needless indirection.
| | * | Test namespacing is supported.Kasper Timm Hansen2018-12-181-0/+22
| | | |
generated by cgit v1.2.3 (git 2.25.1) at 2025-02-11 00:18:08 +0000