aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | Merge pull request #25485 from georgemillo/patch-1Jon Moss2016-06-231-1/+1
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | | English fix
| * | | | | | | English fixGeorge Millo2016-06-231-1/+1
|/ / / / / / / | | | | | | | | | | | | | | --skip-ci
* | | | | | | Merge pull request #25480 from kmcphillips/masterRafael França2016-06-222-0/+11
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Update changelog for ActiveSupport::Logger.broadcast #silence and config.assets.quiet = true
| * | | | | | Update changelog for #25351Kevin McPhillips2016-06-221-0/+5
| | | | | | |
| * | | | | | Update changelog for #25341Kevin McPhillips2016-06-221-0/+6
|/ / / / / /
* | | | | | Initialize the configuration with a valueRafael Mendonça França2016-06-224-10/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will fix the failures fixed by 41488adbb89a09fa96188486f8414842ff28c848 and keep this new option that is semi-private outside of the generated configurations
* | | | | | Merge pull request #25473 from ↵Jon Moss2016-06-221-19/+18
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | bquorning/update-documentation-for-strong_parameters Update documentation for strong parameters
| * | | | | | Update ActionController::Parameters documentation [ci skip]Benjamin Quorning2016-06-221-19/+18
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The changes in this commit are twofold: 1. The examples showing `#require` accepting two arguments were wrong - you have to wrap the arguments (two, or more) in an array. 2. `ActionController::Parameters` has an `#inspect` method now (since https://github.com/rails/rails/pull/23732), and the documentation should reflect that.
* | | | | | Fix failing railties testseileencodes2016-06-223-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Railties tests didn't know about the new config option added in 80b416f so it needed to be added to the railties generators for configs.
* | | | | | Add option to enable dependency loading in productionRafael Mendonça França2016-06-222-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will make easier to applications that rely on having const_missing hooks in production upgrade to Rails 5. This option is going to be remove in the future and the default behavior will be to disable the dependency loading.
* | | | | | Merge pull request #25469 from ↵Rafael Mendonça França2016-06-226-139/+39
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | herminiotorres/update-datetime-to-datetime-local-by-html-specification Change datetime to datetime-local helper tag
| * | | | | Change datetime to datetime-local helper tagHerminio Torres2016-06-216-139/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A change was made in the helper that renders the `datetime`, being now by default `datetime-local` and creating an alias of `datetime-local` for `datetime`, `datetime` tag and it passes to be an abstract class for all other tags that inherit from him. As a new specification of the HTML 5 the text field type `datetime` will no longer exist and will pass a `datetime-local`. Ref: https://html.spec.whatwg.org/multipage/forms.html#local-date-and-time-state-(type=datetime-local)
* | | | | | Merge pull request #25467 from aarongray/tweak_time_helpers_docs_for_time_zonesVipul A M2016-06-221-3/+3
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Docs: create times using the rails timezone not system timezone [ci skip]
| * | | | | Create times in rails timezone not system timezone [ci skip]aarongray2016-06-211-3/+3
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | Time.new is a Ruby method that uses system timezone. Traveling in time using it is a recipe for confusion. Instead, Time.zone.local should be used since it uses the Rails timezone.
* | | | | Merge pull request #25464 from prathamesh-sonpatki/fix-http-requestRafael França2016-06-211-1/+1
|\ \ \ \ \ | | | | | | | | | | | | update_url is not `get` most of the times [ci skip]
| * | | | | update_url is not `get` most of the times [ci skip]Prathamesh Sonpatki2016-06-221-1/+1
|/ / / / /
* | | / / Revert "Merge pull request #17973 from maurogeorge/file_field_hidden_field"eileencodes2016-06-213-53/+5
| |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The reason we are reverting this commit is because it created breaking changes for file upload gems. For more information see discussion here: https://github.com/rails/rails/issues/17947#issuecomment-225154294 This reverts commit c455817804e4df64c46c17a0cdec0e5a1ca5ba2e, reversing changes made to 8b3cd74b8a09ef85a43d7631bb062a9ec7f57227. Conflicts: actionview/CHANGELOG.md actionview/lib/action_view/helpers/form_helper.rb
* | | | Change the raw template handler to render html-safe stringseileencodes2016-06-213-1/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In PR #24929 the changelog was updated to make note that while the new template handler was changed to raw this changed the behavior when outputting plain html or js files. Previously ERB would output the files unescaped. Changing the default handler to RAW meant that these same files would be rendered as escaped rather than as js or html. Because of this change in behavior and after the discussion #24949 in we decided to change the behavior of the Raw handler to output html_safe strings by default. Now files rendered with the default handler (raw) render the file unescaped.
* | | | Merge pull request #25458 from ↵Jon Moss2016-06-211-0/+17
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | taboularasa/taboularasa/update-docs-ActiveRecord__AttributeSet__YAMLEncoder#decode-for-pr better docs for ActiveRecord::AttributeSet::YAMLEncoder#decode
| * | | | [ci skip] better docs for ActiveRecord::AttributeSet::YAMLEncoder#decodeDavid Elliott2016-06-211-0/+17
| | | | |
* | | | | Merge pull request #25415 from maclover7/jm-fix-25410Rafael França2016-06-211-0/+6
|\ \ \ \ \ | |/ / / / |/| | | | Add test to better demonstrate `ActiveModel::Errors#added?` behavior
| * | | | Add test to better demonstrate `ActiveModel::Errors#added?` behaviorJon Moss2016-06-211-0/+6
| | | | | | | | | | | | | | | | | | | | Fixes #25410.
* | | | | Merge pull request #25450 from prathamesh-sonpatki/fix-testing-guideKasper Timm Hansen2016-06-211-7/+11
|\ \ \ \ \ | | | | | | | | | | | | Fix the docs for supported keyword args or Rails 5 style integration controller tests [ci skip]
| * | | | | Fix the docs for supported keyword args for Rails 5 style integration ↵Prathamesh Sonpatki2016-06-211-7/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | controller tests [ci skip] - Fixes #25394.
* | | | | | Merge pull request #25452 from ↵Kasper Timm Hansen2016-06-201-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | taboularasa/taboularasa/update-docs-api_documentation_guidelines [ci skip] correction in command for generating api documentation
| * | | | | | [ci skip] correction in command for generating api documentationDavid Elliott2016-06-201-1/+1
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | reverts change in previous commit https://github.com/rails/rails/commit/ea4f0e2 docs should prefer to use `rails` over `rake` in the context of an application, but in the context of the Rails source this is not the case
* | | | | | Merge pull request #25430 from ↵Richard Schneeman2016-06-203-1/+27
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | nfm/fix-rails-info-routes-for-apps-with-globbing-route Fix rails/info routes for apps with globbing route
| * | | | | | Fix rails/info routes for apps with globbing routeNicholas Firth-McCoy2016-06-203-1/+27
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The /rails/info routes were inaccessible in apps with a catch-all globbing route, as they were being appended after the globbing route and would never be matched. See also ccc3ddb7762bae0df7e2f8d643b19b6a4769d5be.
* | | | | | Merge pull request #25449 from alexcameron89/masterप्रथमेश Sonpatki2016-06-201-1/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | [ci skip] fix typo in ActiveRecord::ConnectionHandling
| * | | | | [ci skip] fix typo in ActiveRecord::ConnectionHandlingAlex Kitchens2016-06-201-1/+1
|/ / / / /
* | | | | Merge pull request #25433 from prathamesh-sonpatki/cleanup-app-generator-codeGuillermo Iguaran2016-06-201-2/+0
|\ \ \ \ \ | | | | | | | | | | | | No need to have conditional based on api options in assets
| * | | | | No need to have conditional based on api options in assetsPrathamesh Sonpatki2016-06-201-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - As assets are removed for API only apps anyways, so we don't need any conditional upfront. - assets are removed for API apps here - https://github.com/rails/rails/blob/94ef224aa61ace3fa643eab161ff9056b7d90a62/railties/lib/rails/generators/rails/app/app_generator.rb#L266-L273.
* | | | | | Merge pull request #25420 from michaeldever/mdever_actioncable_development_portsGuillermo Iguaran2016-06-201-1/+1
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Allow actioncable connections from all ports in development
| * | | | | Allow actioncable connections from any port in developmentMichael Dever2016-06-161-1/+1
| | | | | |
* | | | | | Merge pull request #25436 from prathamesh-sonpatki/fix-testsRichard Schneeman2016-06-192-3/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix failing railties tests
| * | | | | | Fix failing railties testsPrathamesh Sonpatki2016-06-182-3/+3
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Railties tests related to fetching asset URL started failing after the release of sprockets 3.6.1 on Travis. - This was due to the change in https://github.com/rails/sprockets/pull/311/files which changed the logic in `concat_javascript_sources` to add `;` at the end of file if the source did not end with semicolon. - Bumped up sprockets minor version and fixed the failing tests.
* | | | | | Merge pull request #25426 from Shopify/fix-activejob-loggerRafael França2016-06-173-2/+16
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix jobs overriding AJ::Base#logger
| * | | | | | Fix jobs overriding AJ::Base#loggerJean Boussier2016-06-173-2/+16
| | | | | | |
* | | | | | | Merge pull request #23301 from ppworks/improve_mysqldumpArthur Nogueira Neves2016-06-172-4/+5
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Improve mysqldump
| * | | | | | Skip comments when exec mysqldumpNaoto Koshikawa2016-01-282-4/+5
| | | | | | |
* | | | | | | Merge pull request #25302 from ↵Sean Griffin2016-06-172-6/+87
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | schneems/schneems/evented-file-boot-at-check-time-master EventedFileUpdateChecker boots once per process
| * | | | | | | Lock the whole boot step, get rid of unneeded hashschneems2016-06-131-5/+9
| | | | | | | |
| * | | | | | | Test how evented file checker handles forksschneems2016-06-081-1/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pretty proud of this. We are testing distributed processes synchronized via pipes which makes it deterministic. Pretty cool. We boot a listener in the parent process we then fork. Before we touch the file we verify the fork is booted using pipes. Then the parent process will touch the file while the fork waits on a pipe. Once the parent process signals that the file has been touched we continue inside of the fork.
| * | | | | | | Listen earlier in EventedFileUpdateCheckerschneems2016-06-061-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some files like routes.rb may be very large and vary between the initialization of the app and the first request. In these scenarios if we are using a forked process we cannot rely on the files to be unchanged between when the code is booted and the listener is started. For that reason we start a listener on the main process immediately, when we detect that a process does not have a listener started we force the updated state to be true, so we are guaranteed to catch any changes made between the code initialization and the fork.
| * | | | | | | [ci skip] document EventedFileUpdateCheckerschneems2016-06-061-0/+28
| | | | | | | |
| * | | | | | | EventedFileUpdateChecker boots once per processschneems2016-06-062-6/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We need one file checker booted per process as talked about in #24990. Before we do a check to see if any updates have been registered by the listener we first check to make sure that the current process has booted a listener. We are intentionally not starting a listener when the checker is created. This way we can avoid #25259 in which puma warns of multiple threads created before fork. As written the listener for each process will be invoked by the `ActionDispatch::Executor` middleware when the `updated?` method is called. This is the first middleware on the stack and will be invoked before application code is read into memory. The downside of this approach is that the API is a little less obvious. I.e. that you have to call `updated?` to get the listener to start is not intuitive. We could make `boot!` not private if we want to make the API a little nicer. Alternatively we could boot when the checker is initialized however this reintroduces the puma threads warning, and also means that in cases of `rails server` or when using `preload!` that we have extra threads notifying of changes on a process that we don't care about. [close #24990] [close #25259]
* | | | | | | | Merge pull request #25421 from maclover7/jm-mv-filesSean Griffin2016-06-172-0/+0
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Move code style configuration files to root directory
| * | | | | | | | Move code style configuration files to root directoryJon Moss2016-06-162-0/+0
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I think these are meant to be in the root directory, not in `/activerecord`? :grimacing: r? @sgrif [ci skip]
* | | | | | | | Merge pull request #24773 from ralinc/fix-silent-fail-on-psql-commandArthur Nogueira Neves2016-06-163-3/+18
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | PostgreSQL: Fix db:structure:load silent failure on SQL error
| * | | | | | | | PostgreSQL: Fix db:structure:load silent failure on SQL errorRalin Chimev2016-05-103-3/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The command line flag "-v ON_ERROR_STOP=1" should be used when invoking psql to make sure errors are not suppressed. Example: psql -v ON_ERROR_STOP=1 -q -f awesome-file.sql my-app-db Fixes #23818.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-08 11:35:04 +0000