| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|\
| |
| |
| |
| |
| |
| | |
Fair connection pool2
Conflicts:
activerecord/test/cases/associations/eager_test.rb
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The core of this fix is a threadsafe, fair Queue class. It is
very similar to Queue in stdlib except that it supports waiting
with a timeout.
The issue this solves is that if several threads are contending for
database connections, an unfair queue makes is possible that a thread
will timeout even while other threads successfully acquire and release
connections. A fair queue means the thread that has been waiting the
longest will get the next available connection.
This includes a few test fixes to avoid test ordering issues that
cropped up during development of this patch.
|
| |
| |
| |
| |
| | |
Reason: If metadata is not cached extra sql statements
will be executed, which causes failures tests with assert_queries().
|
|\ \
| | |
| | | |
current AR::ConnectionAdapters::SQLite3Adapter supports only SQLite3 ~> 1.3.6
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
amatsuda/ignore_git_ignored_files_in_rake_test_uncommitted
ignore .gitignore'd files in rake test:uncomitted
|
| |/ / |
|
|\ \ \
| | | |
| | | | |
TimeZone format is always /[+-]\d{2}:\d{2}/ in Ruby 1.9
|
| |/ / |
|
|\ \ \
| | | |
| | | | |
both string and symbol will be interpolated as string no need to convert to_s
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Proc always respond_to :binding
|
| |/ / |
|
|\ \ \
| |/ /
|/| | |
Fix: 'rake rails:templates:copy' doesn't work
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | | |
takkanm/fix-character-class-duplicated-range-warning
fix warning in Ruby2.0.0
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
```
rails/activesupport/lib/active_support/multibyte/chars.rb:136: warning:
character class has duplicated range: /\b('?[\S])/
```
|
|\ \ \ \
| |/ / /
|/| | | |
Address ORA-00911 errors because of the heading underscore.
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Fix that #exists? can blow up with ThrowResult exception
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
reflection.
ActiveRecord::FinderMethods#construct_limited_ids_condition will raise
ThrowResult if the limited reflection comes back empty. The other callers
of #construct_limited_ids_condition handle this exception (more specifically,
the callers of construct_relation_for*), but #exists? didn't until now.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This behavior was added in be4ecdcc87984e9421ff5d5c90d33f475e0fbc01.
Closes #1139.
Fixes #2553, #1141, #1623 and #2062.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
others happy that do not work without a column alias.
Conflicts:
activerecord/lib/active_record/relation/finder_methods.rb
|
|\ \ \
| | | |
| | | | |
Fix #6635. We should call Scoping methods, before calling Array methods.
|
| | | | |
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
There are two possible scenarios where the @mass_assignment_options
instance variable can become corrupted:
1. If the assign_attributes doesn't complete correctly, then
subsequent calls to a nested attribute assignment method will use
whatever options were passed to the previous assign_attributes call.
2. With nested assign_attributes calls, the inner call will overwrite
the current options. This will only affect nested attributes as the
attribute hash is sanitized before any methods are called.
To fix this we save the current options in a local variable and then
restore these options in an ensure block.
|
|\ \ \
| | | |
| | | | |
Build fix broken here 03f2249153ae4d2078646e6796d8b9e5ef747fba
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Add Prompt to 404 & 500 Pages to Check Logs in Production
|
| | | |
| | | |
| | | | |
When new programmers push their code to a production server and receive an error they often don't know to check the logs, this simple reminder will help. Most professional applications have custom error pages so this change shouldn't affect them. The wording of the message should not confuse non-developer visitors.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Notify A User they Have Pending Migrations
|
| | | | |
| | | | |
| | | | | |
App should raise error on page_load
|
| | | | |
| | | | |
| | | | | |
can be configured by setting config.active_record.migration. Setting to :page_load will raise an error on each page refresh if there are migrations that are pending. Setting to :page_load is defaulted in development for new applications.
|
| | | | |
| | | | |
| | | | | |
if a rails project needs to be migrated ActiveRecord::Migrator.needs_migration? will be true or false if the current version matches the last version.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix fragile #assert_queries implementation and usages.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Several tests that passed when run in the order they are loaded
by rake test were failing when run in different sequences due to
problems with the implementation of assert_queries and
assert_no_queries as well as incorrect assumptions made about
how many queries might be executed by a database adapter in
various cases.
|
| |_|/ / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This is an obsolete method from the very early days,
apparently it was used circa 2004 because STI support
was not smart enough. This method is not public
interface, and we are heading a major version, so
removal seems right.
|
| | | | | |
|
| | | | | |
|
| |_|/ /
|/| | |
| | | |
| | | | |
ActiveRecord#attributes optimization: minimize objects created
|
|/ / /
| | |
| | |
| | | |
Fix for a test failing after: 00ff0a6776
|
|\ \ \
| | | |
| | | | |
Compact array of values added to PermissionSet instance
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Plugin gen fix
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
if we are passing -T which is skip_test_unit
See issue #6673 for more details.
I saw that we are not creating dummy app even if
we do skip_test_unit.
Fixes #6673
|
| | | | | |
|