aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add `skip-webpack-install` optionyuuji.yaginuma2018-10-093-1/+22
| | | | | This option is useful when want to check only the files generated by `rails new`, or if want to do something before `webpacker:install`.
* Call `define_attribute_methods` before `assert_no_queries` to address CI ↵Ryuta Kamizono2018-10-095-9/+80
| | | | | | | | | | | | flakiness Follow up 45be690f8e6db019aac6198ba49d608a2e14824b. Somehow calling `define_attribute_methods` in `build`/`new` sometimes causes the `table_exists?` query. To address CI flakiness due to `assert_no_queries` failure, ensure `define_attribute_methods` before `assert_no_queries`.
* Merge pull request #34126 from gregmolnar/guide-link-fixRyuta Kamizono2018-10-092-2/+2
|\ | | | | fix broken link in Action Cable guides and readme [ci skip]
| * fix broken link in Action Cable guides and readme [ci skip]Greg Molnar2018-10-082-2/+2
| |
* | Point to requiring the ASt engine in the installation instructions [ci skip]Donnie Propst2018-10-081-0/+2
| |
* | Fix directly uploading using a MIME type synonymGeorge Claghorn2018-10-082-1/+11
|\ \ | |/ |/| | | | | When Content-Type is "application/x-gzip", request.content_type resolves to "application/gzip", because application/x-gzip is a synonym of application/gzip by default. This causes the acceptable_content? check in ActiveStorage::DiskController to fail, because the direct upload token contains application/x-gzip, which is not equal to application/gzip. Fix by comparing the token content type with the request content type *and its synonyms*.
| * Use content_mime_typeGraham Conzett2018-10-081-2/+1
| |
| * Fix issue ActiveStorage direct upload diskGraham Conzett2018-10-072-1/+12
| | | | | | | | | | | | Fix an issue in ActiveStorage where a direct upload to disk storage would fail due to a content type mismatch if the file was uploaded using a mime-type synonym.
* | Merge pull request #33324 from ↵Ryuta Kamizono2018-10-083-11/+27
|\ \ | | | | | | | | | | | | Jcambass/fix-only-path-option-in-url-for-with-arrays respect only_path option when an array is passed into url_for
| * | respect path_only option when an array is passed into url_forJoel Ambass2018-10-013-11/+27
| | | | | | | | | | | | | | | | | | | | | | | | The url_for method is now extracting the path_only option in order to determine if polymorphic_path or polymorphic_url should be called. If the path_only option is not set it will be set to true unless the host option is set. This behaviour is the same as when a Hash or Params object is passed. To support this unifying the code responsible for setting this default value has been extracted into a private method
* | | Merge pull request #34039 from yskkin/parameter_filterRyuta Kamizono2018-10-087-125/+177
|\ \ \ | | | | | | | | Deprecate ActionDispatch::Http::ParameterFilter in favor of ActiveSup…
| * | | Deprecate ActionDispatch::Http::ParameterFilter in favor of ↵Yoshiyuki Kinjo2018-10-087-125/+177
| | | | | | | | | | | | | | | | ActiveSupport::ParameterFilter
* | | | Merge pull request #34119 from frodsan/patch-1Arun Agrawal2018-10-081-1/+1
|\ \ \ \ | |/ / / |/| | | [ci skip] Fix typo
| * | | [ci skip] Fix typoFrancesco Rodríguez2018-10-081-1/+1
|/ / /
* | | Don't expose internal methods in the associationsRyuta Kamizono2018-10-082-32/+32
| | |
* | | Fix test name to add missing "set"Ryuta Kamizono2018-10-081-1/+1
| | |
* | | Fix `AssociationRelation` not to set inverse instance key just like beforeRyuta Kamizono2018-10-073-3/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since #31575, `set_inverse_instance` replaces the foreign key by the current owner immediately to make it happen when a record is added to collection association. But `set_inverse_instance` is not only called when a record is added, but also when a record is loaded from queries. And also, that loaded records are not always associated records for some reason (using `or`, `unscope`, `rewhere`, etc). It is hard to distinguish whether or not we should invoke `set_inverse_instance`, but at least we should avoid the undesired side-effect which was brought from #31575. Fixes #34108.
* | | Merge pull request #34076 from gmcgibbon/fixtures_refactorEileen M. Uchitelle2018-10-074-243/+376
|\ \ \ | | | | | | | | Fixtures refactor
| * | | Move FixtureSet::ReflectionProxy and FixtureSet::HasManyThroughProxy to ↵Gannon McGibbon2018-10-052-32/+32
| | | | | | | | | | | | | | | | FixtureSet::TableRows
| * | | Introduce FixtureSet::TableRows and FixtureSet::TableRowGannon McGibbon2018-10-053-88/+183
| | | |
| * | | Introduce FixtureSet::ModelMetadataGannon McGibbon2018-10-052-29/+49
| | | |
| * | | Small refactors to FixtureSet::ClassCache and FixtureGannon McGibbon2018-10-051-9/+8
| | | |
| * | | Move FixtureSet.create_fixtures reading and inserting sections into private ↵Gannon McGibbon2018-10-051-41/+58
| | | | | | | | | | | | | | | | methods
| * | | Organize FixtureSet class methodsGannon McGibbon2018-10-051-102/+104
| | | |
* | | | Merge pull request #34114 from Madogiwa0124/update_getting_start_rails_versionEileen M. Uchitelle2018-10-071-1/+1
|\ \ \ \ | | | | | | | | | | getting started page rails version update to 5.2.1
| * | | | getting started page rails version update to 5.2.1Madogiwa2018-10-071-1/+1
| | | | |
* | | | | Merge pull request #34089 from lsylvester/test-cache-version-precisionRichard Schneeman2018-10-061-31/+55
|\ \ \ \ \ | | | | | | | | | | | | add test for cache_version precision
| * | | | | add test for cache_version precisionLachlan Sylvester2018-10-071-31/+55
|/ / / / /
* | | | | Merge pull request #34077 from cllns/clarify-activesupport-instructionYuji Yaginuma2018-10-061-0/+8
|\ \ \ \ \ | | | | | | | | | | | | ActiveStorage guide: Add instruction for test environment
| * | | | | Add instruction for test environmentSean Collins2018-10-051-0/+8
| | | | | |
* | | | | | Merge pull request #34005 from tgturner/expand-cache-key-bug-fixRichard Schneeman2018-10-052-1/+50
|\ \ \ \ \ \ | | | | | | | | | | | | | | Array with single item correctly uses cache_key
| * | | | | | Array with single item correctly uses cache_keyGraham Turner2018-10-052-1/+50
|/ / / / / /
* | | | | | Merge pull request #34084 from trustvox/masterRafael França2018-10-052-4/+2
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Remove "include FileUtils" sentence in setup/update bin files
| * | | | | Remove "include FileUtils" sentence in setup/update bin filesBruno Casali2018-09-172-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | According with rubocop style guide "Style/MixinUsage" is good to use only in class/module not directly in file.
* | | | | | Remove unnecessary use of `included` in ActiveJob::CoreAlan Wu2018-10-051-21/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using `included` to define `attr_acessor` and `attr_writer` is causing these methods to not show up in the documentation.
* | | | | | Merge pull request #34103 from albertoalmagro/guides-running-test-with-seedGannon McGibbon2018-10-051-0/+20
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add documentation to run tests with specific seed [ci skip]
| * | | | | | Add documentation to run tests with specific seed [ci skip]Alberto Almagro2018-10-051-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit documents how to run all tests or a single test file with a specific randomization seed.
* | | | | | | Merge pull request #34101 from gmcgibbon/fix_bundler_1_16_6_test_failuresRafael França2018-10-051-8/+10
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Remove bundler warnings from bin/setup output
| * | | | | | | Remove bundler warnings from bin/setup outputGannon McGibbon2018-10-051-8/+10
| |/ / / / / /
* | | | | | | Merge pull request #34097 from kule/masterRafael França2018-10-054-1/+27
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Parameterized mailers can configure delivery job
| * | | | | | | Parameterized mailers can configure delivery jobLuke Pearce2018-10-054-1/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Setting parameterized_delivery_job on a mailer class will cause Parameterized::MessageDelivery to use the specified job instead of ActionMailer::Parameterized::DeliveryJob: class MyMailer < ApplicationMailer self.parameterized_delivery_job = MyCustomDeliveryJob ... end
* | | | | | | | Merge pull request #34102 from gmcgibbon/less_aggressive_auto_labelingRafael França2018-10-051-22/+0
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Remove some autolabeling globs
| * | | | | | | | Remove some autolabeling globsGannon McGibbon2018-10-051-22/+0
| | |/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | [ci skip]
* / | | | | | | update nokogiriGreg Molnar2018-10-051-4/+4
|/ / / / / / /
* | | | | | | Merge pull request #34096 from ↵Rafael França2018-10-051-0/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | prathamesh-sonpatki/exclude-node-modules-for-rubocop Skip node_modules dir in the rubocop check
| * | | | | | | Skip node_modules dir in the rubocop checkPrathamesh Sonpatki2018-10-051-0/+1
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | - Otherwise it is running the check against all files in node_modules
* | | | | | | Merge pull request #34095 from prathamesh-sonpatki/fix-tests-related-to-acGuillermo Iguaran2018-10-054-8/+6
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Fix tests related to new JavaScript path for generators
| * | | | | | Fix tests related to new JavaScript path for generatorsPrathamesh Sonpatki2018-10-054-8/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - Followup of https://github.com/rails/rails/commit/4838c1716a0340137d858fab49bf460e23be5a4b
* | | | | | | Merge pull request #34068 from schneems/schneems/micro-optimize-try-nilRichard Schneeman2018-10-051-2/+2
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | 23% faster Nil#try
| * | | | | | | This PR speeds up Nil#try by avoiding an allocation when only one argument ↵schneems2018-10-031-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | is passed: ```ruby class FooNew def try(method_name = nil, *args) nil end end class FooOld def try(*args) nil end end require 'benchmark/ips' foo_new = FooNew.new foo_old = FooOld.new Benchmark.ips do |x| x.report("new") { foo_new.try(:anything) } x.report("old") { foo_old.try(:anything) } x.compare! end # Warming up -------------------------------------- # new 250.633k i/100ms # old 232.322k i/100ms # Calculating ------------------------------------- # new 6.476M (± 4.8%) i/s - 32.332M in 5.005777s # old 5.258M (± 3.2%) i/s - 26.485M in 5.042589s # Comparison: # new: 6476002.5 i/s # old: 5257912.5 i/s - 1.23x slower ``` It's worth noting that checking for nil separately as in https://github.com/rails/rails/pull/34067 seems to be MUCH faster. It might be worth it to apply a blanket `&.` to every internal `try` call.
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-15 02:51:50 +0000