Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | remove unused and untested API | Aaron Patterson | 2014-10-31 | 1 | -6/+2 |
| | |||||
* | fix set_pk_sequence and add a test for it. | Aaron Patterson | 2014-10-31 | 2 | -1/+9 |
| | |||||
* | Added region sequencing of primary keys for Postgres. | Joe Rafaniello | 2014-10-31 | 1 | -0/+21 |
| | | | | | | | Skip setting sequence on a table create if the value is 0 since it will start the first value at 1 anyway. This fixes the PG error 'setval: value 0 is out of bounds for sequence vms_id_seq...' encountered when migrating a new DB. BugzID: 15452,9772,13475,16850 | ||||
* | Don't attempt to load the schema file in tests if none exists | Sean Griffin | 2014-10-31 | 2 | -3/+18 |
| | |||||
* | Don't modify the columns hash to set defaults from the attributes API | Sean Griffin | 2014-10-31 | 3 | -14/+39 |
| | | | | | Nothing is directly using the columns for the default values anymore. This step helps us get closer not not mutating the columns hash. | ||||
* | Load test schema even if there are no migrations | Sean Griffin | 2014-10-31 | 2 | -1/+18 |
| | | | | Fixes #17170 | ||||
* | Merge pull request #17040 from clyfe/patch-1 | Rafael Mendonça França | 2014-10-31 | 1 | -2/+4 |
|\ | | | | | Explicit route test class | ||||
| * | Explicit route test class | Claudius Nicolae | 2014-09-24 | 1 | -2/+4 |
| | | | | | | shows the class that the test must extend in order to have the assert_routing method available | ||||
* | | Merge pull request #17305 from ↵ | Rafael Mendonça França | 2014-10-31 | 2 | -1/+90 |
|\ \ | | | | | | | | | | | | | ziggythehamster/activerecord-connectionhandling-RAILS_ENV-without-rails If Rails is not defined, check ENV["RAILS_ENV"] and ENV["RACK_ENV"] in ActiveRecord::ConnectionHandling | ||||
| * | | If Rails is not defined, check ENV["RAILS_ENV"] and ENV["RACK_ENV"]. | Keith Gable | 2014-10-21 | 2 | -1/+90 |
| | | | | | | | | | | | | | | | | | | | | | This fixes a regression introduced by 6cc03675d30b58e28f585720dad14e947a57ff5b. ActiveRecord, if used without Rails, always checks the "default_env" environment. This would be OK, except that Sinatra also supports environments, and it runs with {RACK|RAILS}_ENV=production. This patch adds a fallback to RAILS_ENV and RACK_ENV (and ultimately default_env) if Rails.env doesn't exist. | ||||
* | | | Merge pull request #17462 from vipulnsward/actionmailer-doc-fix | Rafael Mendonça França | 2014-10-31 | 1 | -2/+7 |
|\ \ \ | | | | | | | | | AM README fixes [ci skip] | ||||
| * | | | - Changed redundant user of `deliver` to `deliver_now` | Vipul A M | 2014-11-01 | 1 | -2/+7 |
| | | | | | | | | | | | | | | | | | | | | - Wrapped text in setting defaults section. Also added break, to a sentence. [ci skip] | ||||
* | | | | Use the correct values for int max and min | Sean Griffin | 2014-10-31 | 3 | -56/+119 |
| | | | | | | | | | | | | | | | | | | | | We had accidentally gone one power of two too far. In addition, we need to handle minimum values as well as the maximum. | ||||
* | | | | Tiny documentation improvements [ci skip] | Robin Dupret | 2014-10-31 | 3 | -11/+8 |
| | | | | |||||
* | | | | Merge branch 'tags-public-send' | Rafael Mendonça França | 2014-10-31 | 2 | -1/+15 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | Fixes #14180 Fixes #17461 | ||||
| * | | | | Improve test of private properties of objects in form tags | Rafael Mendonça França | 2014-10-31 | 1 | -28/+9 |
| | | | | | |||||
| * | | | | Use public_send for form tags | agius | 2014-10-31 | 1 | -0/+27 |
| | | | | | |||||
| * | | | | Honor public/private in ActionView::Helpers::Tags::Base#value | Tobias Pfeiffer | 2014-10-31 | 2 | -1/+7 |
|/ / / / | | | | | | | | | | | | | | | | | * use public_send instead of send to avoid calling private methods in form helpers | ||||
* | | | | Merge pull request #17459 from sgrif/sg-find-by-large-numbers | Sean Griffin | 2014-10-31 | 9 | -18/+56 |
|\ \ \ \ | |/ / / |/| | | | Treat strings greater than int max value as out of range | ||||
| * | | | Treat strings greater than int max value as out of range | Sean Griffin | 2014-10-31 | 9 | -18/+56 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sufficiently large integers cause `find` and `find_by` to raise `StatementInvalid` instead of `RecordNotFound` or just returning `nil`. Given that we can't cast to `nil` for `Integer` like we would with junk data for other types, we raise a `RangeError` instead, and rescue in places where it would be highly unexpected to get an exception from casting. Fixes #17380 | ||||
* | | | | Merge pull request #17460 from hbriggs/master | Abdelkader Boudih | 2014-10-31 | 1 | -4/+7 |
|\ \ \ \ | |/ / / |/| | | | Masked authenticity token section, finder options details, misc typos [ci skip] | ||||
| * | | | Add masked authenticity token section, details on finder options, misc typos ↵ | Hannah Briggs | 2014-10-31 | 1 | -5/+8 |
| | | | | | | | | | | | | | | | | [ci skip] | ||||
* | | | | Rename `default_attributes` to `_default_attributes` | Sean Griffin | 2014-10-31 | 2 | -3/+3 |
| | | | | | | | | | | | | | | | | | | | | It is internal use only. This is to avoid conflicting with users' method names. Fixes #17458 | ||||
* | | | | Don't require calculations to be aliased to a column | Sean Griffin | 2014-10-31 | 2 | -2/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Arel has changed so that `.sum` no longer aliases `SUM(the_column)` to `sum_id`. This means the type returned by the adapter will be at the key `"SUM(the_column)"`. Longer term, we should eventually be able to retain type information from the AR::Base subclasses used in joined queries | ||||
* | | | | Do not package the guides output | Rafael Mendonça França | 2014-10-31 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | Fixes #17455 | ||||
* | | | | Merge pull request #17451 from y-yagi/fix_asi_guide | Abdelkader Boudih | 2014-10-31 | 1 | -5/+5 |
|\ \ \ \ | | | | | | | | | | | [ci skip] fix incorrect key in Active Support Instrumentation guide | ||||
| * | | | | [ci skip] fix incorrect key in Active Support Instrumentation guide | yuuji.yaginuma | 2014-10-31 | 1 | -5/+5 |
|/ / / / | |||||
* | | | | Prepare for 4.2.0.beta4 release | Godfrey Chan | 2014-10-30 | 10 | -10/+10 |
| | | | | |||||
* | | | | Use released arel | Godfrey Chan | 2014-10-30 | 2 | -2/+2 |
| | | | | |||||
* | | | | Merge pull request #17440 from claudiob/remove-yet-another-redundant-to-s | Xavier Noria | 2014-10-30 | 9 | -15/+15 |
|\ \ \ \ | | | | | | | | | | | Remove redundant `to_s` in interpolation | ||||
| * | | | | Remove redundant `to_s` in interpolation | claudiob | 2014-10-30 | 9 | -15/+15 |
| | | | | | |||||
* | | | | | Merge branch 'master-sec' | Aaron Patterson | 2014-10-30 | 2 | -4/+32 |
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | * master-sec: FileHandler should not be called for files outside the root | ||||
| * | | | | | FileHandler should not be called for files outside the root | Aaron Patterson | 2014-10-10 | 2 | -4/+32 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | FileHandler#matches? should return false for files that are outside the "root" path. | ||||
* | | | | | | Add status code to AS::Instrumentation table, like #17441 [ci skip] | Zachary Scott | 2014-10-30 | 1 | -0/+1 |
| | | | | | | |||||
* | | | | | | Merge branch 'strzalek-asn-docs-fix' | Zachary Scott | 2014-10-30 | 1 | -0/+1 |
|\ \ \ \ \ \ | |||||
| * | | | | | | Add :db_runtime to table [ci skip] | Łukasz Strzałkowski | 2014-10-30 | 1 | -0/+1 |
|/ / / / / / | | | | | | | | | | | | | | | | | | | It was missing from table, but is present in sample hash below | ||||
* | / / / / | Use `#between`, rather than `#in` for passing Ranges to Arel | Sean Griffin | 2014-10-30 | 3 | -2/+3 |
| |/ / / / |/| | | | | | | | | | | | | | | Passing ranges to `#in` has been deprecated in Arel. | ||||
* | | | | | Merge pull request #17434 from claudiob/remove-redundant-to-s | Xavier Noria | 2014-10-30 | 1 | -2/+2 |
|\ \ \ \ \ | | | | | | | | | | | | | Remove redundant `to_s` in interpolation | ||||
| * | | | | | Remove redundant `to_s` in interpolation | claudiob | 2014-10-29 | 1 | -2/+2 |
| | | | | | | |||||
* | | | | | | Merge pull request #17308 from pabloh/small_optimizations | Jeremy Kemper | 2014-10-29 | 3 | -3/+3 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Faster to call `gsub` with a regexp literal than a string literal | ||||
| * | | | | | | Do gsub with a regexp instead of a string | Pablo Herrero | 2014-10-29 | 3 | -3/+3 |
| | | | | | | | |||||
* | | | | | | | add bigserial pk support | Aaron Patterson | 2014-10-29 | 3 | -0/+23 |
| | | | | | | | |||||
* | | | | | | | Merge pull request #17433 from pabloh/fix_typo | Rafael Mendonça França | 2014-10-29 | 1 | -2/+2 |
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | | Fix typo [ci skip] | ||||
| * | | | | | | Fix typo at form_helper docs [ci skip] | Pablo Herrero | 2014-10-29 | 1 | -2/+2 |
|/ / / / / / | |||||
* | | | | | | Merge pull request #17432 from cmoylan/update-active-job-guide | Rafael Mendonça França | 2014-10-29 | 1 | -1/+1 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | correct GlobalID mixin name in the guides | ||||
| * | | | | | | correct GlobalID mixin name in the guides | Chris Moylan | 2014-10-29 | 1 | -1/+1 |
|/ / / / / / | |||||
* | | | | | | Merge pull request #17431 from hbriggs/upgrade_guide_2.7_2.8 | Rafael Mendonça França | 2014-10-29 | 1 | -3/+3 |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Update 2.7 & 2.8 of upgrading_ruby_on_rails.md [ci skip] | ||||
| * | | | | | | [ci skip] Fixes typos in section 2.7 "Rails Html Sanitizer", adds content to ↵ | Hannah Briggs | 2014-10-29 | 1 | -3/+3 |
|/ / / / / / | | | | | | | | | | | | | | | | | | | section 2.8 "Rails DOM Testing" | ||||
* | | | | | | Merge pull request #17429 from edwinwills/full-height-email-preview | Rafael Mendonça França | 2014-10-29 | 1 | -1/+4 |
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | The email preview iframe height is fixed and does not scale to the browser size | ||||
| * | | | | | On larger screens the email preview iframe is being limited to a height of ↵ | Edwin Wills | 2014-10-29 | 1 | -1/+4 |
|/ / / / / | | | | | | | | | | | | | | | | 800 pixels, and the full available screen size is not being used. |