| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fix MailerPreview broken tests
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`BaseMailerPreview.welcome` is an instance method, so we need to stub the
method on a instance level and not on Class. The stub is important to make
sure the Message object is the same in the other expectations.
This was working randomly because Mocha uses == to compare two objects
on the `with()` expectation and even if the Mail::Message objects were
not the same object they are equal, but thats not the case in 100% of
the runs. So we need to make sure we use `.any_instance` method and have
the right message object.
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
add include_hidden option to collection_check_boxes helper
Conflicts:
actionview/CHANGELOG.md
actionview/test/template/form_collections_helper_test.rb
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Minor grammer, code conventions fix [ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
Conflicts:
activesupport/lib/active_support/core_ext/hash/conversions.rb
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
requires. Appropriate to keep this, users don't care that the implementation got unified.
|
|\ \ \ \ \
| |_|/ / /
|/| | | |
| | | | |
| | | | | |
tgxworld/use_teardown_helper_method_in_activerecord
Use teardown helper method.
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Follow-Up to https://github.com/rails/rails/pull/14348
Ensure that SQLCounter.clear_log is called after each test.
This is a step to prevent side effects when running tests. This will allow us to run them in random order.
|
| | | |
| | | |
| | | |
| | | | |
Fixes #14383.
|
|\ \ \ \
| | | | |
| | | | | |
Update callbacks executed on AR::Base#touch [skip ci]
|
| | |_|/
| |/| |
| | | |
| | | |
| | | | |
As of https://github.com/rails/rails/pull/12031 after_commit and
after_rollback are also executed
|
|\ \ \ \
| | | | |
| | | | | |
Fix #to_json for BasicObject Enumerables
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
Allow custom JDBC urls
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
mitigates #14323
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Before we had a bug in the resolver cache so the disable_cache were not
working when passing options to find
|
|\ \ \ \ \
| |_|/ / /
|/| | | |
| | | | | |
Ensure LookupContext in Digestor selects correct variant
|
| | | | |
| | | | |
| | | | |
| | | | | |
finder object
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
We're setting variant above, in request object directly
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Related to: #14242 #14243 14293
Variants passed to LookupContext#find() seem to be ignored, so
I've used the setter instead: `finder.variants = [ variant ]`.
I've also added some more test cases for variants. Hopefully this
time passing tests will mean it actually works.
|
| | | | | |
|
| |/ / /
|/| | | |
|
| | | |
| | | |
| | | |
| | | | |
See https://github.com/rails/sass-rails/issues/191 for more information
|
| |/ /
|/| | |
|
|\ \ \
| | | |
| | | | |
Fix probs in sections 5.6 and 5.9; [ci skip]
|
| | | | |
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Make select_all on query cache accept a Relation without binds.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
[fixes #14361]
[related #13886]
|
|\ \ \ \
| | | | |
| | | | | |
Add test for deprecation warning for passing an AR object to `find`.
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Add test for deprecation warning for passing an AR object to `exists?`.
|
| |/ / /
| | | |
| | | |
| | | | |
`exists?`
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
thor's create_file seems to have a circular dependency on itself when
used with our constant loading stuff.
fixes #14319
|
| | |
| | |
| | |
| | | |
please pass the id of the AR object by calling `.id` on the model first.
|
| | |
| | |
| | |
| | |
| | | |
Pass the id of the object to the method by calling `.id` on the AR
object.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Apparently we've been using a buggy feature for the past 6 years:
https://bugs.ruby-lang.org/issues/9593
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Two bits of example code use sqlite as an adapter, which doesn't exist.
Using the code verbatim will raise a LoadError exception:
ActiveRecord::Base.establish_connection(
"adapter" => "sqlite",
"database" => "db.sqlite"
)
# => LoadError: Could not load 'active_record/connection_adapters/sqlite_adapter'...
Considering this is code a lot of people new to Rails might be running,
it's especially confusing.
Closes #14367 [ci skip]
|
| | |
| | |
| | |
| | |
| | |
| | | |
avoid freezing the headers until the web server has actually read data
from the body proxy. Once the webserver has read data, then we should
throw an error if someone tries to set a header
|