| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
If an AWS bucket name includes a `.` (e.g. `bucket.name`), then the canonical
URL for an object will start with "https://s3.amazonaws.com/bucket.name/"
and not with "https://bucket.name.s3.amazonaws.com/".
The URL tests have now been separated into two separate asserts, to ensure
that both the "s3.amazonaws.com" and the "bucket.name" components are included,
but not specifically in that order.
|
|
|
| |
Before we forget...
|
|
|
|
|
|
|
|
| |
The test was passing before because it was not being testes correctly.
Now we create a different engine that is loaded before the already
exising and we make sure that the first call for isolate_namespace is
what takes effect.
|
|
|
|
|
|
|
|
|
| |
What we want to test is that two different calls to isolate_namespace
with the same module doesn't change the original railtie. We can do that
defining two different railties.
We can't call in the application because this method is not supposed to
be called in an Application class.
|
|
|
|
| |
And deal with a temporary test fix until we allow you to skip active storage.
|
| |
|
| |
|
|
|
|
|
|
| |
We are already removing the braces around hash parameters in the last
argument in other places so we should not change the entire codebase
because of two places.
|
|\
| |
| | |
Change azure core dependency
|
| |
| |
| |
| |
| | |
No need to depend on my fork anymore, they've just release fix
officially.
|
| | |
|
|\ \
| | |
| | | |
Make Rubocop happy about ActiveStorage
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Running `rubocop activestorage` before this commit resulted in 20 offenses.
This commit only fixes:
- Trailing whitespace detected
- Space inside } missing
- Put one space between the method name and the first argument.
The other offenses are left since they are intentional according to
@georgeclaghorn (https://github.com/rails/rails/pull/30061#issuecomment-319999190)
|
| | | |
|
| | |
| | |
| | |
| | | |
Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them.
|
|\ \ \
| | | |
| | | |
| | | | |
active-storage-import
|
| | | |
| | | |
| | | |
| | | | |
FormHelper includes FormTagHelper so we don't need to define two methods
|
| | | |
| | | |
| | | |
| | | | |
Also make sure file_field doesn't mutate the original options passed in.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
When Active Storage is not loaded and direct_upload is used on
file_field_tag we should not raise an exception.
|
|/ / /
| | |
| | |
| | | |
It's worth considering whether we should hide these by default, but I'm kinda thinking no. It's very reasonable that someone would want to call these directly, so they should be documented.
|
| | |
| | |
| | |
| | | |
cc @rafaelfranca
|
| | | |
|
| | | |
|
|/ /
| |
| |
| |
| | |
I know those methods are unlikely to change but having one line method
is hard to read and also hard to modify.
|
| | |
|
| | |
|
|\ \
| |/
|/| |
Add Azure gems to README
|
| |
| |
| | |
Omit azure-core (it's required by azure-storage), remove require:false to match other points.
|
| | |
|
| | |
|
|/ |
|
|\
| |
| |
| |
| | |
kamipo/fix_string_literals_violations_for_active_storage
Fix `Style/StringLiterals` violations for Active Storage
|
|/
|
|
|
|
|
|
|
|
|
|
| |
```
% be rubocop -a --only Style/StringLiterals activestorage
Inspecting 74 files
........................................CCCCCCCCCC.C........CC.......C.C..
(snip)
74 files inspected, 31 offenses detected, 31 offenses corrected
```
|
|\ |
|
| |\
| | |
| | | |
Use File::NULL instead of "/dev/null"
|
| | | |
|
| |\ \
| | | |
| | | |
| | | |
| | | | |
kamipo/relation_merger_should_not_fill_empty_values
`Relation::Merger` should not fill `values` with empty values
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently `Relation#merge` will almost fill `values` with empty values
(e.g. `other.order_values` is always true, it should be
`other.order_values.any?`). This means that `Relation#merge` always
changes `values` even if actually `values` is nothing changed. This
behavior will makes `Relation#empty_scope?` fragile. So `Relation#merge`
should avoid unnecessary changes.
|
| |\ \ \
| | | | |
| | | | | |
Fix `find_by` with range conditions
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`StatementCache` doesn't support range conditions. So we need to through
the args to `FinderMethods#find_by` if range value is passed.
|
| |\ \ \ \
| | | | | |
| | | | | | |
Unlock minitest for Rails' test suite
|
| | |\ \ \ \ |
|
| | |\ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix test runner's output
|
| | |/ / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Output changed due to specification change of `SummaryReporter#aggregated_results`
in minitest 5.10.2.
In my opinion, that should fix rails's test runner(proceeding with #29354).
However, we still need discussion and the fix itself is minor, so I think
that we can fix only the test first.
|
| | |\ \ \ \ \
| | | | | | | |
| | | | | | | | |
Move `reset_pk_sequence!` test to `AdapterTestWithoutTransaction`
|
| | |/ / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
If execute PostgreSQL test with specifying 53853 for seed, the following
error will occur.
```
1) Error:
TransactionTest#test_restore_custom_primary_key_after_rollback:
ActiveRecord::RecordNotUnique: PG::UniqueViolation: ERROR: duplicate key value violates unique constraint "movies_pkey"
DETAIL: Key (movieid)=(2) already exists.
: INSERT INTO "movies" ("name") VALUES ($1) RETURNING "movieid"
```
travis is here https://travis-ci.org/rails/rails/jobs/254095918
As with #29287, it seems like a problem that the value of primary key
obtained from connection gets different.
Therefore, fixed to execute that test within transaction.
|
| | |\ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
y-yagi/reset_colun_information_after_schema_changed
Reset column information after schema changed
|
| | |/ / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This fixes the following failures.
https://travis-ci.org/rails/rails/jobs/253990014
|
| | |\ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
y-yagi/insert_environment_value_to_table_before_check_environment
Insert environment value to `InternalMetadata` table before check environment
|