| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Removed random dot in ActionController docs [ci skip]
|
| | |
|
|\ \
| | |
| | | |
Remove duplication in include test
|
| | | |
|
|\ \ \
| |_|/
|/| | |
metal is no longer mentioned on rack guide
|
| | | |
|
|\ \ \
| | | |
| | | | |
rescue from all exceptions in `ConnectionManagement#call`
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fixes #11497
As `ActiveRecord::ConnectionAdapters::ConnectionManagement` middleware does not rescue from Exception (but only from StandardError),
the Connection Pool quickly runs out of connections when multiple erroneous Requests come in right after each other.
Recueing from all exceptions and not just StandardError, fixes this behaviour.
|
|\ \ \ \
| |_|_|/
|/| | | |
Match Dev/Prod parity for Index Page
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
With Rails 4 the default index page was moved from a static file `index.html` inside the `public/` folder to an internal controller/view inside of the railties gem. This was to allow use of erb in the default index page and to remove the requirement that new apps must delete a static file to make their index pages work. While this was a good change, the functionality was unexpected to developers who wish to get their apps running in production ASAP. They will create a new app `rails new my app`, start a server to verify it works, then immediately deploy the app to verify that it can start working in production. Unfortunately locally they see a page when they visit `localhost:3000` when they visit their production app they get an error page.
We initially anticipated this problem in the original pull request, but did not properly anticipate the severity or quantity of people who would like this functionality. Having a default index page serves as an excellent litmus test for a passed deploy on default apps, and it is very unexpected to have a page work locally, but not on production.
This change makes the default index page available in production if the developer has not over-written it by defining their own `root` path inside of routes.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 9dc8aef084fc5ae7e3a396dd098d89da93d06fda, reversing
changes made to 02e8dae6279ea25312293a3eca777faf35139c4c.
|
|\ \ \ \
| | | | |
| | | | | |
add support for html attributes to grouped_options_for_select
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add logging performance [ci skip]
|
| | | | | | |
|
| | | | | | |
|
| |_|_|_|/
|/| | | | |
|
| |_|_|/
|/| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Fix an issue where Journey was failing to clear the named routes hash when the
routes were reloaded and since it doesn't overwrite existing routes then if a
route changed but wasn't renamed it kept the old definition. This was being
masked by the optimised url helpers so it only became apparent when passing an
options hash to the url helper.
|
|\ \ \ \ |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Thanks @fxn
|
| | | | |
| | | | |
| | | | |
| | | | | |
Closes rails/rails#11362
|
| |\ \ \ \
| | | | | |
| | | | | | |
fixes the test case of that plugins
|
| |/ / / / |
|
| | | | | |
|
| | | | | |
|
| |\ \ \ \ |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Array#to_s calls each element's inspect since ruby 1.9
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Rename the I18n keys for associations' restrict_dependent_destroy errors
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
restrict_dependent_destroy errors
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Removed information about creating database [ci skip]
|
| | |_|_|/ /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- As default index page is no longer in public folder, rails hits the
welcome controller in railties for index action
- If the database is not created or username and password are
incorrect in database.yml, those errors are first shown before index
action succeeds
- welcome#index succeeds iff the database is created with correct
details in database.yml
- So this information about creating database is not required in the
index template
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Rails 4.0 release notes. Explain major features added and removed.
|
|/ / / / / |
|
|\ \ \ \ \
| |_|_|/ /
|/| | | | |
Extract verbs array from helper to a contant
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Fix test name typos
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Upgrade guide. Renaming Indexes on tables. [ci skip]
|
|/ / / /
| | | |
| | | |
| | | | |
https://github.com/rails/rails/commit/39eef1a565ef02e4dabc0811ef1bf4547ff9a60e#commitcomment-3672522
|
| | | |
| | | |
| | | |
| | | | |
Closes #11498.
|
| | | | |
|