| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|\
| |
| | |
Tiny: DRY default limit in ActiveRecord::Type::Integer
|
| | |
|
|\ \
| |/
|/| |
Tiny: Remove incorrect comment in ActiveRecord::Type::Value
|
|/
|
|
|
|
|
| |
Says it's only used for the schema, but they are in fact used for
other things. Integer verifies against the limit during casting,
and Decimal uses precision during casting. It may be true that
scale is only used for the schema.
|
|\
| |
| | |
Adding tip about jQuery UJS [ci skip]
|
|/
|
|
| |
Reference #18533
|
|\
| |
| | |
[ci skip] fix typo sill -> still
|
|/ |
|
|\
| |
| | |
Fix Typo SecureToken for schema sample [ci skip]
|
| | |
|
|\ \
| |/
|/| |
Time columns should support time zone aware attributes
|
| |
| |
| |
| |
| |
| | |
The types that are affected by `time_zone_aware_attributes` (which is on
by default) have been made configurable, in case this is a breaking
change for existing applications.
|
|\ \
| |/
|/| |
|
| |
| |
| |
| |
| | |
Before: http://take.ms/z39h2
After: http://take.ms/Mo0G3
|
| | |
|
| |
| |
| |
| |
| |
| | |
Closes https://github.com/rails/rails/issues/18372
[ci skip]
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It is clearer and closer to reality to use `@article.updated_at` as
the `:last_modified` parameter of `fresh_when` and `stale?`.
Using `@article.created_at` would result in the cache never expiring,
since the creation timestamp never changes.
[ci skip]
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Many methods in ActiveSupport::Inflector were actually documenting
the String methods with the same name.
For instance the doc for `camelize` said:
> If the argument to +camelize+ is set to <tt>:lower</tt>...
while it should say:
> If the +uppercase_first_letter+ parameter is set to false
[ci skip]
|
| |
| |
| | |
rails/rails#18305, thanks for @dhh suggestion
|
| |
| |
| | |
rails/rails#18305, thanks for @dhh suggestion
|
| |
| |
| |
| | |
rails/rails#18305
|
| |
| |
| |
| | |
rails/rails#18305
|
| |
| |
| |
| | |
rails/rails#18305
|
| |
| |
| |
| |
| |
| | |
While we don't want to change the form input when validations fail,
blindly using `_before_type_cast` will cause the input to display the
wrong data for any type which does additional work on database values.
|
| |
| |
| |
| |
| |
| |
| | |
If you entered incorrect input into a form (particularly with a
numericality validation), we should not replace what you typed in with
`0`, since clicking submit a second time would essentially be the same
as erroneously accepting the junk input as 0.
|
| |
| |
| |
| | |
This reverts commit 787e22bb491bd8c36db1e9734261c4ce02c5c5fd.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We should never be ignoring valuable information that the types may need
to give us. The reason that it originally used `_before_type_cast` is
unclear, but appears to date back long enough that the reasons may not
be relevant today. There is only one test that asserts that it uses the
before type cast version, but it gives no context as to why and uses a
mock which does not simulate the real world.
Fixes #18523.
|
| |
| |
| |
| |
| |
| | |
Building the Arel AST, and manipulating the relation manually like this
is prone to errors and breakage as implementation details change from
underneath it.
|
| |
| |
| |
| |
| |
| | |
Building the Arel AST, and manipulating the relation manually like this
is prone to errors and breakage as implementation details change from
underneath it.
|
| |
| |
| |
| |
| |
| |
| | |
This behavior exists only to support fixtures, so we should handle it
there. Leaving it in `#quote` can cause very subtle bugs to slip
through, by things appearing to work when they should be blowing up
loudly, such as #18385.
|
|\ \
| | |
| | | |
Correct the views that the mail method sends in API docs.
|
| | | |
|
|\ \ \
| | | |
| | | | |
Changed "in GitHub" to "on GitHub" [ci skip]
|
| | | |
| | | |
| | | |
| | | | |
- Followup of https://github.com/rails/rails/pull/18503.
|
|\ \ \ \
| |/ / /
|/| | | |
Fix typo in ActionView CHANGELOG [ci skip]
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Changed `IN` to `ON` in markdown renderer condition
|
| | | |
| | | |
| | | |
| | | | |
- Changed `IN` to `ON` in all note sentences in guides.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Grammar: "By default, Rails loads generators from your load path." [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Extract `Date` header to string constant in Http Response, similar to other headers
|
| |/ / / /
| | | | |
| | | | |
| | | | | |
headers
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
fix link in autoloading guide [ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
yoshiokatsuneo/active_record_connection_pool_error_disconnect
ActiveRecord: On reconnection failure, release only failed connetion.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
On reconnection failure, all the connection was released.
But, it is better to release only failed connection.
This patch changes not to release all the connection but release
only failed connection.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix form_for guide binding a form to an object. [ci skip]
|