Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | Mark the result of grouped_options_for_select as HTML safe [#4322 ↵ | Kieran Pilkington | 2010-04-16 | 2 | -1/+5 | |
| | | | | | | | | | | | | state:committed] Signed-off-by: Xavier Noria <fxn@hashref.com> | |||||
* | | Add missing require | Santiago Pastorino | 2010-04-16 | 1 | -0/+1 | |
| | | ||||||
* | | Bump rack-mount dependency to ~> 0.6.3 for CRITICAL FIX | Jeremy Kemper | 2010-04-16 | 2 | -3/+3 | |
| | | ||||||
* | | fixing invalid yaml [#4418 state:resolved] | Aaron Patterson | 2010-04-16 | 1 | -1/+4 | |
| | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | | Revert "Require rack-mount 0.6.0 since 0.6.1 and later can't be bundled" | Jeremy Kemper | 2010-04-16 | 2 | -3/+3 | |
| | | | | | | | | | | | | They can be bundled. Just the git repos can't. Use rails/rack-mount for that. This reverts commit ef6cdc974f7c3d98eb0a3ad65761e10600f04110. | |||||
* | | Fix Active Model observer tests | Jeremy Kemper | 2010-04-16 | 2 | -2/+4 | |
| | | ||||||
* | | improve how ActiveRecord::Observer defines callbacks on observed models | Mislav Marohnić | 2010-04-16 | 2 | -7/+24 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of using a single `notify_observers` call for every callback type, each observer now registers a unique callback for itself. Example: before_save :_notify_user_observer_for_before_save def _notify_user_observer_for_before_save observer.update(:before_save, self) end Benefit: "before" callbacks halt when `observer.update` returns false. This way, ActiveRecord observers can prevent records from saving. [#4087 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | | ActiveModel::Observing: stop using Observable Ruby module, re-implement ↵ | Mislav Marohnić | 2010-04-16 | 2 | -7/+36 | |
| | | | | | | | | | | | | | | | | | | `notify_observers` `Observable#notify_observers` from Ruby always returns false (which halts ActiveRecord callback chains) and has extra features (like `changed`) that were never used. Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | | merge callbacks_observers_test.rb into lifecycle_test.rb where other ↵ | Mislav Marohnić | 2010-04-16 | 2 | -37/+34 | |
| | | | | | | | | | | | | | | | | observers test reside Benefits: test able to run independently, subclassing instead of changing the original Comment model Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | | fix a failure and some warnings on 1.9.2 [#4417 state:resolved] | Aaron Patterson | 2010-04-16 | 2 | -2/+2 | |
| | | | | | | | | Signed-off-by: Xavier Noria <fxn@hashref.com> | |||||
* | | page_cache_extension is delegating to config so no need to deprecate | Santiago Pastorino | 2010-04-16 | 1 | -1/+0 | |
| | | ||||||
* | | Added test get to js should have a header with content-type text/javascript | Santiago Pastorino | 2010-04-16 | 1 | -1/+8 | |
| | | ||||||
* | | Tidy up a bit this test file | Santiago Pastorino | 2010-04-16 | 1 | -7/+2 | |
| | | ||||||
* | | Revert "Add test case which check content type when rendering rjs" partial ↵ | Santiago Pastorino | 2010-04-16 | 1 | -9/+1 | |
| | | | | | | | | | | | | in html template" rendering rjs in html doesn't make sense, it would just output javascript into the template, no script tag This reverts commit dc251389d1ab4303b80a22642f4241940b73cbe7. | |||||
* | | add missing requires to Rescuable and RouteSet [#4415 state:committed] | Mislav Marohnić | 2010-04-16 | 2 | -0/+2 | |
| | | | | | | | | Signed-off-by: Xavier Noria <fxn@hashref.com> | |||||
* | | Split the observer railtie into two phases. | Michael Koziarski | 2010-04-16 | 1 | -3/+7 | |
| | | | | | | | | Observers observing models with scopes defined will require the connection to be established. | |||||
* | | Make perform_caching work again, with the tests passing and backward compatible | Santiago Pastorino and Carl Lerche | 2010-04-15 | 6 | -26/+25 | |
| | | ||||||
* | | Revert "logger added to the deprecated config accessor" we need a major ↵ | Santiago Pastorino and Carl Lerche | 2010-04-15 | 1 | -1/+0 | |
| | | | | | | | | | | | | refactor to get this working This reverts commit 68f4e046a7f5db3f7c48a3721bead73a625b6f6e. | |||||
* | | Avoid deprecation warnings and potential TypeErrors [#4404 state:resolved] | Nicolas Sanguinetti | 2010-04-15 | 2 | -3/+3 | |
| | | | | | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | | logger added to the deprecated config accessor | Santiago Pastorino | 2010-04-14 | 1 | -0/+1 | |
| | | ||||||
* | | protected instance variables added to the deprecated config accessor | Santiago Pastorino | 2010-04-14 | 1 | -0/+1 | |
| | | ||||||
* | | asset and helper path added to the deprecated config accessor | Santiago Pastorino | 2010-04-14 | 1 | -0/+2 | |
| | | ||||||
* | | page_cache added to the deprecated config accessor | Santiago Pastorino | 2010-04-14 | 1 | -3/+6 | |
| | | ||||||
* | | Make use of config.perform_caching | Santiago Pastorino | 2010-04-14 | 3 | -7/+7 | |
| | | ||||||
* | | action_dispatch/routing/deprecated_mapper needs with_options | Matthew Rudy Jacobs | 2010-04-14 | 1 | -0/+1 | |
| | | | | | | | | | | | | [#4398 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | | utc_offset returns nil for unknown zones | Santiago Pastorino | 2010-04-14 | 2 | -3/+10 | |
| | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | | Test for unknown zone with nil utc_offset | Santiago Pastorino | 2010-04-14 | 1 | -0/+5 | |
| | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | | Merge branch 'master' of github.com:rails/rails | Jeremy Kemper | 2010-04-14 | 0 | -0/+0 | |
|\ \ | ||||||
| * \ | Merge branch 'master' of github.com:rails/rails | wycats | 2010-04-14 | 1 | -2/+2 | |
| |\ \ | ||||||
| * | | | Rely specifically on 0.6.0 and add a missing require | wycats | 2010-04-14 | 2 | -1/+2 | |
| | | | | ||||||
* | | | | Fix missing dependency on Hash#to_query | Santiago Pastorino | 2010-04-14 | 1 | -0/+1 | |
| |/ / |/| | | | | | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | | | Require rack-mount 0.6.0 since 0.6.1 and later can't be bundled | Jeremy Kemper | 2010-04-14 | 2 | -3/+3 | |
|/ / | ||||||
* | | i18n -> AS/i18n | Xavier Noria | 2010-04-14 | 1 | -1/+1 | |
| | | ||||||
* | | adds missing requires for arel and i18n, prevents Arel constant from being ↵ | Xavier Noria | 2010-04-14 | 1 | -1/+3 | |
|/ | | | | autoloaded (which was still seen), though it probably hides an issue related to dependencies | |||||
* | Merge commit 'docrails/master' | Xavier Noria | 2010-04-14 | 14 | -54/+56 | |
|\ | ||||||
| * | fixed typo in RUNNING_UNIT_TESTS | Diego Carrion | 2010-04-14 | 1 | -1/+1 | |
| | | ||||||
| * | Use <plain> instead of <text> | Ryan Bigg | 2010-04-14 | 1 | -6/+12 | |
| | | ||||||
| * | Changes in guide as per Rails 3 features | Anil Wadghule | 2010-04-13 | 1 | -15/+15 | |
| | | ||||||
| * | Updated guide to use 'Rails.root.join' to construct path | Anil Wadghule | 2010-04-13 | 1 | -4/+4 | |
| | | ||||||
| * | Replace 'RAILS_ROOT' to 'Rails.root' and 'RAILS_ENV' to 'Rails.env' in ↵ | Anil Wadghule | 2010-04-12 | 11 | -16/+16 | |
| | | | | | | | | significant places. | |||||
| * | low and behold => lo and behold! | Malcolm Locke | 2010-04-12 | 1 | -1/+1 | |
| | | ||||||
| * | Merge commit 'rohit/master' | Xavier Noria | 2010-04-11 | 0 | -0/+0 | |
| |\ | ||||||
| | * | Fixed indentation of database.yml examples. | Rohit Arondekar | 2010-04-10 | 1 | -13/+13 | |
| | | | ||||||
| * | | Fixed indentation of database.yml examples. | Rohit Arondekar | 2010-04-10 | 1 | -13/+13 | |
| |/ | ||||||
| * | Merge branch 'master' into docrails_master | wycats | 2010-04-10 | 111 | -1892/+1312 | |
| |\ | ||||||
| * | | release notes: updates instructions for installing the current beta | Xavier Noria | 2010-04-09 | 1 | -5/+1 | |
| | | | ||||||
| * | | Expansion on require method from runtime.rb | Ryan Bigg | 2010-04-09 | 1 | -1/+36 | |
| | | | ||||||
| * | | Continue expanding on Bundler. | Ryan Bigg | 2010-04-09 | 1 | -0/+19 | |
| | | | ||||||
| * | | Further work on the bundler section. Almost there now. | Ryan Bigg | 2010-04-09 | 1 | -6/+111 | |
| | | | ||||||
| * | | Mention a way to turn off bundler and begin talking about version_requirements | Ryan Bigg | 2010-04-09 | 1 | -0/+4 | |
| | | |