| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Any connections that were checked out during initialization should be
checked back in before the first request is processed, for two reasons:
- Returning the connection to the pool allows it to be health checked
before it's used again. If the connection dies before the first
request arrives, the health check will replace it with a new one.
- If the thread that initialized Rails is not the same thread that will
be performing work, checking in the connection will allow it to be
reused instead of being stuck to the initialization thread forever.
|
|\
| |
| | |
Change engines guide to demonstrate maintained forum
|
| |
| |
| |
| |
| |
| |
| | |
Change Rails engine guide to references a maintained project
Thredded instead of the abandoned project Forem. I chose
Thredded as Forem's closing note (below) suggests the choice.
https://github.com/rubysherpas/forem/blob/rails4/README.md
|
|\ \
| |/
|/| |
Remove `:doc:` for `NumericalityValidator` [ci skip]
|
|/
|
|
|
|
|
| |
The `:doc:` was added in cdb9d7f but `NumericalityValidator` is already
`:nodoc:` class. `:doc:` is unneeded.
https://github.com/rails/rails/blob/master/activemodel/lib/active_model/validations/numericality.rb#L3
|
|\
| |
| | |
Fix typo in I18n Guide [ci skip]
|
|/ |
|
|\
| |
| | |
Fix doc in Multibyte::Chars [ci skip]
|
|/ |
|
|\
| |
| | |
Change ActiveModel::Validation to ActiveModel::Validations in comments
|
|/ |
|
|\
| |
| | |
Remove redundant namespaces from sample code of `deprecated_method_wa…
|
| |
| |
| |
| | |
[ci skip]
|
|\ \
| | |
| | | |
Fix a tests of AR::ValueTooLong when using OracleAdapter
|
| | | |
|
|\ \ \
| |_|/
|/| | |
Indicate units of 'limit' in 'Integer' error message.
|
|/ / |
|
|\ \
| | |
| | |
| | |
| | | |
mtsmfm/fix-generator-command-for-nested-rails-engine-take-2
Fix generator command for nested (namespaced) rails engine (take 2)
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Rewrite https://github.com/rails/rails/pull/27550
085546df45 was reverted (b6ffb5efcb) because it change the return of `namespaced_path` from String to Array.
----------------
If we create nested (namespaced) rails engine such like bukkits-admin,
`bin/rails g scaffold User name:string age:integer`
will create
`bukkits-admin/app/controllers/bukkits/users_controller.rb`
but it should create
`bukkits-admin/app/controllers/bukkits/admin/users_controller.rb`.
In #6643, we changed `namespaced_path` as root path
because we supposed application_controller is always in root
but nested rails engine's application_controller will not.
|
|\ \ \
| | | |
| | | | |
Remove unused DdlHelper in ForeignKeyTest
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Use ActiveRecord `bigint` type, not SQL literal bigint
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Oracle database itself does not have `bigint` SQL type, then it gets `ORA-00902: invalid datatype`.
It can be addressed by using ActiveRecord `bigint` type
because Oracle enhanced adapter recognizes ActiveRecord `bigint` type
and transfer it to its equivalent SQL type `NUMBER(19)`.
|
|\ \ \
| | | |
| | | | |
Should keep the primary key column order
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
Fixes CI failure caused by #27961.
https://travis-ci.org/rails/rails/jobs/201472146#L2390-L2409
|
|\ \ \
| | | |
| | | | |
Not ants were harmed! 🐜 [ci skip]
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Simplify and optimize Postgres query for primary_keys()
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
primary_keys(table) needs to query various metadata tables in Postgres
to determine the primary key for the table. Previously, it did so using
a complex common table expression against pg_constraint and
pg_attribute.
This patch simplifies the query by using information_schema tables.
This simplifies the logic, making the query far easier to understand,
and additionally avoids an expensive unnest, window function query, and
common table expression.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
kenta-s/fix-return-value-of-deprecate_methods-in-doc
Fix the return of `deprecate_methods` in doc [ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Freeze fragment cache related instrument name.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
ActionMailer::Base#instrument_name and
ActionController::Base#instrument_name will be frequently called once
caching is enabled. So it's better to freeze them instead of create new
string on every call.
Also, the instrument name in #instrument_fragment_cache will usually
be "write_fragment.action_controller" or
"read_fragment.action_controller". So freezing them might also gain some
performance improvement. We have done something like this in other places:
https://github.com/rails/rails/blob/master/actionview/lib/action_view/template.rb#L348
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Add `default_index_type?` to the generic schema dumper doesn't have the knowledge about an index type
|
| | | | |
| | | | |
| | | | |
| | | | | |
knowledge about an index type
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Fix `remove_index` to be able to remove expression indexes
|
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes #26635, #26641.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Omit redundant `using: :btree` for schema dumping
|
|/ / / / / |
|
|\ \ \ \ \
| |_|_|_|/
|/| | | | |
Refactor `test_find_by_does_not_use_statement_cache_if_table_name_is_changed`
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Fix unscope with subquery
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Currently cannot unscope subquery properly.
This commit fixes the issue.
Fixes #26323.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
The `default` arg of `index_name_exists?` makes to optional
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The `default` arg of `index_name_exists?` is only used the adapter does
not implemented `indexes`. But currently all adapters implemented
`indexes` (See #26688). Therefore the `default` arg is never used.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Extract `quoted_binary` and use it rather than override `_quote`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Each databases have different binary representation. Therefore all
adapters overrides `_quote` for quoting binary.
Extract `quoted_binary` for quoting binary and use it rather than
override `_quote`.
|