aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove warningsCarlos Antonio da Silva2015-01-021-2/+2
| | | | | warning: ambiguous first argument; put parentheses or a space even after `/' operator'`
* Verify the helper name with plural as it is generatedCarlos Antonio da Silva2015-01-021-1/+1
| | | | Thanks @robin850.
* Add branch to gems pointing to github so that we can use local checkoutsCarlos Antonio da Silva2015-01-021-2/+2
|
* Merge pull request #18080 from korbin/fix_reaping_frequency_configurationRafael Mendonça França2015-01-023-2/+8
|\ | | | | | | Fix issue with reaping_frequency type.
| * fix issue with reaping_frequency typekorbin2014-12-172-2/+2
| | | | | | | | | | | | | | | | When using DATABASE_URL to configure ActiveRecord, :reaping_frequency does not get converted from a string to a numeric value. This value is eventually passed to 'sleep' and must be numeric to avoid exceptions. This commit converts :reaping_frequency to a float when present.
* | Do not check only for the Rails constantRafael Mendonça França2015-01-023-3/+3
| | | | | | | | | | This constant may be define for auxiliar gems like rails-html-sanitizer and these methods call will fail.
* | Do not run integration tests for the test adapterRafael Mendonça França2015-01-021-1/+1
| |
* | Merge pull request #18288 from claudiob/add-skip-action-mailerRafael Mendonça França2015-01-0110-4/+75
|\ \ | | | | | | Add --skip-action-mailer (or -M) to rails generate
| * | Add --skip-action-mailer (or -M) to rails generateclaudiob2015-01-0110-4/+75
|/ /
* | Fix scaffold generator with --helper=false optionRafael Mendonça França2015-01-012-0/+15
| |
* | Fix test description to match the test behaviourRafael Mendonça França2015-01-011-1/+1
| |
* | Remove conversion code for old Rails cache entryRafael Mendonça França2015-01-012-50/+0
| | | | | | | | | | | | | | | | | | This code was there just to convert entries generated in Rails 4.0.0.beta1 applications to a supported format. It is almost unlikely that any existent application have this cache entry format in their caches at the point that Rails 5 will be released so we don't need this code anymore.
* | Check by @v before converting the entry on expired?Rafael Mendonça França2015-01-012-2/+2
| | | | | | | | | | | | | | We should convert when @v is defined not @value. The test was calling value first that already converts the entry so we are not catching this bug.
* | Stop explicitly passing `nil` as the column to `type_cast`Sean Griffin2015-01-011-12/+12
| | | | | | | | So we can change the arity later.
* | Stop depending on columns for type information in PG quoting testsSean Griffin2015-01-012-30/+29
| | | | | | | | | | | | | | | | A few of the tests weren't testing anything of value. The IP Address tests are testing the type, not behavior of the connection adapter. There are two CVE regression tests which are important, but don't have a good place to go, so I've left them alone for now, as they call `quote` and the focus right now is removing `column` from `type_cast`
* | Stop relying on columns for type information in mysql2 casting testsSean Griffin2015-01-011-4/+2
| | | | | | | | | | | | The column itself has no actual impact on the return value. These were actually testing the behavior of the type object, which is sufficiently covered elsewhere.
* | Stop relying on columns in mysql quoting testsSean Griffin2015-01-011-6/+2
| | | | | | | | | | The behavior tested by the removed lines is sufficiently covered elsewhere.
* | Stop relying on columns in sqlite quoting testsSean Griffin2015-01-012-22/+7
| | | | | | | | | | | | The string encoding test wasn't using the types for anything. The boolean casting test included logic that should be in the tests for the types, and the string test was legitimately not testing anything useful.
* | 💣 I forgot to commit the arity changeSean Griffin2015-01-011-1/+1
| |
* | Don't rely on the column for type information in uniquness validationsSean Griffin2015-01-011-1/+2
| | | | | | | | The validator has access to richer type information
* | Don't load an entire table into memory to copy it on SQLiteSean Griffin2015-01-011-15/+4
| | | | | | | | SQL has mechanisms we can use to copy data from one table into another.
* | Stop using the column for type information in sanitizationSean Griffin2015-01-011-5/+4
| | | | | | | | | | | | As we move towards removing the types from the column objects, any remaining places which have access to richer type information should be using it.
* | Stop passing the column to the connection adapter when quoting defaultsSean Griffin2015-01-011-2/+2
| | | | | | | | | | The column is no longer used for anything besides type casting, which is what we're trying to remove from the column entirely.
* | Merge pull request #18271 from arunagw/change-copyright-yearRobin Dupret2015-01-0116-16/+16
|\ \ | | | | | | Update copyright notices to 2015 [ci skip]
| * | Update copyright notices to 2015 [ci skip]Arun Agrawal2014-12-3116-16/+16
| | |
* | | Merge pull request #18275 from robin850/head-statusCarlos Antonio da Silva2014-12-314-5/+23
|\ \ \ | | | | | | | | Correctly use the response's status code calling head
| * | | Correctly use the response's status code calling headRobin Dupret2014-12-314-5/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 20fece1 introduced the `_status_code` method to fix calls to `head :ok`. This method has been added on both ActionController::Metal and ActionDispatch::Response. As for the latter, this method is just equivalent to the `response_code` one so commit aefec3c removed it from the `Reponse` object so call to the `_status_code` method on an ActionController::Base instance would be handled by the `Metal` class (which `Base` inherits from) but the status code is not updated according to the response at this level. The fix is to actually rely on `response_code` for ActionController::Base instances but this method doesn't exist for bare Metal controllers so we need to define it.
* | | | Changelog edits [ci skip]Robin Dupret2014-12-313-20/+26
| | | |
* | | | Tiny follow-up to #18260 [ci skip]Robin Dupret2014-12-312-11/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Indent the list content by 4 spaces instead of 2 to match the other changelog files. Also wrap the lines around 80 chars. Finally update the documentation example with nit-picky things.
* | | | Merge pull request #18277 from prathamesh-sonpatki/typo-aj-changelogArun Agrawal2014-12-311-1/+1
|\ \ \ \ | | | | | | | | | | Fixed typo in ActiveJob CHANGELOG [ci skip]
| * | | | Fixed typo in ActiveJob CHANGELOG [ci skip]Prathamesh Sonpatki2014-12-311-1/+1
| | |/ / | |/| |
* | | | Merge pull request #18272 from kamipo/fix_warning_assigned_but_unused_variableSean Griffin2014-12-311-1/+1
|\ \ \ \ | | | | | | | | | | Fix warning: assigned but unused variable - post
| * | | | Fix warning: assigned but unused variable - postRyuta Kamizono2014-12-311-1/+1
| |/ / /
* | | | Merge pull request #18276 from y-yagi/fix_rake_commandRobin Dupret2014-12-311-1/+1
|\ \ \ \ | |_|/ / |/| | | fix rake command typo in Testing guide [ci skip]
| * | | fix rake command typo in Testing guide [ci skip]yuuji.yaginuma2014-12-311-1/+1
|/ / /
* | | Merge pull request #18274 from rajcybage/spell_fixRobin Dupret2014-12-312-4/+4
|\ \ \ | | | | | | | | Fix spell life cycle on activejob docs [ci skip]
| * | | Fix spell life cycle on activejob docs [ ci skip]Rajarshi Das2014-12-312-4/+4
| | | |
* | | | Merge pull request #18269 from cuppincake/getting-started-migration-updateYves Senn2014-12-311-0/+3
|\ \ \ \ | |_|/ / |/| | | Update Getting Started guide to reflect foreign key in migration [ci skip]
| * | | Update Getting Started guide to reflect foreign key in migration [ci skip]Jennifer Wollesen2014-12-301-0/+3
| | | |
* | | | Merge pull request #18270 from prathamesh-sonpatki/activejobs-is-not-actionjobCristian Bica2014-12-311-1/+1
|\ \ \ \ | |/ / / |/| | | ActiveJob is not ActionJob [ci skip] :smile:
| * | | ActiveJob is not ActionJob [ci skip] :smile:Prathamesh Sonpatki2014-12-311-1/+1
|/ / /
* | | Add Profiling guide skeleton [ci skip]Zachary Scott2014-12-302-0/+22
| | |
* | | Extract the index length validation to a auxiliar methodRafael Mendonça França2014-12-303-9/+12
| | |
* | | Merge pull request #18264 from yahonda/rename_index_mysqlRafael Mendonça França2014-12-301-0/+3
|\ \ \ | | | | | | | | Raise a better exception for renaming long indexes for mysql adapters
| * | | Raise a better exception for renaming long indexes for mysql adaptersYasuo Honda2014-12-301-0/+3
| | | |
* | | | Merge pull request #18266 from cristianbica/ajfixesRafael Mendonça França2014-12-306-12/+21
|\ \ \ \ | | | | | | | | | | ActiveJob testing improvements
| * | | | ActiveJob testing improvementsCristian Bica2014-12-306-12/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1. The :test adapter wasn't going through a full cycle of serialize/deserialize when performing jobs. Now it does 2. Regular AJ tests were not run for the :test adapter. Now they are 3. ActiveJob::TestHelper uses assert_valid_keys but doesn’t requires the file that implements that method. Now it does
* | | | | Fix error message when trying to create an associated recordRafael Mendonça França2014-12-304-1/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This error only happens when the foreign key is missing. Before this fix the following exception was being raised: NoMethodError: undefined method `val' for #<Arel::Nodes::BindParam:0x007fc64d19c218> Now the message is: ActiveRecord::UnknownAttributeError: unknown attribute 'foreign_key' for Model.
* | | | | Merge pull request #18260 from isaacseymour/active-job-delegate-deserializeDavid Heinemeier Hansson2014-12-302-4/+53
|\ \ \ \ \ | | | | | | | | | | | | ActiveJob: delegate deserialization to the job class
| * | | | | ActiveJob: delegate full deserialization to classIsaac Seymour2014-12-302-4/+53
| | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-17 04:58:21 +0000