| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
any? should be delegated to the errors list
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Otherwise we get deprecation warnings in the generated scaffold template files
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Revert changes to monotonic times
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The change to monotonic times causes failures for applications
where the subscribed block is expecting Time objects as described
in this issue: https://github.com/rails/rails/issues/36145
The original PR (https://github.com/rails/rails/pull/35984) was
concerned with errors on the cpu_time. Test was edited to reflect
changes to initializer using 0 values instead of nil
|
|\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | |
| | | | | |
| | | | | | |
[Guides] Remove dynamic_form gem reference in guides
[ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
This gem has not been updated since April 2014 and 2 of the 4 methods it introduces have been broken since Rails 4
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Should take the record's state of first action in the transaction
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
If the same id's records are saved and/or destroyed in the transaction,
commit callbackes will only run for the first enrolled record.
https://github.com/rails/rails/blob/a023e2180093ebc517a642aaf21f3c7241c67657/activerecord/lib/active_record/connection_adapters/abstract/transaction.rb#L115-L119
The regression #36132 is caused due to #35920 changed the enrollment
order that the first action's record will be enrolled to last in the
transaction.
We could not change the the enrollment order as long as someone depends
on the enrollment order.
Fixes #36132.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Action Mailer release notes [ci skip]
|
| | | | | |
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] Add 6.0 Release Notes for Action View
|
| | | | |
| | | | |
| | | | |
| | | | | |
I've added release notes based off of the CHANGELOG for Action View.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix incorrect url in guide [ci skip]
|
|/ / / / /
| | | | |
| | | | | |
The example functional test lists the 'create' route as article_url rather than articles_url
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Improve error message of ActiveSupport delegate
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
ActiveSupport `delegate` has `to` option, but it's not a option hash
anymore and now it's a keyword argument.
When `to` argument is not given, it raises an ArgumentError but
the message suggests supplying "options hash", which is now wrong.
Now it's fixed to provide correct suggestion to supply a keyword
argument.
|
| | | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] Update the guide's model generator output.
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The model generator code sample used in the command line guides
was displaying an outdated output for the generator's usage.
This change updates the sample to mirror what's currently output
when running `$rails generate model`.
|
|\ \ \ \
| | | | |
| | | | | |
Fix merging left_joins to maintain its own `join_type` context
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This fixes a regression for #35864.
Usually, stashed joins (mainly eager loading) are performed as LEFT
JOINs.
But the case of merging joins/left_joins of different class, that
(stashed) joins are performed as the same `join_type` as the parent
context for now.
Since #35864, both (joins/left_joins) stashed joins might be contained
in `joins_values`, so each stashed joins should maintain its own
`join_type` context.
Fixes #36103.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Fallback to spawn instead of fork in jruby
This commit: b342db6 introduced a `fork` fork when running the railties
tests since this is not supported in jruby we fallback to using spawn.
Fixes: https://github.com/rails/rails/issues/35900
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* Add test asserting truncate returns unfrozen string
* Ensure strings returned from truncate are not frozen
This fixes an issue where strings too short to be truncated were
returned unfrozen, where as long-enough strings were returned
frozen. Now retuned strings will not be frozen whether or not
the string returned was shortened.
* Update changelog w/ new truncate behavior description
[Jordan Thomas + Rafael Mendonça França]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add 6.0 Release Notes for Action Pack
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
I've gone through the CHANGELOG for Action Pack, pulled out anything
that was backported, rephrased some of the descriptions and found their
PR's/commits as links.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
See 19770d6.
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Bump bootsnap to a version with disables iseq_cache for Ruby 2.5
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- Refs https://github.com/Shopify/bootsnap/pull/257
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Fixes grammar in comments on tag_name and tag_id
|
| |/ / / / |
|
| | | | | |
|
| | | | | |
|
|/ / / / |
|
| | | |
| | | |
| | | |
| | | | |
Bump gem version to 6.0.0.rc1.
|
|\ \ \ \
| | | | |
| | | | | |
Fix outdated yarn.lock
|
|/ / / / |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
instead of 6.0 (#36087)
* Change the deprecation for Enumerating ActiveModel::Errors to Rails 6.1 instead of 6.0
* Changed the deprecation message for ActiveModel::Errors methods: slice, values, keys and to_xml
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
abhaynikam/35869-add-documentation-for-has-one-option
Adds documentation for has_one touch option after #35869 [ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Model error as object
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
maintaining behavior errors.details[:foo].any?
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|