aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #15917 from luke-gru/actionview_perfRafael Mendonça França2014-07-161-1/+1
|\ | | | | | | remove Set.new from DetailsKey::get, impacts rendering overhead
| * remove Set.new from DetailsKey::get, impacts rendering overhead performanceLuke Gruber2014-06-251-1/+1
| | | | | | | | | | | | | | | | | | Using ruby-prof, I noticed that Set#add had the largest 'self time' percentage (5% of the overall time spent rendering) when benchmarking the rendering of a small cached ERB template that was 3 lines long. It turns out it was from this line. I don't believe the Set is necessary, either. Removing this line increases the rendering ips using Benchmark::ips accordingly.
* | Merge pull request #15944 from seuros/uuidRafael Mendonça França2014-07-163-1/+51
|\ \ | | | | | | | | | | | | | | | | | | Treat invalid uuid as nil Conflicts: activerecord/CHANGELOG.md
| * | Treat invalid uuid as nilAbdelkader Boudih2014-07-143-1/+51
| | |
* | | Merge pull request #16183 from goddamnhippie/fix-psych-warningRafael Mendonça França2014-07-162-0/+6
|\ \ \ | | | | | | | | Implement required #encode_with
| * | | Move #encode_with to RelationGustavo Beathyate2014-07-152-4/+5
| | | |
| * | | Implement required #encode_withGustavo Beathyate2014-07-152-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | While running the spec `ARCONN=mysql2 ruby -v -Itest test/cases/yaml_serialization_test.rb` the following warning shows up: `implementing to_yaml is deprecated, please implement "encode_with"`
* | | | always transcode the file to utf-8Aaron Patterson2014-07-162-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | people may be passing filenames to the constructor that are not utf-8, but they will assome that calling `original_filename` returns utf-8 (because that's what it used to do).
* | | | Merge pull request #15718 from chancancode/regression_from_15694Godfrey Chan2014-07-162-1/+10
|\ \ \ \ | | | | | | | | | | Fixed a regression introduced in 84cf156
| * | | | Fixed a regression introduced in 84cf156Godfrey Chan2014-06-142-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 84cf156 (PR #15694) introduced a subtle regression. There are actually three distinct entry points to creating an AR object – via .new (i.e. #initialize), via #init_with (e.g. from YAML or database queries) and via .allocate. With the patch in 84cf156, attribute methods and respond_to? will not work correctly when objects are allocated directly, without going through either The reason this test case didn't catch the regression was that the `Topic` class is shared between test cases, so by the time this test case is ran the attribute methods are very likely to be defined. Switching to use a fresh anonymous class in the test to ensure we surface this problem in the future.
* | | | | Fix typo on the variable nameRafael Mendonça França2014-07-161-8/+8
| | | | |
* | | | | Merge branch 'joeljunstrom-local-iterator-for-partial-collections'Rafael Mendonça França2014-07-167-18/+125
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Squash and merge #7698 doing some improvements to the original implementation.
| * | | | | Add CHANGELOG entry for PartialIteration.Rafael Mendonça França2014-07-161-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | Closes #7698.
| * | | | | Document the PartialIteration objectRafael Mendonça França2014-07-161-3/+9
| | | | | |
| * | | | | Build only one PartialIteration object for loopRafael Mendonça França2014-07-162-16/+26
| | | | | |
| * | | | | No need to have a file to PartialIteration classRafael Mendonça França2014-07-163-23/+19
| | | | | | | | | | | | | | | | | | | | | | | | This class is only used on the PartialRenderer.
| * | | | | Added PartialIteration class used when rendering collectionsJoel Junström2014-07-167-14/+99
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The iteration object is available as the local variable "template_name_iteration" when rendering partials with collections. It gives access to the +size+ of the collection beeing iterated over, the current +index+ and two convinicence methods +first?+ and +last?+ "template_name_counter" variable is kept but is deprecated. [Joel Junström + Lucas Uyezu]
* | | | | Remove unused fixturesRafael Mendonça França2014-07-1660-98/+0
| | | | | | | | | | | | | | | | | | | | These fixtures are not used in actionpack tests.
* | | | | nodoc enum hooks [ci skip]Rafael Mendonça França2014-07-161-2/+2
| | | | |
* | | | | Don't accept parameters as argument for redirect to [via @homakov]Santiago Pastorino2014-07-162-0/+11
| | | | | | | | | | | | | | | | | | | | Closes #16170
* | | | | we intend to keep the `capture` helper for Active Record tests.Yves Senn2014-07-161-18/+12
| | | | | | | | | | | | | | | | | | | | This is a follow up to f8f5cdc
* | | | | Active Record tests still depend on `capture`. Let's keep it for now.Yves Senn2014-07-162-19/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow-up to 3121412 /cc @rafaelfranca This will remove deprecation warnings from the PostgreSQL suite: ``` DEPRECATION WARNING: #capture(stream) is deprecated and will be removed in the next release. (called from capture at /Users/senny/Projects/rails/activesupport/lib/active_support/core_ext/kernel/reporting.rb:89) /Users/senny/Projects/rails/activesupport/lib/active_support/core_ext/kernel/reporting.rb:89:in `capture' /Users/senny/Projects/rails/activerecord/test/cases/adapters/postgresql/composite_test.rb:73:in `ensure_warning_is_issued' /Users/senny/Projects/rails/activerecord/test/cases/adapters/postgresql/composite_test.rb:48:in `test_column' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest/test.rb:106:in `block (3 levels) in run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest/test.rb:204:in `capture_exceptions' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest/test.rb:103:in `block (2 levels) in run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest/test.rb:256:in `time_it' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest/test.rb:102:in `block in run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:317:in `on_signal' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest/test.rb:276:in `with_info_handler' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest/test.rb:101:in `run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:759:in `run_one_method' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:293:in `run_one_method' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:287:in `block (2 levels) in run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:286:in `each' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:286:in `block in run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:317:in `on_signal' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:306:in `with_info_handler' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:285:in `run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:149:in `block in __run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:149:in `map' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:149:in `__run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:126:in `run' /Users/senny/Projects/rails/.bundle/gems/minitest-5.3.3/lib/minitest.rb:55:in `block in autorun' ```
* | | | | Merge pull request #16187 from jone/testing-guide-assertionsYves Senn2014-07-161-2/+13
|\ \ \ \ \ | | | | | | | | | | | | Update assertion methods in testing guide [ci skip]
| * | | | | link minitest assertions documentation.Jonas Baumann2014-07-161-2/+7
| | | | | |
| * | | | | document assert[_not]_empty, assert[_not]_includes, assert[_not]_predicate ↵Jonas Baumann2014-07-161-0/+6
|/ / / / / | | | | | | | | | | | | | | | in testing guide.
* | | | | use foreign key DSL in our tests.Yves Senn2014-07-162-5/+4
| | | | |
* | | | | Merge pull request #16138 from sgrif/sg-attribute-set-keyYves Senn2014-07-163-10/+10
|\ \ \ \ \ | | | | | | | | | | | | AttributeSet#include? -> AttributeSet#key?
| * | | | | AttributeSet#include? -> AttributeSet#key?Sean Griffin2014-07-113-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | https://github.com/rails/rails/pull/15868/files#r14135210
* | | | | | Fix 1.9. uggghhhhhh get it together @tenderlove :bomb:Aaron Patterson2014-07-151-2/+2
| | | | | |
* | | | | | fix for 1.9 kwargs syntaxAaron Patterson2014-07-151-1/+2
| | | | | |
* | | | | | routed applications will respond to these methodsAaron Patterson2014-07-152-2/+2
| | | | | |
* | | | | | Merge branch 'rm-uuid'Rafael Mendonça França2014-07-156-78/+78
|\ \ \ \ \ \
| * | | | | | Move uuid_v5 and uuid_v3 to Digest::UUIDRafael Mendonça França2014-07-156-78/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These methods are not random so they should not belings to SecureRandom module.
* | | | | | | stop passing recall to url_forAaron Patterson2014-07-152-37/+48
| | | | | | |
* | | | | | | rack 1.6 encodes the filenames in posts correctly nowAaron Patterson2014-07-151-8/+1
| | | | | | |
* | | | | | | fix warningsAaron Patterson2014-07-151-1/+1
| | | | | | |
* | | | | | | stop calling url_for with recall parameters and actually use a requestAaron Patterson2014-07-152-85/+197
|/ / / / / /
* | | | | | execute a request and check the path_parametersAaron Patterson2014-07-151-17/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This actually runs a request through the system, using the actual routing methods as we would use in production, then tests the path_parameters set on the request object. The `recognize_path` method isn't actually used in production, so testing what it returns isn't useful.
* | | | | | set `set` in the setup methodAaron Patterson2014-07-151-2/+5
| | | | | |
* | | | | | remove useless ivar setAaron Patterson2014-07-151-1/+0
| | | | | |
* | | | | | RouteSet should be in charge of constructing the dispatherAaron Patterson2014-07-153-10/+15
| | | | | | | | | | | | | | | | | | | | | | | | Now we can override how requests are dispatched in the routeset object
* | | | | | Merge pull request #16180 from rafaelfranca/rm-dirtyRafael Mendonça França2014-07-156-18/+79
|\ \ \ \ \ \ | | | | | | | | | | | | | | Improve Active Model Dirty API.
| * | | | | | Deprecate `reset_#{attribute}` in favor of `restore_#{attribute}`.Rafael Mendonça França2014-07-155-13/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These methods may cause confusion with the `reset_changes` that behaves differently of them. Also rename undo_changes to restore_changes to match this new set of methods.
| * | | | | | Deprecate ActiveModel::Dirty#reset_changes in favor of ↵Rafael Mendonça França2014-07-154-6/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #clear_changes_information This method name is causing confusion with the `reset_#{attribute}` methods. While `reset_name` set the value of the name attribute for the previous value the `reset_changes` only discard the changes and previous changes.
* | | | | | | Add CHANGELOG entry for #13392 [ci skip]Rafael Mendonça França2014-07-151-0/+7
| | | | | | |
* | | | | | | Keep quietly and capture undeprecated on your suiteRafael Mendonça França2014-07-1510-21/+140
| | | | | | |
* | | | | | | Deprecate reporting methods for silencing output as they aren't thread safeTom Meier2014-07-151-0/+10
| | | | | | |
* | | | | | | Merge pull request #16129 from rafaelfranca/config_forRafael Mendonça França2014-07-153-0/+134
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Add Rails::Application#config_for
| * | | | | | | Add Rails::Application#config_forRafael Mendonça França2014-07-153-0/+134
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a convenience for loading configuration for the current Rails environment.
* | | | | | | Merge branch 'master' of git://github.com/rails/railsGodfrey Chan2014-07-154-6/+24
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activerecord/CHANGELOG.md
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-04 13:03:37 +0000