aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* [ci skip] Update all guides with `null: false` change in migrationsPrathamesh Sonpatki2016-03-033-23/+23
| | | | | | | - We no longer add `null: false` for timestamps columns as per rails/rails@a939506. - Followup of https://github.com/rails/docrails/commit/14867b1a9af813b0147bba2ae06675137d61d77b.
* [ci skip] Update getting started guide for chanages in migrations APIPrathamesh Sonpatki2016-03-031-3/+3
| | | | | | | | - We no longer add `null: false` for timestamps columns as per https://github.com/rails/rails/commit/a939506f297b667291480f26fa32a373a18ae06a. - Similarly `references` and `belongs_to` columns no longer mention `index: true` in migration files. It's added by default as per https://github.com/rails/rails/commit/909818b93b8f1bd4d7053a1c5d8135b9b0cbe865.
* [ci skip] fix json outputMikhail Dieterle2016-02-271-1/+1
|
* [ci skip] Remove reference to Rails 4 in the initialization guide.Prathamesh Sonpatki2016-02-262-3/+3
|
* [ci skip] Fix `'id'` to be fixed-width fontyui-knk2016-02-231-1/+1
| | | | | | | | | | | | As shown below, we should use <tt>...</tt> for string literal ``` $ echo "+'id'+" | rdoc --pipe <p>+&#39;id&#39;+</p> $ echo "<tt>'id'</tt>" | rdoc --pipe <p><code>&#39;id&#39;</code></p> ```
* [ci skip] fix typosMikhail Dieterle2016-02-141-3/+3
|
* [ci skip] Update 'Testing Active Record'yui-knk2016-02-141-1/+1
| | | | | | | | | Follow up 8c629bf463b47643712570d4511a68b9a3da1476. `bundle exec rake test` in 'activerecord' runs tests for * sqlite3 * mysql2 * postgresql
* Merge branch 'master' of github.com:rails/docrailsVijay Dev2016-02-074-15/+16
|\
| * fix indentationVijay Dev2016-02-071-1/+1
| |
| * [ci skip] Good bye SQLite2yui-knk2016-02-061-2/+0
| | | | | | | | Follow up of https://github.com/rails/rails/commit/c9feea6c9ab4494b0cb0b8cf4316847854f65af6
| * [ci skip] fix typoMikhail Dieterle2016-01-301-1/+1
| |
| * [ci skip] Fix one more typoPrathamesh Sonpatki2016-01-301-1/+1
| | | | | | | | - Followup of https://github.com/rails/docrails/commit/10bc49710b7205a6172c3e072b3c77114fefd952
| * [ci skip] Update internal documents about ActiveRecord's Reflectionyui-knk2016-01-301-11/+14
| | | | | | | | | | | | | | ActiveRecord's Reflection was refactored by f8d2899d12d59360f29c5eb6a1b1a8fe4ec82ca0 . Top of ancestors chain was changed to `AbstractReflection` from `MacroReflection`, and new Reflections were added.
| * [ci skip] Fix typoyui-knk2016-01-271-1/+1
| |
* | Merge pull request #23533 from y-yagi/fix_typo_in_assert_enqueued_jobs_exampleJon Moss2016-02-061-1/+1
|\ \ | | | | | | fix typo in `assert_enqueued_jobs` example [ci skip]
| * | fix typo in `assert_enqueued_jobs` example [ci skip]yuuji.yaginuma2016-02-071-1/+1
| | |
* | | Merge pull request #23519 from kamipo/mariadb_does_not_support_json_typeSean Griffin2016-02-061-1/+1
|\ \ \ | | | | | | | | MariaDB does not support JSON type
| * | | MariaDB does not support JSON typeRyuta Kamizono2016-02-061-1/+1
| | | | | | | | | | | | | | | | Fixes #22980.
* | | | Avoid coupling Action Pack to Railties.Kasper Timm Hansen2016-02-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Referencing Rails.env without checking if it's defined couples us to Railties. Fix by avoiding the line breaks if we don't have an env check to rely on.
* | | | Merge pull request #23529 from syamilmj/remove_unused_methodRafael França2016-02-061-4/+0
|\ \ \ \ | | | | | | | | | | Remove unused private method
| * | | | Remove unused private methodSyamil MJ2016-02-071-4/+0
|/ / / /
* | | | Merge pull request #23520 from kamipo/remove_duplicated_require_arelSean Griffin2016-02-061-1/+0
|\ \ \ \ | |/ / / |/| | | Remove duplicated `require 'arel'`
| * | | Remove duplicated `require 'arel'`Ryuta Kamizono2016-02-061-1/+0
| |/ / | | | | | | | | | It appears first in `lib/active_record.rb`.
* | | Merge pull request #23517 from gsamokovarov/yay-youre-on-railsEileen M. Uchitelle2016-02-062-2/+2
|\ \ \ | |/ / |/| | Replace old Rails greeting references
| * | Replace old Rails greeting referencesGenadi Samokovarov2016-02-062-2/+2
| | | | | | | | | | | | | | | | | | | | | A couple of the READMEs were still referring the old welcome page. This is a small change that goes over it. [ci skip]
* | | Merge pull request #23513 from kamipo/revert-23502-update-travis-masterKasper Timm Hansen2016-02-061-2/+2
|\ \ \ | | | | | | | | Revert "No need to specify Ruby patch version on Travis CI"
| * | | Revert "No need to specify Ruby patch version on Travis CI"Ryuta Kamizono2016-02-061-2/+2
| | | |
* | | | Merge pull request #23514 from y-yagi/revert_mailer_doc_fixKasper Timm Hansen2016-02-062-2/+2
|\ \ \ \ | |_|/ / |/| | | Revert "When generating a mailer, you must specify Mailer in the class name in"
| * | | Revert "When generating a mailer, you must specify Mailer in the class name in"yuuji.yaginuma2016-02-062-2/+2
|/ / / | | | | | | | | | | | | | | | | | | | | | This reverts commit 8417d967e016f0219cc4ec30bf0d3908ce6cd29b. In 5697bdbb6da5d08e541a3b12251cec90269b059b and af3eb5961e55a46b011be797e71f615f20f56686, add mailer suffix to generated files and classes. Therefore, no longer need to specify `Mailer` to class name. [ci skip]
* | | add missing requireAaron Patterson2016-02-051-0/+1
| | |
* | | Fix mixing line filters with Minitest's -n filter.Kasper Timm Hansen2016-02-052-4/+36
|/ / | | | | | | | | | | | | | | | | | | | | Previous commit accidentally broke mixing line filters with string -n filter. Fix by checking if it is a string and returning it. We also need to ensure the -n filter carry forward into any other composite filters. Fix by letting the named filter be extractable, so we'll keep this for the next runnable's run.
* | Revert "Dump indexes in `create_table` instead of `add_index`"Sean Griffin2016-02-053-21/+16
| | | | | | | | | | | | | | | | | | | | This reverts commit 99801c6a7b69eb4b006a55de17ada78f3a0fa4c1. Ultimately it doesn't matter whether `add_index` or `t.index` are used in the schema dumper in any meaningful way. There are gems out there which hook into the old behavior for things like indexing materialized views. Since the reverted commit doesn't seem to add much benefit, there's no reason for us to break these gems.
* | Merge pull request #23502 from sikachu/update-travis-masterRafael França2016-02-051-2/+2
|\ \ | | | | | | No need to specify Ruby patch version on Travis CI
| * | No need to specify Ruby patch version on Travis CIPrem Sichanugrist2016-02-051-2/+2
|/ / | | | | | | | | Travis CI now select the latest patch version of Ruby automatically when given MAJOR.MINOR version string.
* | disable controller / view thread spawning in testsAaron Patterson2016-02-053-3/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Tests can (and do) access the database from the main thread. In this case they were starting a transaction, then making a request. The request would create a new thread, which would allocate a new database connection. Since the main thread started a transaction that contains data that the new thread wants to see, the new thread would not see it due to data visibility from transactions. Spawning the new thread in production is fine because middleware should not be doing database manipulation similar to the test harness. Before 603fe20c it was possible to set the database connection id based on a thread local, but 603fe20c changes the connection lookup code to never look at the "connection id" but only at the thread object itself. Without that indirection, we can't force threads to use the same connection pool as another thread. Fixes #23483
* | Merge pull request #23500 from akaspick/mailer_doc_fixRafael França2016-02-052-2/+2
|\ \ | | | | | | When generating a mailer, you must specify Mailer in the class name
| * | When generating a mailer, you must specify Mailer in the class name inAndrew Kaspick2016-02-052-2/+2
|/ / | | | | | | | | order to generate the proper files. Some of the docs/comments are missing this important detail.
* | Missed a few spots in inline -> async switchDavid Heinemeier Hansson2016-02-053-8/+3
| |
* | Change the default adapter from inline to asyncDavid Heinemeier Hansson2016-02-053-7/+16
| |
* | Cant run on an out-of-the-box OSX installation without running out of TOO ↵David Heinemeier Hansson2016-02-051-1/+1
| | | | | | | | MANY FILES OPEN
* | Merge pull request #23494 from prathamesh-sonpatki/update-turbolinksRafael França2016-02-052-4/+9
|\ \ | | | | | | Update turbolinks-rails for passing railties test
| * | Update turbolinks-rails for passing railties testPrathamesh Sonpatki2016-02-052-4/+9
| | | | | | | | | | | | Ref - https://github.com/turbolinks/turbolinks-rails/pull/3
* | | Merge pull request #23496 from ↵प्रथमेश Sonpatki2016-02-051-1/+1
|\ \ \ | |/ / |/| | | | | | | | y-yagi/donot_explicitly_mention_eventmachine_in_template don’t explicitly mention EventMachine [ci skip]
| * | don’t explicitly mention EventMachine [ci skip]yuuji.yaginuma2016-02-051-1/+1
|/ / | | | | | | Follow up to 6accef4e11b0c793e1c085536b5ed27f32b6a0c3
* | Merge branch 'master' of github.com:rails/railsZachary Scott2016-02-051-2/+2
|\ \
| * \ Merge pull request #23491 from y-yagi/move_changelog_entry_2Kasper Timm Hansen2016-02-051-2/+2
| |\ \ | | | | | | | | move CHANGELOG entry to the appropriate position [ci skip]
| | * | move CHANGELOG entry to the appropriate position [ci skip]yuuji.yaginuma2016-02-051-2/+2
| | | | | | | | | | | | | | | | | | | | Dummy apple icon files has been added after the 5.0.0.beta2 release. ref: #23455
* | | | Check off some todos for the Testing guide with @senny [ci skip]Zachary Scott2016-02-051-17/+26
|/ / /
* | | docs, remove trailing whitespace from testing guide. [ci skip]Yves Senn2016-02-051-9/+9
| | |
* | | docs, link Rails specific assertions to the API. [ci skip]Yves Senn2016-02-051-6/+6
| | |