| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | | | | |
| | | | |
| | | | |
| | | | | |
consistency.
|
| | | | | |
| | | | |
| | | | |
| | | | | |
consistency.
|
| | | | | | |
|
| |\| | | |
| | | | |
| | | | | |
add :nodoc: to internal implementations [ci skip]
|
| |/ / / / |
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
These _define class methods don't need to be exposed to objects that
extend ActiveModel::Callbacks.
Also use merge! options to avoid the creation of an extra hash.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit needs to be reverted because it introduces difficulties when
using sqlite3 in development and other databases in production. This
happens because when you create time column in sqlite3, it's dumped as
datetime in schema.rb file.
This reverts commit 57d534ee9e441d078fcc161c0c78ebaa5aacd736, reversing
changes made to 20f049fb50daee0c5e5a69b55b529af5737e8e3f.
Conflicts:
activerecord/test/cases/adapters/sqlite3/sqlite3_adapter_test.rb
|
| |\ \ \
| | | |
| | | |
| | | | |
Refactor and improve a bit number helpers code.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
Use a different and very specific locale for testing currency negative
format, and an empty store for currency defaults.
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
They also make more sense here since all the related logic with I18n is
handled by AS::NumberHelper, and not by AV anymore.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Just make use of the returning exception from assert_raise, instead of
calling the method again with a rescue clause to test the saved
exception number.
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
ActiveSupport::NumberHelper does not make use of :raise, so there's no
need to propagate it down.
|
| |/ / / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Correct line numbers for reader and writer methods in AS configurable
The line number for the reader method is off by one due to the local variable line being reassigned to the writer's line.
This commit would provide correct line numbers for backtraces and method introspection (for example, method(:reader).source_location).
|
| |/ / / |
|
| |\ \ \
| | | |
| | | | |
Stop assuming strings for grouped calculations
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Execute_grouped_calculation is one of those places where
ActiveRecord forgets that it has ARel underpinnings, and
assumes that the values provided to group_values are
strings. This artificially hobbles otherwise functional
code. This patch stops assuming that incoming values
respond to to_sym, stops using string interpolation for
table aliases on objects that support aliasing, and stops
unnecessarily joining group_values on the relation.
Additionally, it calls to_sql, if available, on objects
sent to column_alias_for, in order to get a more reasonable
alias string than a non-string's default to_str method.
|
| |\ \ \
| | | |
| | | | |
Don't paramify ActionDispatch::Http::UploadedFile in tests
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
To test uploading a file without using fixture_file_upload, a posted
ActionDispatch::Http::UploadedFile should not be paramified (just like
Rack::Test::UploadedFile).
(Rack::Test::UploadedFile and ActionDispatch::Http::UploadedFile don't
share the same API, tempfile is not accessible on
Rack::Test::UploadedFile as discussed in
https://github.com/brynary/rack-test/issues/30)
|
| |\ \ \ \
| | | | |
| | | | | |
Move Active Record rake tasks tests to under the tasks dir [ci skip]
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | | |
Ruby 1.9 hash syntax for generated code
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
app/controllers/application_controller.rb
app/views/layouts/application.html.erb
config/application.rb
config/routes.rb
test/performance/browsing_test.rb
|
| | | | | | |
|
| |/ / / / |
|
| | | | | |
|
| | |/ /
|/| | |
|
| |\ \ \
| | | |
| | | | |
add :nodoc: to internal implementations [ci skip]
|
| |/ / / |
|
| |\ \ \
| | | |
| | | | |
Allow precision option for postgresql datetimes
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This patch addresses the difficulty of retrieving datetime fields. By default, the database holds a higher precision than the time as a String.
This issue is discussed at length at the following links:
- [#3519](https://github.com/rails/rails/issues/3519)
- [#3520](https://github.com/rails/rails/issues/3520)
Also, kudos to @mattscilipoti
|
| |\ \ \
| |_|/
|/| | |
change param name to improve documentation
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The keys of the error messages are actually attribute names. It makes
the documentation easier to understand:
# Returns +true+ if the error messages include an error for the given
# +attribute+, +false+ otherwise.
#
# person.errors.messages # => { :name => ["can not be nil"] }
# person.errors.include?(:name) # => true
# person.errors.include?(:age) # => false
def include?(attribute)
(v = messages[attribute]) && v.any?
end
|
| |\ \ |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
skip]
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
