Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | fix variable names and speed up relation ordering | Aaron Patterson | 2013-09-23 | 2 | -16/+12 |
| | |||||
* | hm:t preloading will respect order set on the RHS association | Aaron Patterson | 2013-09-23 | 6 | -8/+68 |
| | |||||
* | cache associated target records hash | Aaron Patterson | 2013-09-20 | 1 | -17/+11 |
| | |||||
* | combine methods so we can reuse preloaders | Aaron Patterson | 2013-09-20 | 1 | -19/+18 |
| | |||||
* | return a list rather than hash | Aaron Patterson | 2013-09-20 | 1 | -7/+13 |
| | |||||
* | preserve order on the RHS query | Aaron Patterson | 2013-09-20 | 1 | -0/+8 |
| | |||||
* | split up construction and mutation | Aaron Patterson | 2013-09-20 | 1 | -1/+4 |
| | |||||
* | fix method name | Aaron Patterson | 2013-09-20 | 1 | -3/+5 |
| | |||||
* | access preloaders independently of model mutations | Aaron Patterson | 2013-09-20 | 1 | -12/+12 |
| | |||||
* | push running the preloaders up | Aaron Patterson | 2013-09-20 | 1 | -19/+7 |
| | |||||
* | push `run` up to preload | Aaron Patterson | 2013-09-20 | 3 | -14/+41 |
| | |||||
* | the hash should only ever be length one, so decompose it | Aaron Patterson | 2013-09-20 | 1 | -4/+5 |
| | |||||
* | stop depending on preloader interals so we can create fewer preloader | Aaron Patterson | 2013-09-20 | 1 | -19/+23 |
| | | | | objects | ||||
* | lhs preload is always a single preload, so just preload one | Aaron Patterson | 2013-09-20 | 1 | -3/+3 |
| | |||||
* | just read the attribute rather than `send`ing | Aaron Patterson | 2013-09-20 | 1 | -1/+1 |
| | |||||
* | extract exception raising, clean up group_by statement | Aaron Patterson | 2013-09-20 | 1 | -6/+7 |
| | |||||
* | generate fewer objects when grouping | Aaron Patterson | 2013-09-20 | 1 | -5/+7 |
| | |||||
* | do not access internal data structures | Aaron Patterson | 2013-09-20 | 1 | -1/+1 |
| | |||||
* | exposing target records on the preloader | Aaron Patterson | 2013-09-20 | 2 | -16/+29 |
| | |||||
* | remove unused variable | Aaron Patterson | 2013-09-18 | 1 | -1/+0 |
| | |||||
* | support objects with blank string primary keys | Aaron Patterson | 2013-09-18 | 2 | -1/+7 |
| | |||||
* | ActiveRecord::Base#<=> has been removed. Primary keys may not be in order, | Aaron Patterson | 2013-09-18 | 3 | -16/+10 |
| | | | | | | | | | | | or even be numbers, so sorting by id doesn't make sense. Please use `sort_by` and specify the attribute you wish to sort with. For example, change: Post.all.to_a.sort to: Post.all.to_a.sort_by(&:id) | ||||
* | do what the superclass does in the case that objects do not match | Aaron Patterson | 2013-09-18 | 2 | -0/+10 |
| | |||||
* | Merge pull request #12276 from kennyj/fix_12269 | Rafael Mendonça França | 2013-09-18 | 3 | -0/+11 |
|\ | | | | | Fix an issue where router can't recognize downcased url encoding path. | ||||
| * | Fix an issue where router can't recognize downcased url encoding path. | kennyj | 2013-09-19 | 3 | -0/+11 |
|/ | |||||
* | There's no need to do this | Santiago Pastorino | 2013-09-17 | 1 | -4/+1 |
| | | | | | | | AS does the following inside Time.find_zone! ... `ActiveSupport::TimeZone[time_zone] || TZInfo::Timezone.get(time_zone)` and given that the test is stubbing AS::TZ[] we don't need the removed code. | ||||
* | Merge pull request #12262 from sferik/remove_tzinfo_from_actionpack | Rafael Mendonça França | 2013-09-17 | 1 | -5/+4 |
|\ | | | | | Remove tzinfo dependency from Action Pack | ||||
| * | Remove tzinfo dependency from Action Pack | Erik Michaels-Ober | 2013-09-17 | 1 | -5/+4 |
|/ | | | | | This gem is used by Active Support but it should not be a dependency of Action Pack. | ||||
* | Merge pull request #12250 from JuanitoFatas/migration | Rafael Mendonça França | 2013-09-16 | 1 | -3/+3 |
|\ | | | | | [ci skip] Improve readability of 4.3's NOTE in migration.md. | ||||
| * | [ci skip] Improve readability of 4.3's NOTE in migration.md. | Juanito Fatas | 2013-09-17 | 1 | -3/+3 |
| | | |||||
* | | Merge pull request #12011 from jetthoughts/11963_fix_join_with_association_scope | Rafael Mendonça França | 2013-09-16 | 4 | -6/+25 |
|\ \ | |/ |/| | | | | | | | | | Collapse where constraints to the Arel::Nodes::And node Conflicts: activerecord/CHANGELOG.md | ||||
| * | Collapse where constraints to one where constraint | Paul Nikitochkin | 2013-09-13 | 4 | -6/+25 |
| | | | | | | | | | | | | | | In order to remove duplication with joining arel where constraints with `AND`, all constraints on `build_arel` are collapsed into one head node: `Arel::Nodes::And` Closes: #11963 | ||||
* | | Merge pull request #12245 from kennyj/remove_no_using_code_20130916 | José Valim | 2013-09-16 | 1 | -4/+0 |
|\ \ | | | | | | | Removes unused code related to DatabaseTasks. | ||||
| * | | Removes unused code related to DatabaseTasks. | kennyj | 2013-09-16 | 1 | -4/+0 |
|/ / | |||||
* | | Merge pull request #12239 from JuanitoFatas/form_helpers | Steve Klabnik | 2013-09-15 | 1 | -1/+1 |
|\ \ | | | | | | | [ci skip] Consistency wording of 9.6 in form_helpers.md | ||||
| * | | [ci skip] Consistency wording of 9.6 in form_helpers.md | Juanito Fatas | 2013-09-15 | 1 | -1/+1 |
|/ / | | | | | | | | | | | Chapter 9 is giving a user and set of addresses example. So 'Add a new address' would be more consistent. Also change the javascript to JavaScript. | ||||
* | | Merge pull request #12231 from harshadsabne/master | Steve Klabnik | 2013-09-14 | 1 | -6/+6 |
|\ \ | | | | | | | [ci skip] Update plugins.md | ||||
| * | | [ci skip] Update plugins.md | Harshad Sabne | 2013-09-14 | 1 | -6/+6 |
| | | | | | | | | | Highlighted code. | ||||
* | | | Merge pull request #12225 from adomokos/no_need_for_active_support_concern | Steve Klabnik | 2013-09-13 | 1 | -2/+0 |
|\ \ \ | | | | | | | | | Removing ActiveSupport::Concern, it's not needed | ||||
| * | | | Removing ActiveSupport::Concern, it's not needed | Attila Domokos | 2013-09-13 | 1 | -2/+0 |
|/ / / | |||||
* | | | Merge pull request #12223 from adomokos/fixing_typo | Rafael Mendonça França | 2013-09-13 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Fixing comment typo in ActionController::Base | ||||
| * | | | Fixing comment typo in ActionController::Base | Attila Domokos | 2013-09-13 | 1 | -1/+1 |
|/ / / | |||||
* | | | Don't require using application_name before options | Piotr Sarnacki | 2013-09-13 | 5 | -23/+23 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Before this commit options for `rails new` and `rails plugin new` had to be passed in a strict order, trying to execute a following command: rails new -J path/to/app resulted in an error. This commit fixes the situation and allows to pass path to app anywhere after `new` | ||||
* | | | Merge pull request #12222 from rcillo/fix-custom-flash | Rafael Mendonça França | 2013-09-13 | 3 | -1/+20 |
|\ \ \ | | | | | | | | | | | | | | | | | Custom flash should be defined only for the class that defines it and it's subclasses Fixes #12057 | ||||
| * | | | Custom flash should be defined only for the class that defines it and it's ↵ | Ricardo de Cillo | 2013-09-13 | 3 | -1/+20 |
| | | | | | | | | | | | | | | | | subclasses. | ||||
* | | | | Merge pull request #12215 from harshadsabne/master | Rafael Mendonça França | 2013-09-13 | 1 | -5/+5 |
|\ \ \ \ | | |/ / | |/| | | Update 3_2_release_notes.md | ||||
| * | | | Update 3_2_release_notes.md | Harshad Sabne | 2013-09-13 | 1 | -5/+5 |
| | | | | | | | | | | | | Fixed typo and applied proper code highlighting. | ||||
* | | | | Merge pull request #12216 from suginoy/a-an | Rafael Mendonça França | 2013-09-13 | 9 | -11/+11 |
|\ \ \ \ | | | | | | | | | | | Fix typos: the indefinite articles(a -> an). | ||||
| * | | | | Fix typos: the indefinite articles(a -> an) | SUGINO Yasuhiro | 2013-09-13 | 9 | -11/+11 |
| | | | | | |||||
* | | | | | Missing destroy command | Akira Matsuda & Yukiko Kawamoto | 2013-09-13 | 1 | -0/+4 |
| |_|/ / |/| | | |