aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Use local variable instead of instance variable [ci skip]Daniel Amireh2016-11-051-1/+1
| | | Update render yield docs to use `search` local variable instead of `@q` instance variable
* Tweaking some test data due to sprintf behavior change in 2.4Akira Matsuda2016-11-051-5/+5
| | | | | | | | 2.3: sprintf('%0.1f', 5.55) #=> "5.5" 2.4: sprintf('%0.1f', 5.55) #=> "5.6" see: https://github.com/ruby/ruby/commit/6ed8c79ddb11ccfb580bb0a22b22cc1362250255 and https://github.com/ruby/ruby/commit/295f60b94d5ff6551fab7c55e18d1ffa6a4cf7e3
* Show what was the error when assertion has failedAkira Matsuda2016-11-051-1/+1
| | | | this test case fails with ruby 2.4, so we want to see what's actually happening
* Less method invocationAkira Matsuda2016-11-051-1/+1
|
* Merge pull request #26967 from headius/bad_threading_testAaron Patterson2016-11-041-5/+5
|\ | | | | Use different name for main and thread connection variable.
| * Use different name for main and thread connection variable.Charles Oliver Nutter2016-11-041-5/+5
| | | | | | | | | | | | Under JRuby, the updates of the one shared variable interleaved, causing threads to pick up each others' connections. I'm amazed this worked on MRI.
* | Merge pull request #26965 from rothhound/update_sqlite3Guillermo Iguaran2016-11-041-3/+3
|\ \ | | | | | | Update sqlite3
| * | Update sqlite3Gianfranco Montoya2016-11-041-3/+3
|/ /
* | Merge pull request #26536 from ↵Arthur Nogueira Neves2016-11-041-2/+2
|\ \ | |/ |/| | | | | y-yagi/change_increment_and_decrement_to_public_api change `MemCacheStore#increment` and `MemCacheStore#decrement` to public API [ci skip]
| * change `MemCacheStore#increment` and `MemCacheStore#decrement` to public API ↵yuuji.yaginuma2016-09-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip] I'm not sure why these methods not public. But these methods are public in other cache stores, I think that may be in public. Ref: http://edgeapi.rubyonrails.org/classes/ActiveSupport/Cache/Store.html#method-i-increment http://edgeapi.rubyonrails.org/classes/ActiveSupport/Cache/FileStore.html#method-i-increment http://edgeapi.rubyonrails.org/classes/ActiveSupport/Cache/MemoryStore.html#method-i-increment http://edgeapi.rubyonrails.org/classes/ActiveSupport/Cache/NullStore.html#method-i-increment
* | Don't assign default attributes until after loading schemaSean Griffin2016-11-031-1/+1
| | | | | | | | | | | | | | | | If the call to `.define_attribute_methods` actually ends up loading the schema (*very* hard to do, as it requires the object being created without `allocate` having been called, but it can be done by manually calling `initialize` from inside `marshal_load` if you're crazy), the value of `_default_attributes` will change from that call.
* | Merge pull request #26455 from kamipo/move_test_quoting_classesArthur Nogueira Neves2016-11-032-13/+4
|\ \ | | | | | | Move `test_quoting_classes` into `test/cases/quoting_test.rb`
| * | Move `test_quoting_classes` into `test/cases/quoting_test.rb`Ryuta Kamizono2016-10-292-13/+4
| | |
* | | Merge pull request #24202 from Sen-Zhang/fix_datetime_errorArthur Nogueira Neves2016-11-033-1/+13
|\ \ \ | | | | | | | | fix datatime error
| * | | fix datatime errorSen-Zhang2016-11-013-1/+13
| | | |
* | | | Fixes TypeError Exception when cache counter value equals nil (#26940)Daniel E. Garcia Shulman2016-11-022-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | * Fixes TypeError when cache counter value equals nil * Test case for counter cache on unloaded has_many association
* | | | Use tr instead of gsubAkira Matsuda2016-11-021-1/+1
| | | |
* | | | Merge pull request #26951 from y-yagi/fix_ruby_warningGuillermo Iguaran2016-11-011-1/+1
|\ \ \ \ | |/ / / |/| | | remove warning from railtie
| * | | remove warning from railtieyuuji.yaginuma2016-11-021-1/+1
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the following warnings. ```ruby rails/railties/lib/rails/railtie.rb:186: warning: instance variable @rake_tasks not initialized rails/railties/lib/rails/railtie.rb:186: warning: instance variable @rake_tasks not initialized rails/railties/lib/rails/railtie.rb:186: warning: instance variable @load_console not initialized rails/railties/lib/rails/railtie.rb:186: warning: instance variable @rake_tasks not initialized ```
* | | Make `register_block_for` privateArthur Neves2016-11-011-11/+11
| | |
* | | Merge pull request #26950 from bouk/exclude-dbmigrateSean Griffin2016-11-013-0/+10
|\ \ \ | | | | | | | | Don't put db:migrate and db:setup in binfiles if activerecord is excluded
| * | | Don't put db:migrate and db:setup in binfiles if activerecord is excludedBouke van der Bijl2016-11-013-0/+10
| | | |
* | | | Merge pull request #26451 from kamipo/remove_target_uniq_sizeSean Griffin2016-11-011-5/+1
|\ \ \ \ | | | | | | | | | | Remove unnecessary `target.uniq.size` in `CollectionAssociation#size`
| * | | | Remove unnecessary `target.uniq.size` in `CollectionAssociation#size`Ryuta Kamizono2016-10-291-5/+1
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If `association_scope` have `distinct_value`, same record cannot exist in `target`. https://github.com/rails/rails/blob/v5.0.0/activerecord/lib/active_record/associations/collection_association.rb#L419-L424 ```ruby def add_to_target(record, skip_callbacks = false, &block) if association_scope.distinct_value index = @target.index(record) end replace_on_target(record, index, skip_callbacks, &block) end ```
* | | | Merge pull request #26453 from kamipo/remove_unused_internal_dependent_optionSean Griffin2016-11-011-4/+1
|\ \ \ \ | |_|/ / |/| | | Remove unused internal `:dependent` option in `CollectionAssociation#delete`
| * | | Remove unused internal `:dependent` option in `CollectionAssociation#delete`Ryuta Kamizono2016-10-291-4/+1
| |/ / | | | | | | | | | | | | The internal `:dependent` option was introduced at #10604. But currently unused.
* | | Allow `autosave: true` to be used with inverse ofSean Griffin2016-11-015-12/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With the changes in #25337, double save bugs are pretty much impossible, so we can just lift this restriction with pretty much no change. There were a handful of cases where we were relying on specific quirks in tests that had to be updated. The change to has_one associations was due to a particularly interesting test where an autosaved has_one association was replaced with a new child, where the child failed to save but the test wanted to check that the parent id persisted to `nil`. I think this is almost certainly the wrong behavior, and I may change that behavior later. But ultimately the root cause was because we never remove the parent in memory when nullifying the child. This makes #23197 no longer needed, but it is what we'll do to fix some issues on 5.0 Close #23197
* | | Merge pull request #25337 from sgrif/sg-changes-in-callbacksSean Griffin2016-11-0118-53/+362
|\ \ \ | | | | | | | | Deprecate the behavior of AR::Dirty inside of after_(create|update|save) callbacks
| * | | Deprecate the behavior of AR::Dirty inside of after_(create|update|save) ↵Sean Griffin2016-11-0118-53/+362
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | callbacks We pretty frequently get bug reports that "dirty is broken inside of after callbacks". Intuitively they are correct. You'd expect `Model.after_save { puts changed? }; model.save` to do the same thing as `model.save; puts model.changed?`, but it does not. However, changing this goes much farther than just making the behavior more intuitive. There are a _ton_ of places inside of AR that can be drastically simplified with this change. Specifically, autosave associations, timestamps, touch, counter cache, and just about anything else in AR that works with callbacks have code to try to avoid "double save" bugs which we will be able to flat out remove with this change. We introduce two new sets of methods, both with names that are meant to be more explicit than dirty. The first set maintains the old behavior, and their names are meant to center that they are about changes that occurred during the save that just happened. They are equivalent to `previous_changes` when called outside of after callbacks, or once the deprecation cycle moves. The second set is the new behavior. Their names imply that they are talking about changes from the database representation. The fact that this is what we really care about became clear when looking at `BelongsTo.touch_record` when tests were failing. I'm unsure that this set of methods should be in the public API. Outside of after callbacks, they are equivalent to the existing methods on dirty. Dirty itself is not deprecated, nor are the methods inside of it. They will only emit the warning when called inside of after callbacks. The scope of this breakage is pretty large, but the migration path is simple. Given how much this can improve our codebase, and considering that it makes our API more intuitive, I think it's worth doing.
* | | | Merge PR #26052Arthur Neves2016-11-011-12/+16
|\ \ \ \ | |/ / / |/| | |
| * | | Added register_block method to register rake_tasks, generators, console & ↵Rafael Fidelis2016-11-011-12/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | runner blocks fixing @generators var initialization pre initializing variables values Changing from var init to symbol to instance var get/set
* | | | Merge pull request #26943 from colleenmcguckin/testing_typoKasper Timm Hansen2016-10-311-2/+2
|\ \ \ \ | | | | | | | | | | fix typo in Rails Test Runner section
| * | | | fix typo in Rails Test Runner sectioncolleenmcguckin2016-10-311-2/+2
|/ / / /
* | | | Ensure duration parsing is consistent across DST changesAndrew White2016-10-313-2/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously `ActiveSupport::Duration.parse` used `Time.current` and `Time#advance` to calculate the number of seconds in the duration from an arbitrary collection of parts. However as `advance` tries to be consistent across DST boundaries this meant that either the duration was shorter or longer depending on the time of year. This was fixed by using an absolute reference point in UTC which isn't subject to DST transitions. An arbitrary date of Jan 1st, 2000 was chosen for no other reason that it seemed appropriate. Additionally, duration parsing should now be marginally faster as we are no longer creating instances of `ActiveSupport::TimeWithZone` every time we parse a duration string. Fixes #26941.
* | | | Merge pull request #26838 from Cohen-Carlisle/activerecord-slice-array-argsGuillermo Iguaran2016-10-313-1/+15
|\ \ \ \ | | | | | | | | | | allow ActiveRecord::Core#slice to use array arg
| * | | | allow ActiveRecord::Core#slice to use array argCohen Carlisle2016-10-313-1/+15
|/ / / /
* | | | Merge pull request #23094 from yui-knk/fix_ar_test_commentArthur Nogueira Neves2016-10-311-5/+4
|\ \ \ \ | | | | | | | | | | Fix the order of `create_table` to match a comment about `:inverse_of…
| * | | | Remove a confusing commentyui-knk2016-10-311-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | These comment sometimes explain a face which does not match the face.
| * | | | Fix the order of `create_table` to match a comment about `:inverse_of` optionsyui-knk2016-10-311-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | In ActiveRecord test :men, :faces, :interests and :zines tables are used for `:inverse_of` test cases, not `:wheels`.
* | | | | Merge pull request #26938 from riseshia/patch-1प्रथमेश Sonpatki2016-10-311-1/+0
|\ \ \ \ \ | | | | | | | | | | | | Remove `Rack::Runtime from console log [ci skip]
| * | | | | Remove `Rack::Runtime from console log [ci skip]Shia2016-10-311-1/+0
|/ / / / /
* | | | | Merge pull request #26935 from y-yagi/fix_ruby_warningAndrew White2016-10-311-1/+1
|\ \ \ \ \ | | | | | | | | | | | | remove warning from big integer test
| * | | | | remove warning from big integer testyuuji.yaginuma2016-10-311-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the following warnings. ``` activemodel/test/cases/type/big_integer_test.rb:15: warning: ambiguous first argument; put parentheses or a space even after `-' operator ```
* | | | | | Merge pull request #26936 from caramelcat/add-missing-spaceGuillermo Iguaran2016-10-301-1/+1
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Add missing space in Migrations guide [ci skip]
| * | | | | Add missing space in Migrations guide [ci skip]Benny2016-10-311-1/+1
|/ / / / /
* | | | | Merge pull request #26932 from y-yagi/update_doc_about_assets_digestJon Moss2016-10-291-2/+2
|\ \ \ \ \ | |_|_|/ / |/| | | | update doc about assets digest class [ci skip]
| * | | | update doc about assets digest class [ci skip]yuuji.yaginuma2016-10-301-2/+2
| |/ / / | | | | | | | | | | | | | | | | The default digest class changed to SHA256 in sprockets 3.0. Ref: https://github.com/sstephenson/sprockets/pull/647
* | | | Add more rubocop rules about whitespacesRafael Mendonça França2016-10-29380-2077/+2098
| | | |
* | | | Merge pull request #26926 from gsamokovarov/debug-exceptions-plain-loggersRafael França2016-10-292-1/+20
|\ \ \ \ | | | | | | | | | | Support plain loggers in DebugExceptions
| * | | | Support plain loggers in DebugExceptionsGenadi Samokovarov2016-10-282-1/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I have been seeing people setting `Logger` instances for `config.logger` and it blowing up on `rails/web-console` usage. Now, I doubt many folks are manually setting `ActionView::Base.logger`, but given that `DebugExceptions` is running in a pretty fragile environment already, having it crash (and being silent) in those cases can be pretty tricky to trace down. I'm proposing we verify whether the `ActionView::Base.logger` supports silencing before we try to do it, to save us the headache of tracing it down.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 18:29:44 +0000