| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
Use REDIS_URL var for Action Cable config template
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | |
| | | |
Do not generate default alt text for images
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Auto-generating content from the filename of an image is not suitable
alternative text; alt text that isn't fully considered can be
distracting and fatiguing for screen readers users (blind, low vision,
dyslexic people).
- Setting a filename fallback short circuits screen reader default
behavior and configuration for blank descriptions.
- Setting poor defaults also creates false negatives for accessibility
linting and testing software, that makes it harder to improve
application accessibility.
***
- After this change, if authors leave images without alt text, screen
readers will fallback to default behavior for missing alt text.
- Also with this change, Automated linting and testing tools will
correctly generate warnings.
[Fixes #30096]
|
|\ \ \
| | | |
| | | | |
`counter_cache` requires association class before `attr_readonly`
|
| | |/
| |/|
| | |
| | |
| | | |
There were similar pull requests #26370 #27575 fixed by different way
by moving `require "models/post"` before `require "models/comment"`
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
yhirano55/use_https_instead_of_http_in_rails_guide
Use https instead of http in guide [ci skip]
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Load :author_addresses fixture to keep data integrity with :authors
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
`:authors` has a foreign key to `:author_addresses`.
If only `:authors` fixture loaded into the database which supports
foreign key and checks the existing data when enabling foreien keys
like Oracle, it raises the following error
`ORA-02298: cannot validate (ARUNIT.FK_RAILS_94423A17A3) - parent keys not found`
It is because there is no parent data exists in `author_addresses` table.
Here are how other database with foreign key support works:
- MySQL does not check the existing data when enabling foreign key by `foreign_key_checks=1`
https://dev.mysql.com/doc/refman/5.7/en/server-system-variables.html#sysvar_foreign_key_checks
> Setting foreign_key_checks to 1 does not trigger a scan of the existing table data. Therefore, rows added to the table while foreign_key_checks=0 will not be verified for consistency.
- PostgreSQL database itself has a feature to check existing data when
enabling foreign key and discussed at #27636, which is reverted.
|
|\ \ \
| | | |
| | | | |
Add TransactionTimeout for MySQL error code 1205
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fix spaces in the comment block [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| |_|_|/ /
|/| | | | |
Grammar fix
|
|/ / / /
| | | |
| | | |
| | | | |
Changed the phrase '... and many more high targets' to '... and many more high _profile_ targets'
|
|\ \ \ \
| | | | |
| | | | | |
Fixing nginx configuration added missing semicolon [ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Use 5.2 version of ActiveRecord::Migration for Active Storage
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
bogdanvlviv/remove-frozen_string_literal-from-blob-migration
Remove frozen_string_literal comment from activestorage's migration
|
| |/ / /
| | | |
| | | |
| | | |
| | | | |
The activestorage's migration is used as template for apps
Related to #30348
|
|\ \ \ \
| | | | |
| | | | | |
Automatically guess the inverse associations for STI
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
ActiveRecord associations automatically guess the inverse associations.
But this feature does not work correctly on assoctions for STI.
For example, before this commit
```
class Post < ActiveRecord::Base
belongs_to :author
end
class SpecialPost < Post; end
class Author < ActiveRecord::Base
has_many :posts
has_many :special_posts
end
```
`author.posts.first.author` works correctly, but
`author.special_posts.first.author` does not work correctly.
|
|\ \ \ \
| | | | |
| | | | | |
missing backquotes [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[actionpack] Update links to use https link instead of http [ci skip]
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
yhirano55/use_https_instead_of_http_in_activerecord
[activerecord] Update links to use https instead of http [ci skip]
|
| | |/ / /
| |/| | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove frozen_string_literal magic comment from templates
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
yhirano55/use_https_instead_of_http_in_activesupport
[activesupport] Update links to use https instead of http [ci skip]
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Update MIT licenses link [ci skip]
|
| | |/ / / /
| |/| | | | |
|
| | | | | | |
|
| |_|/ / /
|/| | | |
| | | | |
| | | | | |
Closes #30134.
|
|\ \ \ \ \
| |_|_|/ /
|/| | | | |
Update debugging rails applications guide [ci skip]
|
|/ / / / |
|
|\ \ \ \
| |_|/ /
|/| | | |
[ci skip] form_with in the getting started guide.
|
| | | |
| | | |
| | | |
| | | | |
Add back a bit about a resource oriented style of routing.
|
|\ \ \ \
| |_|/ /
|/| | |
| | | |
| | | | |
yhirano55/fix_broken_link_to_mysql_docs_in_database_yml
Fix broken link to mysql docs in database.yml [ci skip]
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Fix link in Contributing Ruby on Rails guide [ci skip]
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Add Contributing to the Rails Code link.
* Wiki link for Spanish is redirect.
* The base branch of Polish repo is master. And Turkish is, too.
* Unified expression `rails-dev-box`
* The Clone url is wrong.
* The mailing list url is old.
|
|\ \ \
| | | |
| | | | |
Update Contributing to Ruby on Rails guide [ci skip]
|
|/ / / |
|