| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
| |
Adding all those `public_*` methods is a bit heavy handed, we can change the API to instead use `public_folder: true`. Change was pretty easy since it was already implemented that way.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
We want to make it more explicit when a user wants to avoid the asset pipeline to do this we will add `public_*` methods to all path helpers. So if someone wants to use an asset that isn't maintained by the asset pipeline they can use `public_asset_path` instead of `asset_path` and letting it fall through.
The main reason for this change is the desire to raise helpful errors in the future. Right now if you typo an asset name, then we assume you intended an asset in the `public/` folder and not in the pipeline so nothing fails and the error sits silently until you realize the page didn't render correctly. We have to deprecate today so we can raise meaningful error messages in the future.
|
| |\
| |
| | |
[ci skip] Update branch version in Contributing Guide
|
| |/
|
|
|
| |
Since only Rails 4 and above are currently supported, this updates a
3-2-stable example to be consistent with the support standard.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The PR #20940 enabled the use of multiple roots with different constraints
at the top level but unfortunately didn't work when those roots were inside
a namespace and also broke the use of root inside a namespace after a top
level root was defined because the check for the existence of the named route
used the global :root name and not the namespaced name.
This is fixed by using the name_for_action method to expand the :root name to
the full namespaced name. We can pass nil for the second argument as we're not
dealing with resource definitions so don't need to handle the cases for edit
and new routes.
Fixes #26148.
|
| |
|
|
|
| |
This is the intended behavior. You should not do more than one request
in a controller test.
|
| |\
| |
| | |
use `inspect` for show `from` value
|
| | |
| |
| |
| | |
If `from` is nil, in order to avoid the blank is showed.
|
| |\ \
| |/
|/| |
Add .gitignore to "files & purpose" list - getting started docs
|
| |/ |
|
| |\
| |
| | |
Switch back to `Hash.dup`
|
| | |
| |
| |
| | |
Follow up to #26301.
|
| |\ \
| |/
|/| |
Remove "Under Ruby 1.9" [ci skip]
|
| |/
|
|
| |
Rails dropped Ruby 1.9 support, but this comment still true.
|
| |
|
|
|
| |
NumericalityValidator#validate_each is never called when allow_nil is true and
the value is nil because it is already skipped in EachValidator#validate.
|
| |
|
|
| |
Signed-off-by: Guillermo Iguaran <guilleiguaran@gmail.com>
|
| |\
| |
| | |
Switch back to `Hash.dup`
|
| |/
|
|
|
|
|
|
|
|
|
|
|
| |
The performance difference between `Hash[]` and `Hash.dup` looks to have
been narrowed by @tenderlove via this commit --> https://github.com/ruby/ruby/commit/b3803cc49ad382e23291d75ce57ffb2b74bb9577#diff-eff9999082c8ce7d8ba1fc1d79f439cf.
Since this commit first appeared in Ruby 2.0.0, and since Rails now
requires a minimum Ruby version of 2.2.2, this performance boost should
be available for all users.
Relevant links:
- This behavior was originally added via https://github.com/rails/rails/commit/02174a3efc6fa8f2e5e6f114e4cf0d8a06305b6a
- The conversation on the Ruby issue tracker lives here --> https://bugs.ruby-lang.org/issues/7166
|
| |\
| |
| | |
Fix typo in Delegation#delegate_missing_to doc [ci skip]
|
| |/ |
|
| |\
| |
| | |
Errors#add_on_blank: Fix typo in deprecation message
|
| |/
|
| |
This fixes a copy-and-paste-issue slipped in by #18996
|
| |\
| |
| | |
Move Rails' custom assertion method `assert_nothing_raised` to its proper place.
|
| |/
|
|
|
|
|
|
| |
ActiveSupport::Testing::Assertions.
We have a separate module in which have defined Rails' own custom
assertions. So it would be good to keep all custom Rails' assertions in
one place i.e. in this module.
|
| |
|
|
|
|
| |
It should not throw a NameError, but should throw a KeyError.
Fixes #26278
|
| |\
| |
| | |
Update `Rails.configuration` documentation
|
| | |
| |
| |
| | |
[ci skip]
|
| | |
| |
| |
| | |
[ci skip]
|
| | |
| |
| |
| |
| | |
This reverts commit 4973704bf56dbb0d8beba977e1053d57e346ebd0, reversing
changes made to 78edeb33346e13ab33a62d2a6b553aabf5b3186a.
|
| |\ \
| |/
|/| |
Move `assert_nothing_raised` method to Rails Specific Assertions section [ci skip]
|
| |/
|
|
|
|
|
|
| |
section [ci skip]
- Method `assert_nothing_raised` is Rails' own custom assertion method and
not a part of Minitest. So move it from Minitest assertions section to Rails
Specific Assertions section.
|
| |\
| |
| | |
Fix "warning: assigned but unused variable - task"
|
| |/ |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Usually users extends tests classes doing something like:
ActionView::TestCase.include MyCustomTestHelpers
This is bad because it will load the ActionView::TestCase right aways
and this will load ActionController::Base making its on_load hooks to
execute early than it should.
One way to fix this is using the on_load hooks of the components like:
ActiveSupport.on_load(:action_view) do
ActionView::TestCase.include MyCustomTestHelpers
end
The problem with this approach is that the test extension will be only
load when ActionView::Base is loaded and this may happen too late in the
test.
To fix this we are adding hooks to people extend the test classes that
will be loaded exactly when the test classes are needed.
|
| |
|
|
|
|
|
| |
We can eliminate a conditional by calling a different instrumentation
method depending on the situation. In this case, we'll call the special
case "!render_template" instrumentation method and eliminate the case /
when clause from the `instrument` method.
|
| |
|
|
| |
Ruby already does this freeze for us.
|
| |
|
|
|
|
|
| |
CacheHelper is mixed in to Helpers, Helpers is mixed in to AV::Base.
This means we can count on instances of AV::Base to have the "cache hit"
method on them, and we can stop setting an ivar for cache logging and
just ask the view if it was a cache hit.
|
| |\
| |
| | |
Test that AR query cache isn't busted when types are not same object
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is fixed in 5.0 as an ancillary part of 574f255629a45cd67babcfb9bb8e163e091a53b8
but here I also add a test for the condition.
I'd previously backported the fix (and added a test) in the below
commit; this brings the fix back up to master.
(cherry picked from commit fce3dbf30241f2a65c777e192a7171b0eea81453)
|
| |\ \
| |/
|/|
| |
| | |
samphippen/allow-early-setting-of-integration-session
Allow the `integration_sesion` to be set early on ActionDispatch::Integration::Runner.
|
| | |
| |
| |
| | |
This allows us to not `||=` in `before_setup`.
|
