aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | Merge pull request #22775 from derekprior/dp-number-to-currency-docsRafael França2015-12-232-0/+16
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Add i18n caveat to number_to_currency docs [ci skip]
| * | | | | Add caveat to number_to_currency docs [ci skip]Derek Prior2015-12-232-0/+16
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I've worked on a few applications that have gone through the internationalization process and had issues because they were using `number_to_currency`. The minute a user is allowed to change their locale, they can change the price displayed on a page from 10 US dollars to 10 Mexican Pesos, which is far from the same amount of money. Unlike other helpers that rely on i18n, `number_to_currency` does not produce equivalent results when the locale is changed. As I've explained this to a few groups of developers now, I thought it might make for a good caveat in the docs.
* | | | | Require only the concurrent/map featureRafael Mendonça França2015-12-231-1/+1
| | | | |
* | | | | release notes, Rails 5 won't support the protected_attribtues gem.Yves Senn2015-12-231-0/+3
| |_|_|/ |/| | | | | | | | | | | [ci skip]
* | | | release notes, extracted notable changes from Active Record CHANGELOG.Yves Senn2015-12-232-11/+176
| | | | | | | | | | | | | | | | [ci skip]
* | | | release notes, extract notable changes from Active Model CHANGELOG.Yves Senn2015-12-231-0/+28
| | | | | | | | | | | | | | | | [ci skip]
* | | | release notes, extract notable changes from Active Job CHANGELOG.Yves Senn2015-12-232-4/+17
| | | | | | | | | | | | | | | | [ci skip]
* | | | release notes, extract notable changes from Active Support CHANGELOG.Yves Senn2015-12-232-13/+128
| | | | | | | | | | | | | | | | [ci skip]
* | | | Merge pull request #22769 from ↵Richard Schneeman2015-12-231-2/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | prathamesh-sonpatki/fix-typos-in-5-0-release-notes Fix typos in Rails 5.0 release notes [ci skip]
| * | | | Fix typos in Rails 5.0 release notes [ci skip]Prathamesh Sonpatki2015-12-231-2/+2
|/ / / /
* | | | Merge pull request #22760 from reshleman/re-numericality-with-stringsSean Griffin2015-12-222-2/+51
|\ \ \ \ | | | | | | | | | | Fix Regression in Numericality Validations
| * | | | Convert non-`Numeric` values to FloatsRobert Eshleman2015-12-221-1/+1
| | | | |
| * | | | Fix Regression in Numericality ValidationsRobert Eshleman2015-12-221-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A regression (#22744) introduced in 7500dae caused certain numericality validations to raise an error when run against an attribute with a string value. Previously, these validations would successfully run against string values because the value was cast to a numeric class. This commit resolves the regression by converting string values to floats before performing numericality comparison validations. [fixes #22744]
| * | | | Failing Tests for Validating String NumbericalityRobert Eshleman2015-12-221-0/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Covers Regressions: * <= * < * == * > * >= * other than
* | | | | Merge pull request #22762 from djpowers/patch-1Rafael França2015-12-221-1/+1
|\ \ \ \ \ | |/ / / / |/| | | | Fix letter case and grammar in Routing guide
| * | | | Fix letter case and grammar in Routing guideDave Powers2015-12-221-1/+1
|/ / / /
* | | | Merge pull request #22620 from kamipo/join_to_delete_is_same_as_join_to_updateRafael França2015-12-223-11/+5
|\ \ \ \ | | | | | | | | | | `join_to_delete` is same as `join_to_update`
| * | | | `join_to_delete` is same as `join_to_update`Ryuta Kamizono2015-12-173-11/+5
| | | | | | | | | | | | | | | | | | | | Reapply #22615.
* | | | | Currectly test the Middleware#==Rafael Mendonça França2015-12-221-4/+8
| | | | |
* | | | | Merge pull request #22743 from maclover7/fix-22738Rafael Mendonça França2015-12-222-0/+21
|\ \ \ \ \ | |_|_|_|/ |/| | | | | | | | | Add #== back to ActionDispatch::MiddlewareStack::Middleware
| * | | | Add #== back to ActionDispatch::MiddlewareStack::MiddlewareJon Moss2015-12-212-0/+21
| | |/ / | |/| | | | | | | | | | | | | | This was causing bug #22738 to occur. Also added extra tests to make sure everything is A-OK.
* | | | Merge pull request #22749 from sblackstone/mysql2flagsMatthew Draper2015-12-232-2/+14
|\ \ \ \ | | | | | | | | | | Add support for passing flags to MySQL2 adapter by array
| * | | | Add support for passing flags to MySQL2 adapter by arrayStephen Blackstone2015-12-222-2/+14
| | |_|/ | |/| |
* | | | Merge pull request #22757 from paulkogel/patch-1Rafael França2015-12-221-1/+1
|\ \ \ \ | | | | | | | | | | seeds.rb.tt: fix English.
| * | | | seeds.rb.tt: fix English.Paul Kögel2015-12-221-1/+1
| | | | |
* | | | | Merge pull request #22758 from LaurierMantel/release_5_0_typoArun Agrawal2015-12-221-1/+1
|\ \ \ \ \ | | | | | | | | | | | | fixes typo in 5.0 release notes
| * | | | | fixes typo in 5.0 release notesLaurier Mantel2015-12-221-1/+1
|/ / / / /
* | | | | Merge pull request #22755 from y-yagi/remove_cors_initializer_from_rails_appSean Griffin2015-12-222-0/+12
|\ \ \ \ \ | |/ / / / |/| | | | remove cors initializer from rails app
| * | | | remove cors initializer from rails appyuuji.yaginuma2015-12-222-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | `rack-cors` gem is defined in Gemfile by default only if the api, not defined by default in rails app.
* | | | | release notes, extract notable changes from Action Mailer CHANGELOG.Yves Senn2015-12-222-3/+21
| | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | release notes, extract notable changes from Action View CHANGELOG.Yves Senn2015-12-222-7/+28
| | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | release notes, use past tense. [ci skip]Yves Senn2015-12-221-15/+15
| | | | |
* | | | | release notes, extract notable changes from Action Pack CHANGELOG.Yves Senn2015-12-222-24/+139
| | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | [ci skip] Steal `ActionCable.server` mounting from routes template.Kasper Timm Hansen2015-12-221-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | Mounting it as prescribed here: https://github.com/rails/rails/blob/0d1d50c2db40ea1a9d3bebfb0c35da43bbd4d27f/railties/lib/rails/generators/rails/app/templates/config/routes.rb#L5
* | | | | release notes, extract notable changes from Railties CHANGELOG.Yves Senn2015-12-222-9/+53
| | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | guides, restructure Rails 5.0 release notes. [ci skip]Yves Senn2015-12-222-91/+160
|/ / / / | | | | | | | | | | | | | | | | xref #22701. xref #20612.
* | | | Merge pull request #22701 from maclover7/rails-5-release-notesYves Senn2015-12-221-0/+188
|\ \ \ \ | | | | | | | | | | [WIP] Rails 5 release notes [ci skip]
| * | | | Add Rails 5.0 Release NotesJon Moss2015-12-211-0/+188
| | |/ / | |/| | | | | | | | | | [ci skip]
* | | | Merge pull request #22483 from y-yagi/use_bin_test_in_plugins_guideYves Senn2015-12-221-32/+67
|\ \ \ \ | | | | | | | | | | use `bin/test` in plugins guide [ci skip]
| * | | | use `bin/test` in plugins guide [ci skip]yuuji.yaginuma2015-12-221-32/+67
| |/ / / | | | | | | | | | | | | | | | | `bin/test` can use the same API as the `bin/rails test`, since it is possible to run a flexible test than rake, I think better to use a guide even `bin/test`.
* | | | Merge pull request #22752 from y-yagi/remove_div_for_from_docMatthew Draper2015-12-221-8/+9
|\ \ \ \ | | | | | | | | | | do not use `div_for` in example [ci skip]
| * | | | do not use `div_for` in example [ci skip]yuuji.yaginuma2015-12-221-8/+9
| |/ / / | | | | | | | | | | | | `div_for` removed in 01e94ef
* | | | Merge pull request #22754 from ryohashimoto/151222_remove_content_tag_forMatthew Draper2015-12-221-7/+5
|\ \ \ \ | | | | | | | | | | remove content_tag_for example
| * | | | remove content_tag_for exampleRyo Hashimoto2015-12-221-7/+5
| | |/ / | |/| |
* | | | Merge pull request #22753 from gwincr11/keeps-options-breaks-assetsMatthew Draper2015-12-221-1/+1
|\ \ \ \ | |/ / / |/| | | Fix .keep file issue with ActionCable
| * | | Fix .keep file issue with ActionCableCory Gwin2015-12-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Fixes #22708 Make sure the channels file is create in assets/javascript/ so require tree works in asset pipeline.
* | | | Merge pull request #22746 from davidenglishmusic/masterGuillermo Iguaran2015-12-211-1/+1
|\ \ \ \ | | | | | | | | | | corrects a typo [ci-skip]
| * | | | corrects a typoDavid English2015-12-211-1/+1
|/ / / /
* | | | Merge pull request #22709 from ↵Rafael França2015-12-211-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | jonatack/clarify-explanation-for-new-config-halt-callback-chains Clarify config settings for AS::halt_callback_chains_on_return_false
| * | | | Clarify config settings for AS::halt_callback_chains_on_return_falseJon Atack2015-12-211-1/+1
| | | | | | | | | | | | | | | | | | | | [skip ci]
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-09 13:59:32 +0000