aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Use assert over assert_predicate in assert_responsePrathamesh Sonpatki2015-12-062-3/+3
| | | | | | | | | | | | | | | | | | | - `assert_predicate` appends its own error message at the end of message generated by `assert_response` and because of that the error message displays the whole `response` object. - For eg. Expected response to be a <success>, but was a redirect to <http://test.host/posts>. Expected #<ActionDispatch::TestResponse:0x007fb1cc1cf6f8....(lambda)>}>> to be successful?. - Complete message can be found here - https://gist.github.com/prathamesh-sonpatki/055afb74b66108e71ded#file-gistfile1-txt-L19. - After this change the message from `assert_predicate` won't be displayed and only message generated by `assert_response` will be shown as follows: Expected response to be a <success>, but was a redirect to <http://test.host/posts>
* Merge pull request #19977 from ↵Arthur Nogueira Neves2015-12-052-1/+31
|\ | | | | | | | | prathamesh-sonpatki/mention-redirect-path-in-assert-response Add redirection path in the error message of assert_response if response is :redirect
| * Add redirection path in the error message of assert_response if response is ↵Prathamesh Sonpatki2015-12-042-1/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | :redirect - If the assert_response is checking for any non-redirect response like :success and actual response is :redirect then, the error message displayed was - Expected response to be a <success>, but was <302> - This commit adds the redirect path to the error message of assert_response if the response is :redirect. So above message is changed to - Expected response to be a <success>, but was a redirect to <http://test.host/posts/lol>
* | Replace `-> {}` with a proc.Kasper Timm Hansen2015-12-051-1/+1
| | | | | | | | | | | | | | | | When `parse_options_for` was called for a command that hadn't set up any option parsing with `options_for`, the `call` method would be sent to `-> {}`, which didn't like to be passed two arguments. Switch to `proc {}` which can accept several arguments.
* | Merge pull request #22202 from grosser/grosser/write-consistentArthur Nogueira Neves2015-12-052-4/+12
|\ \ | | | | | | even if a write fails, store the raw value
| * | even if a write fails, store the raw valueMichael Grosser2015-11-292-4/+12
| | |
* | | Remove `_instance` suffix from command.Kasper Timm Hansen2015-12-051-2/+2
| | | | | | | | | | | | | | | I want to streamline the wording around `command`, and not start pondering about instances.
* | | Default `argv` to an empty array.Kasper Timm Hansen2015-12-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `ARGV` constant in Ruby is not a string, it's an array as demonstrated by running: ``` $ ruby -e "p ARGV" => [] $ $ ruby -e "p ARGV" test/file.rb --version=2 => ["test/file.rb", "--version=2"] ```
* | | Spruce up `command_for`.Kasper Timm Hansen2015-12-051-4/+1
| | | | | | | | | | | | | | | | | | * Ditch the instance methods local variable. * Prefer Ruby's default nil return, and remove else branch.
* | | `exists?` isn't for users.Kasper Timm Hansen2015-12-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Checking that a command exists before running it is an implementation detail of the Rails command and Rake task world right now. Eventually I'd like to get rid of `exists?`, when I've worked out another way to fall back to run the old tasks.
* | | Move `command_name_for` to private section.Kasper Timm Hansen2015-12-051-4/+4
| | | | | | | | | | | | | | | Users shouldn't have to lookup the command name for a task. Put it in the private section, so it doesn't show up in any generated documentation.
* | | Shrink a couple of deprecation warnings to one-linersMatthew Draper2015-12-061-18/+8
| | | | | | | | | | | | | | | The previous spelling seemed a bit too generous with the whitespace, and looked out of place when amongst others.
* | | Merge pull request #22492 from RochesterinNYC/patch-1Sean Griffin2015-12-052-3/+3
|\ \ \ | | | | | | | | Add note about serialization to update_columns documentation [ci skip]
| * | | Clean up and correct documentation for update_columns and update_all [ci skip]James Wen2015-12-052-3/+3
| | |/ | |/|
* | | Merge pull request #22500 from y-yagi/fix_warning_in_geometric_testSean Griffin2015-12-041-1/+3
|\ \ \ | | | | | | | | remove warning from postgresql geometric test
| * | | remove warning from postgresql geometric testyuuji.yaginuma2015-12-051-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the following warning which has been out in the case of a PostgreSQL 9.3 below. ``` activerecord/test/cases/adapters/postgresql/geometric_test.rb:265: warning: instance variable @connection not initialized ```
* | | | Merge pull request #22457 from ccallebs/rails-commands-infrastructureKasper Timm Hansen2015-12-059-51/+144
|\ \ \ \ | |_|/ / |/| | | Add Rails command infrastructure
| * | | Add Rails command infrastructure and encapsulate development cachingChuck Callebs2015-12-049-51/+144
|/ / /
* | | Merge pull request #22482 from ridiculous/masterRafael França2015-12-041-4/+6
|\ \ \ | | | | | | | | Replace ActionMailer::Base.respond_to? with respond_to_missing?
| * | | Make ActionMailer::Base.respond_to_missing? privateRyan Buckley2015-12-031-4/+6
| | | |
| * | | Replace ActionMailer::Base#respond_to? with respond_to_missing?Ryan Buckley2015-12-021-2/+2
| | | |
* | | | Merge pull request #22493 from rails/rm-fix-testsRafael França2015-12-044-14/+6
|\ \ \ \ | |/ / / |/| | | Fix the Railties tests
| * | | Disable FileEventedUpdateChecker for nowRafael Mendonça França2015-12-041-5/+1
| | | | | | | | | | | | | | | | | | | | Railsties tests are broken with this new update checker so we will use the old one until we have the tests fixed.
| * | | Mac OS X use /private as directory to temp fileRafael Mendonça França2015-12-041-1/+1
| | | | | | | | | | | | | | | | Related with e62ddac05b7d827ae870898d7cd9eaf76e0730aa
| * | | Remove test_files check from plugin checksRafael Mendonça França2015-12-041-4/+0
| | | | | | | | | | | | | | | | Related with 668c006cf33a63ac3f8a8f064c772a339341e70c.
| * | | Remove warningsRafael Mendonça França2015-12-041-4/+4
|/ / /
* | | Merge pull request #22476 from claudiob/comment-premClaudio B2015-12-022-2/+7
|\ \ \ | |/ / |/| | Remove old comment about AC::Parameters>subclasses
| * | Remove old comment about AC::Parameters>subclassesclaudiob2015-12-022-2/+7
|/ / | | | | | | | | | | | | | | | | | | | | | | [ci skip] Q: What happens if you initialize an AR model by passing Parameters that have not been whitelisted with `permit`? A: An `ActiveModel::ForbiddenAttributesError` is raised. I think this behavior is correct, and it's better than what used to happen, with unpermitted parameter being simply ignored.
* | Merge pull request #22469 from merhard/fix_custom_file_loader_testRafael França2015-12-021-0/+2
|\ \ | | | | | | Fix failing test using custom file watcher
| * | Fix failing test using custom file watcherMatthew Erhard2015-12-021-0/+2
| | | | | | | | | | | | | | | | | | | | | LoadingTest#test_does_not_reload_constants_on_development_if_custom_file_watcher_always_returns_false in railties/test/application/loading_test.rb is failing with: `NoMethodError: undefined method 'execute' for #<#<Class:0x00000002465a30>:0x00000001f79698>` The test creates an anonymous class to be used as a custom file watcher using `config.file_watcher=`. Per the Rails guides for Configuring, the class set to `config.file_watcher` “Must conform to ActiveSupport::FileUpdateChecker API”. Per the docs for ActiveSupport::FileUpdateChecker, the API depends on four methods: #initialize, #updated?, #execute, and #execute_if_updated. The custom file watcher in the failing test only implements the first two methods. This pull request adds #execute and #execute_if_updated to the custom file_watcher, conforming it to the ActiveSupport::FileUpdateChecker API, and passing the test.
* | | Merge pull request #22471 from merhard/railties_tests_actually_fail_on_travisRafael França2015-12-021-21/+8
|\ \ \ | |/ / |/| | Revert "don't start a new process for every test file"
| * | Revert "don't start a new process for every test file"Matthew Erhard2015-12-021-21/+8
|/ / | | | | | | | | This reverts commit 5a0e0e72995472e315738dcea5b5a12d6e3d3489. This commit causes railties tests on TravisCI to always return a 0 status (all tests passing), even when tests are failing. Reverting for now until a new solution can be found.
* | don't rely on the columns hash to get defaults. follow-up to #17169.Yves Senn2015-12-022-7/+25
| | | | | | | | | | | | This will also get the defaults from attribute definitions like: attribute :type, :string, default: "SomethingElse"
* | add `ActiveRecord::Base.has_attribute?`Yves Senn2015-12-023-2/+27
| | | | | | | | `has_attribute?` method to check wether a given attribute has been defined.
* | tests, pluralize singular table name.Yves Senn2015-12-021-1/+1
| | | | | | | | | | | | | | | | | | | | This solves the following error: ActiveRecord::StatementInvalid: Could not find table 'guitars' It seems that the table structure of the `Guitar` model has not been necessary until now. Due to the wrong table name the model was not correctly linked to the table.
* | Merge pull request #17169 from kuldeepaggarwal/fix-STI-default-typeYves Senn2015-12-023-9/+47
|\ \ | | | | | | | | | STI cast new instances to `default type` on initialize.
| * | STI cast new instances to `default type` on initialize.Kuldeep Aggarwal2015-12-023-0/+42
|/ / | | | | | | fixes #17121
* | Merge pull request #22464 from pavlos/patch-1Claudio B2015-12-011-1/+1
|\ \ | | | | | | Update autoloading_and_reloading_constants.md
| * | Update autoloading_and_reloading_constants.mdpavlos2015-12-011-1/+1
| | | | | | | | | Fixed a typo
* | | Ensure `Relation` responds to `shuffle`Sean Griffin2015-12-012-2/+2
|/ / | | | | | | | | It appears that I missed this one when I delegated all the non-mutation array methods that were not on Enumerable
* | Merge pull request #22343 from jeffminnear/patch-1Claudio B2015-12-011-2/+9
|\ \ | | | | | | Modify unscoped usage guide to include chaining [ci skip]
| * | Modify unscoped usage guide to include chainingJeff Minnear2015-11-301-2/+9
| | |
* | | Merge pull request #22449 from dnagir/database_connection_messageYves Senn2015-12-011-1/+1
|\ \ \ | | | | | | | | Explain the connection pool error message better [ci skip]
| * | | Explain the connection pool error message betterDmytrii Nagirniak2015-12-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous message was misleading (especially for Ops guys) when diagnosing problems related to the database connection. The message was suggesting that the connection cannot be obtained which normally assumes the need to look at the database. But this isn't the case as the connection could not be retrieved from the application's internal connection pool. The new message should make it more explicit and remove the confusion.
* | | | Merge pull request #22361 from grosser/grosser/rescueArthur Nogueira Neves2015-11-301-26/+19
|\ \ \ \ | | | | | | | | | | rescue memcached errors in a consistent way
| * | | | rescue memcached errors in a consistent wayMichael Grosser2015-11-291-26/+19
| | | | |
* | | | | Merge pull request #22456 from ↵Sean Griffin2015-11-302-1/+7
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | chriskottom/fix-minitest-plugin-with-minitest-rails-gem Allow use of minitest-rails gem with test runner
| * | | | | allow use of minitest-rails gem with test runnerChris Kottom2015-11-302-1/+7
|/ / / / /
* | | | | Merge pull request #22345 from GUI/fix-multi-schema-structure-dumpYves Senn2015-11-303-4/+10
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix rake db:structure:dump on Postgres when multiple schemas are used Conflicts: activerecord/CHANGELOG.md Closes #22346.
| * | | | | Fix rake db:structure:dump on Postgres when multiple schemas are used.Nick Muerdter2015-11-193-4/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If postgresql is being used and there are multiple schemas listed on the `schema_search_path`, then `structure.sql` dumps (triggered by `rake db:structure:dump` or `config.active_record.schema_format = :sql`) began failing in Rails 4.2.5. This is due to the changes made in https://github.com/rails/rails/pull/17885 The problem is that multiple schemas were getting getting passed to `Kernel.system` as a single, space delimited string argument (for example, "--schema=foo --schema=bar"). However, with the updated array style of calling `Kernel.system`, these need to be passed as separate arguments (for example, "--schema=foo", "--schema=bar"). If they get passed as a single string, then the underlying pg_dump program isn't sure how to interpret that single argument and you'll get an error reporting: "pg_dump: No matching schemas were found"
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-23 00:39:31 +0000