| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
we don't need it anymore. We always use the same dispatcher in tests.
|
|
|
|
|
| |
If we subclass and augment the superclass, then we don't need to have
setters for particular things on the superclass.
|
|\
| |
| | |
temp files are no more require
|
|/
|
| |
`:nail_care:`
|
|
|
|
|
|
| |
controller class resolution has been moved to the request object, so we
should override that method instead of relying on the RouteSet to
generate the controller class.
|
| |
|
|
|
|
|
|
|
|
| |
Before we were changing the state of the lookup_context for the duration
of the with_layout_format block, but since we already know the formats
we can just pass it explicitly.
Related with 8d7ce0f22aee09d20091a4dc58cb379a09d13e26
|
| |
|
| |
|
|
|
|
| |
explicitely.
|
|\
| |
| | |
[ci skip] Fix migration file's timestamp
|
| |
| |
| |
| | |
In rails generally migration file's timestamp is "YYYYMMDDHHMMSS".
|
|\ \
| | |
| | | |
Remove unused block arguments
|
| | | |
|
|\ \ \
| | | |
| | | | |
Remove unused variables
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Add `assert_nothing_raised` to make clear test case perpose
|
| | |/ /
| |/| | |
|
|\ \ \ \
| | | | |
| | | | | |
Use the PORT environment variable for rails server
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Only nullify persisted has_one target associations
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Since after 87d1aba3c `dependent: :destroy` callbacks on has_one
assocations run *after* destroy, it is possible that a nullification is
attempted on an already destroyed target:
class Car < ActiveRecord::Base
has_one :engine, dependent: :nullify
end
class Engine < ActiveRecord::Base
belongs_to :car, dependent: :destroy
end
> car = Car.create!
> engine = Engine.create!(car: car)
> engine.destroy! # => ActiveRecord::ActiveRecordError: cannot update a
> destroyed record
In the above case, `engine.destroy!` deletes `engine` and *then* triggers the
deletion of `car`, which in turn triggers a nullification of `engine.car_id`.
However, `engine` is already destroyed at that point.
Fixes #21223.
|
|\ \ \ \ \ \
| |_|_|_|_|/
|/| | | | |
| | | | | |
| | | | | |
| | | | | | |
y-yagi/add_activejob_section_to_instrumentation_guide
add Active Job section to instrumentation guide [ci skip]
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Get rid of mocha tests in actionpack - part 1
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Small fixes [ci skip]
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
* fix command list for thread
* add omitted end of code
* fix description for `continue` and `finish` command
|
| |_|_|/ / / /
|/| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
[ci skip]
This example is dependent on the `:end_at` option and has been removed
from `4-2-stable` (d167b811520a6f800b86c77b805d15505a251bb8)
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Removed Mocha from ActionView part 1
|
| | |_|_|_|_|/
| |/| | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Conflicts:
guides/source/security.md
|
| |\ \ \ \ \ \ \
| | |/ / / / / /
| |/| | | | | | |
[ci skip] Fix the grammar
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
This is discussed on https://github.com/rails/rails/pull/21334
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
we already have a request, so we should use the methods on the request
to access the path info information
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Creates fewer request objects and helps to abstract away from internals
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
try to remove dependencies on `@env` so we can have more flexible
internals
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Remove test helper method to inside test method
|
| | | |_|_|_|/
| | |/| | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Remove `MigrationTest#connection` and write `ActiveRecord::Base.connection`
directly to test, because `MigrationTest#connection` is only used in
`test_migration_instance_has_connection`.
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Another place to use a request object in NullSessionHash
|
| | |/ / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
May be missed in 5fe141638f1243ac6ae187ae14aa398b4c1875a2 commit
Also fixes the broken build
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Remove a link to the site that seems to be gone. [ci skip]
|