Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Merge pull request #25378 from nikhilthombare/patch-1 | प्रथमेश Sonpatki | 2016-06-12 | 1 | -11/+11 |
|\ | | | | | Changed ActiveJob::Base to ApplicationJob in the Active Job guide [ci… | ||||
| * | Changed ActiveJob::Base to ApplicationJob in the Active Job guide [ci skip] | Nikhil Thombare | 2016-06-13 | 1 | -11/+11 |
|/ | | | @prathamesh-sonpatki | ||||
* | Merge pull request #25362 from maclover7/jm-rm-ar-require | Eileen M. Uchitelle | 2016-06-12 | 1 | -2/+0 |
|\ | | | | | Remove unnecessary model requires | ||||
| * | Remove unnecessary model requires | Jon Moss | 2016-06-10 | 1 | -2/+0 |
| | | |||||
* | | Merge pull request #25371 from kamipo/remove_outdated_comment | Eileen M. Uchitelle | 2016-06-12 | 1 | -12/+0 |
|\ \ | | | | | | | Remove outdated comments [ci skip] | ||||
| * | | Remove outdated comments [ci skip] | Ryuta Kamizono | 2016-06-12 | 1 | -12/+0 |
| | | | | | | | | | | | | | | | These comments were added at dd257a3ccb30ab181cd48d3d81bc7f23bb45f36f but outdated since #2086. | ||||
* | | | Merge pull request #25004 from ↵ | Eileen M. Uchitelle | 2016-06-12 | 5 | -0/+44 |
|\ \ \ | |/ / |/| | | | | | | | | y-yagi/generate_mailer_layout_files_if_it_does_not_already_exist generate mailer layout files if it does not already exist | ||||
| * | | generate mailer layout files if it does not already exist | yuuji.yaginuma | 2016-05-15 | 5 | -0/+44 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, if `ApplicationMailer` does not exist, it is generated when run the mailer generator, but layouts files does not generate. However, because it uses the layouts in `ApplicationMailer`, layouts are required. Follow up to #24161 | ||||
* | | | Merge pull request #25366 from prathamesh-sonpatki/update-release-notes-2 | Rafael França | 2016-06-11 | 1 | -1/+19 |
|\ \ \ | | | | | | | | | Add missing things to Rails 5.0 release notes [ci skip] | ||||
| * | | | Add missing things to Rails 5.0 release notes [ci skip] | Prathamesh Sonpatki | 2016-06-11 | 1 | -1/+19 |
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | - https://github.com/rails/rails/pull/18288. - https://github.com/rails/rails/commit/da9038e. - https://github.com/rails/rails/commit/78dab2a8569408658542e462a957ea5a35aa4679. - https://github.com/rails/rails/pull/9065. - https://github.com/rails/rails/pull/18314. - https://github.com/rails/rails/pull/13434. | ||||
* | | | Merge pull request #25367 from ↵ | Rafael França | 2016-06-11 | 2 | -1/+26 |
|\ \ \ | | | | | | | | | | | | | | | | | stephenminded/active_job_test_helper_custom_queue_adapter Provide the ability to override the queue adapter used by jobs under test | ||||
| * | | | Provide the ability to override the queue adapter used by jobs under | Steve Lounsbury | 2016-06-11 | 2 | -1/+26 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | test. This PR adds a method called `queue_adapter_for_test` to `ActiveJob::TestHelper`. This method is expected to provide the queue adapter to be used for jobs under test. It maintains the current behaviour by defaulting to an instance of `ActiveJob::QueueAdapter::TestAdapter`. Tests that include `ActiveJob::TestHelper` or extend from `ActiveJob::TestCase` can provide a custom queue adapter by overriding `queue_adapter_for_test` in their class. | ||||
* | | | | Merge pull request #25368 from frodsan/patch-1 | Rafael França | 2016-06-11 | 1 | -1/+1 |
|\ \ \ \ | |/ / / |/| | | | Fix typo | ||||
| * | | | Fix typo | Francesco Rodriguez | 2016-06-12 | 1 | -1/+1 |
|/ / / | | | | | | | [ci skip] | ||||
* | | | Merge pull request #25363 from kamipo/fix_or_result_sql | Vipul A M | 2016-06-11 | 1 | -1/+1 |
|\ \ \ | |/ / |/| | | Fix `or` result SQL [ci skip] | ||||
| * | | Fix `or` result SQL [ci skip] | Ryuta Kamizono | 2016-06-11 | 1 | -1/+1 |
|/ / | |||||
* | | Merge pull request #25361 from maclover7/jm-rm-stuff | Sean Griffin | 2016-06-10 | 1 | -11/+0 |
|\ \ | | | | | | | Remove `_run_class_setup` | ||||
| * | | Remove `_run_class_setup` | Jon Moss | 2016-06-10 | 1 | -11/+0 |
| | | | | | | | | | | | | Should have been removed by 3073c531983de243219fb55be93fbcebfdd9c44e. | ||||
* | | | Merge pull request #25321 from prathamesh-sonpatki/update-release-notes-1 | Rafael França | 2016-06-10 | 1 | -10/+33 |
|\ \ \ | |/ / |/| | | Add missing things to release notes [ci skip] | ||||
| * | | Add missing things to release notes [ci skip] | Prathamesh Sonpatki | 2016-06-07 | 1 | -10/+33 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - https://github.com/rails/rails/pull/18721 - https://github.com/rails/rails/pull/11898 - https://github.com/rails/rails/pull/18194 - https://github.com/rails/rails/pull/18225 - https://github.com/rails/rails/pull/18244 - https://github.com/rails/rails/commit/edc2b7718725016e988089b5fb6d6fb9d6e16882 - https://github.com/rails/rails/pull/19686 | ||||
* | | | Make sure the yielded variable is the logger | Rafael Mendonça França | 2016-06-10 | 2 | -4/+6 |
| | | | |||||
* | | | Merge pull request #25351 from kmcphillips/asset-default-config-quiet | Rafael França | 2016-06-10 | 1 | -0/+3 |
|\ \ \ | | | | | | | | | Add config.assets.quiet = true as default for generator | ||||
| * | | | Add config.assets.quiet = true as default value | Kevin McPhillips | 2016-06-10 | 1 | -0/+3 |
| | | | | |||||
* | | | | Merge pull request #25341 from kmcphillips/master | Rafael França | 2016-06-10 | 3 | -34/+124 |
|\ \ \ \ | | | | | | | | | | | Broadcast #silence on ActiveSupport::Logger | ||||
| * | | | | Be explicit about what Logger class is expected | Kevin McPhillips | 2016-06-09 | 1 | -3/+3 |
| | | | | | |||||
| * | | | | Broadcast #silence on logger. Rewrite tests. | Kevin McPhillips | 2016-06-09 | 2 | -31/+121 |
| | | | | | |||||
* | | | | | Merge pull request #25352 from Shopify/optimized-delegate | Rafael França | 2016-06-10 | 1 | -2/+2 |
|\ \ \ \ \ | | | | | | | | | | | | | Replace Kernel#caller by the faster Kernel#caller_locations | ||||
| * | | | | | Replace Kernel#caller by the faster Kernel#caller_locations | Jean Boussier | 2016-06-10 | 1 | -2/+2 |
| | |/ / / | |/| | | | |||||
* | | | | | Merge pull request #25342 from Edouard-chin/callbacks-wrong-method-name | Vipul A M | 2016-06-10 | 1 | -1/+6 |
|\ \ \ \ \ | |/ / / / |/| | | | | [ci skip] `define_model_callbacks` only exist in active model | ||||
| * | | | | [ci skip] `define_model_callbacks` only exist in active model: | Edouard CHIN | 2016-06-10 | 1 | -1/+6 |
| |/ / / | | | | | | | | | | | | | - Also added a note when calling multiple time `define_callbacks` | ||||
* | | | | Merge pull request #25348 from alexcameron89/master | Jon Moss | 2016-06-10 | 1 | -1/+1 |
|\ \ \ \ | |/ / / |/| | | | Fix typo in ActionController::Renderer [ci skip] | ||||
| * | | | Fix typo in ActionController::Renderer [ci skip] | Alex Kitchens | 2016-06-10 | 1 | -1/+1 |
|/ / / | |||||
* | | | Merge pull request #25338 from jwworth/fix_typo_sucker_punch_1465507047 | Jon Moss | 2016-06-09 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | Fix Typo in `SuckerPunchAdapter` | ||||
| * | | | Fix typo, `of of` -> `of` [ci skip] | Jake Worth | 2016-06-09 | 1 | -1/+1 |
|/ / / | |||||
* | | | Remove dead code from tests | Sean Griffin | 2016-06-09 | 1 | -17/+0 |
| | | | | | | | | | | | | | | | This code was added in 81286f858770e0b95e15af37f19156b044ec6a95, but was not used by that commit and does not appear to have ever been used. | ||||
* | | | render_to_string Regression Outside of Real Requests in Rails 5.0.0.rc1 (#25308) | Brandon Medenwald | 2016-06-09 | 2 | -1/+8 |
| | | | | | | | | | | | | | | | | | | * Restore the functionality of PR#14129, but do so with not nil to better indicate the purpose of the conditional * Add a test when render_to_string called on ActionController::Base.new() | ||||
* | | | Merge pull request #25329 from ↵ | Sean Griffin | 2016-06-09 | 1 | -1/+1 |
|\ \ \ | | | | | | | | | | | | | | | | | yahonda/allow_oracle_bind_value_syntax_in_loj_test Allow Oracle bind parameter syntax `:a1` in test_join_conditions_added_to_join_clause | ||||
| * | | | Allow Oracle bind parameter syntax `:a1` | Yasuo Honda | 2016-06-08 | 1 | -1/+1 |
| | | | | |||||
* | | | | Merge pull request #25334 from abhishekjain16/doc_fix | Sean Griffin | 2016-06-09 | 1 | -2/+2 |
|\ \ \ \ | | | | | | | | | | | Fix typo | ||||
| * | | | | Fix typo | Abhishek Jain | 2016-06-09 | 1 | -2/+2 |
| | | | | | |||||
* | | | | | Merge pull request #25335 from y-yagi/remove_deprecated_prefix_option | Vipul A M | 2016-06-08 | 1 | -2/+0 |
|\ \ \ \ \ | | | | | | | | | | | | | remove deprecated `:prefix` option from doc [ci skip] | ||||
| * | | | | | remove deprecated `:prefix` option from doc [ci skip] | yuuji.yaginuma | 2016-06-09 | 1 | -2/+0 |
| | |_|/ / | |/| | | | | | | | | | | | | | The option was deprecated in #21191. | ||||
* | | | | | Merge pull request #25332 from abhishekjain16/test_fix | Rafael França | 2016-06-09 | 2 | -3/+3 |
|\ \ \ \ \ | |_|/ / / |/| | | | | existant => existent | ||||
| * | | | | existant => existent | Abhishek Jain | 2016-06-09 | 2 | -3/+3 |
|/ / / / | |||||
* | | | | Merge pull request #25315 from schneems/schneems/inclusion-doc | Richard Schneeman | 2016-06-08 | 1 | -3/+9 |
|\ \ \ \ | | | | | | | | | | | [ci skip] Expand information on message options | ||||
| * | | | | [ci skip] Expand information on message options | schneems | 2016-06-08 | 1 | -3/+9 |
| | | | | | | | | | | | | | | | | | | | | Link to the more detailed message documentation when using a message option in validations. | ||||
* | | | | | Merge pull request #25327 from prathamesh-sonpatki/add-5-0-notes-to-the-index | Xavier Noria | 2016-06-08 | 1 | -0/+5 |
|\ \ \ \ \ | |_|_|/ / |/| | | | | Add Rails 5.0 release notes to the index page of guides [ci skip] | ||||
| * | | | | Add Rails 5.0 release notes to the index page of guides [ci skip] | Prathamesh Sonpatki | 2016-06-08 | 1 | -0/+5 |
| | |/ / | |/| | | | | | | | | | | - It is also marked as WIP as we are still refining it. | ||||
* | | | | Merge pull request #25323 from vipulnsward/ac-release-notes | David Heinemeier Hansson | 2016-06-08 | 1 | -2/+13 |
|\ \ \ \ | | | | | | | | | | | Add Action Cable introduction to release notes | ||||
| * | | | | Add Action Cable introduction to release notes [ci skip] | Vipul A M | 2016-06-07 | 1 | -2/+13 |
| | | | | |