| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
methyl/fix-includes-for-groupped-association"
This reverts commit 537ac7d6ade61e95f2b70685ff2236b7de965bab, reversing
changes made to 9c9c54abe08d86967efd3dcac1d65158a0ff74ea.
Reason:
The way we preload associations will change the meaning of GROUP BY
operations. This is illustrated in the SQL generated by the added
test (failing on PG):
Association Load:
D, [2015-12-21T12:26:07.169920 #26969] DEBUG -- : Post Load (0.7ms) SELECT "posts".* FROM "posts" LEFT JOIN comments ON comments.post_id = posts.id WHERE "posts"."author_id" = $1 GROUP BY posts.id ORDER BY SUM(comments.tags_count) [["author_id", 1]]
Preload:
D, [2015-12-21T12:26:07.128305 #26969] DEBUG -- : Post Load (1.3ms) SELECT "posts".* FROM "posts" LEFT JOIN comments ON comments.post_id = posts.id WHERE "posts"."author_id" IN (1, 2, 3) GROUP BY posts.id ORDER BY SUM(comments.tags_count)
|
|\
| |
| | |
[ci skip] `rails new project` generates README.md now
|
| | |
|
|\ \
| | |
| | | |
No more no changes entries in the CHANGELOGs [ci skip]
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
During the `5.0.0.beta1` release, the CHANGELOGs got an entry like the
following:
```
* No changes.
```
It is kinda confusing as there are indeed changes after it. Not a
biggie, just a small pass over the CHANGELOGs.
[ci skip]
|
|\ \
| |/
|/|
| |
| |
| | |
[ci skip]
Change output timming of sample code
|
| |
| |
| |
| | |
- Expect returns "new value 1" but, retuns nil, because output at thread is not finished. Move val_1 output to finished thread.
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Pass group values when including association
Conflicts:
activerecord/CHANGELOG.md
|
| | |
| | |
| | |
| | |
| | | |
Fixes problem when added `group()` in association scope was lost
in eager loaded association.
|
|\ \ \
| | | |
| | | | |
Fix documentation for mattr_accessor methods [ci skip]
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Update README extension in Getting Started guide
|
|/ / / /
| | | |
| | | | |
Generated Rails app READMEs are Markdown as of 9739f07d763e29b1c5d71cabf1ca8cfa4421e653
|
|\ \ \ \
| | | | |
| | | | | |
Add missing @claudiob credit to change log [skip ci]
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Remove legacy mysql adapter
|
|/ / / /
| | | |
| | | |
| | | | |
Follow up to #22642.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
jonatack/add-missing-period-in-upgrading-rails-guide
Upgrade Guide: Add missing period, :scissors: whitespace [skip ci]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
mysql2 adapter instead of mysql [ci skip]
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
Suppress warning ambiguous first argument
|
| |/ / /
| | | |
| | | |
| | | |
| | | | |
Suppress warning (warning: ambiguous first argument; put
parentheses or a space even after `/' operator)
|
|\ \ \ \
| |/ / /
|/| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
```
Every time when a fixture generate, it’s also generating improper doc.
one: {}
# column: value
#
two: {}
# column: value
```
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It is in the code to provides backward compatibility for people that
have this class serialized as YAML in some storage.
Closes #22681
|
|\ \ \ \
| | | | |
| | | | | |
Remove unused `test/schema/mysql_specific_schema.rb`
|
| | | | |
| | | | |
| | | | |
| | | | | |
Follow up to #22642.
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Update README.md
|
|/ / / / |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Also, added a test case to make sure that the default deprecation horizon is
always bigger than the current Rails version.
|
|\ \ \ \
| | | | |
| | | | | |
Remove .DS_Store
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Fix cache fetch miss notification order
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fixes https://github.com/rails/rails/issues/22477.
When I improved the caching instrumentation in
edd33c08d98723ae9bb89cf7f019277117ed6414, I inadvertently changed the
order of AS notifications when there is a cache miss.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
gwincr11/No-Doc-Rails__Generators__Actions__CreateMigration
Add No Doc
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In reference to rails/rail#22403 add a :nodoc:
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove blank line generated in config.ru
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Follow the lines of the other `.tt` files ([example](https://github.com/rails/rails/blob/1611ab4db173a7596a7a94c58dabf1483f070304/railties/lib/rails/generators/rails/app/templates/config/environments/development.rb.tt#L26)) that have the space after the
condition to avoid too many white lines in the resulted file.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
[ActionCable] declare asset_logged private
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| |_|/ / / / / /
|/| | | | | | | |
Explain what initializer/config_serializer does
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
In line with the other initializers, add a short comment that explains
what happens when you change the value of the initializer.
[ci skip]
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
initializers/cookies_serializer is not new to 5.0
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
[ci skip]
The initializer has existed since 4.1, for instance see:
https://github.com/rails/rails/blob/v4.1.0/railties/lib/rails/generators/rails/app/templates/config/initializers/cookies_serializer.rb
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
yuroyoro/fix_performance_regression_of_preloading_has_many_through_relation
Fix #12537 performance regression when preloading has_many_through association
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
For performance, Avoid instantiate CollectionProxy.
Fixes #12537
|
|\ \ \ \ \ \ \ \
| |_|/ / / / / /
|/| | | | | | | |
fix typo in config value [ci skip]
|