Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Add test to verify that the new :inverse_of association option will indeed ↵ | Wolfram Arnold | 2009-08-08 | 2 | -0/+60 | |
| | | | | | | | | fix the validation problem for a belongs_to relationship that validates_presence_of the parent, when both the parent and the child are new (in-memory) records. Also check that this works when the parents adds child via nested_attributes_for. Lastly, add a require 'models/pet' to association_validation_test.rb, so that test can be run independently (was failing due to that missing dependency). [#2815 status:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | |||||
* | Adds a :file delivery_method to save email to a file on disk | Eric Davis | 2009-08-08 | 3 | -1/+55 | |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#2438 state:committed] | |||||
* | Tidy up the AR tests, removing duplicates and making tests clearer / more ↵ | Josh Sharpe | 2009-08-08 | 1 | -46/+11 | |
| | | | | | | | | focussed. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#2774 state:committed] | |||||
* | Add option to routes task to target a specific controller with CONTROLLER=x. | Mike Breen | 2009-08-08 | 1 | -3/+4 | |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#2928 state:committed] | |||||
* | Default sent_on time to now in ActionMailer | Matt Duncan | 2009-08-08 | 2 | -2/+4 | |
| | | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> [#2607 state:committed] | |||||
* | Fix number_to_precision rounding error [#2071 state:resolved] | wmoxam | 2009-08-08 | 2 | -1/+2 | |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | |||||
* | Ruby 1.9 compat: fix route recognition encoding test | Jeremy Kemper | 2009-08-07 | 1 | -1/+1 | |
| | ||||||
* | Ruby 1.9.2: implicit argument passing of super from method defined by ↵ | Jeremy Kemper | 2009-08-07 | 1 | -3/+1 | |
| | | | | define_method() is not supported | |||||
* | Don't rely on T::U::TestCase#name | Jeremy Kemper | 2009-08-07 | 1 | -4/+5 | |
| | ||||||
* | Ruby 1.9.2: Object#id is gone now | Jeremy Kemper | 2009-08-07 | 1 | -1/+1 | |
| | ||||||
* | Ruby 1.9 compat: fix for SSL in Active Resource | Brendan Schwartz | 2009-08-07 | 1 | -1/+1 | |
| | | | | | | [#1272 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | |||||
* | Merge branch 'oracle_enhanced' | Jeremy Kemper | 2009-08-07 | 23 | -113/+335 | |
|\ | ||||||
| * | Some databases (e.g. Oracle) does not allow "AS" between table name and ↵ | Raimonds Simanovskis | 2009-08-06 | 1 | -1/+1 | |
| | | | | | | | | table alias name, for others it is optional | |||||
| * | fixed test_foreign_key_violations_are_translated_to_specific_exception to ↵ | Raimonds Simanovskis | 2009-08-06 | 1 | -1/+7 | |
| | | | | | | | | work with Oracle | |||||
| * | modifications to Oracle connection.rb setup | Raimonds Simanovskis | 2009-08-06 | 1 | -3/+17 | |
| | | ||||||
| * | fix schema_dumper_test for Oracle as it supports precision up to 38 | Raimonds Simanovskis | 2009-08-06 | 2 | -2/+12 | |
| | | ||||||
| * | changed default connection to localhost orcl database | Raimonds Simanovskis | 2009-08-06 | 1 | -3/+3 | |
| | | ||||||
| * | always sort lists by id before comparison to avoid errors because of ↵ | Raimonds Simanovskis | 2009-08-06 | 1 | -1/+2 | |
| | | | | | | | | different sorting of same results (on Oracle database) | |||||
| * | support for assert_queries when using Oracle adapter | Raimonds Simanovskis | 2009-08-06 | 1 | -4/+20 | |
| | | | | | | | | initialize $KCODE to UTF8 when JRuby is used | |||||
| * | added Subject#after_initialize to be the same as Topic#after_initialize | Raimonds Simanovskis | 2009-08-06 | 1 | -1/+9 | |
| | | ||||||
| * | Oracle can store integers with any :limit | Raimonds Simanovskis | 2009-08-06 | 1 | -0/+5 | |
| | | ||||||
| * | Oracle adapter recourns count() as numeric (not string) | Raimonds Simanovskis | 2009-08-06 | 1 | -1/+6 | |
| | | ||||||
| * | Oracle adapter gets Time or DateTime value already with timezone | Raimonds Simanovskis | 2009-08-06 | 1 | -17/+46 | |
| | | ||||||
| * | Oracle generates different ORDER BY fragment | Raimonds Simanovskis | 2009-08-06 | 1 | -1/+2 | |
| | | ||||||
| * | Oracle adapter returns Time value for DATE columns | Raimonds Simanovskis | 2009-08-06 | 1 | -2/+12 | |
| | | ||||||
| * | added :order to find :all as otherwise Oracle tests were failing | Raimonds Simanovskis | 2009-08-06 | 1 | -1/+2 | |
| | | ||||||
| * | Oracle needs sequence value for primary key in INSERT statement | Raimonds Simanovskis | 2009-08-06 | 1 | -1/+8 | |
| | | ||||||
| * | Oracle adapter returns numeric (not string) value after SUM | Raimonds Simanovskis | 2009-08-06 | 1 | -1/+6 | |
| | | ||||||
| * | Oracle saves empty string as NULL | Raimonds Simanovskis | 2009-08-06 | 1 | -10/+36 | |
| | | ||||||
| * | 1=2 is invalid expression in Oracle SELECT | Raimonds Simanovskis | 2009-08-06 | 1 | -2/+12 | |
| | | ||||||
| * | added :order option to find :first methods and associations as otherwise ↵ | Raimonds Simanovskis | 2009-08-06 | 6 | -48/+69 | |
| | | | | | | | | | | | | | | | | Oracle tests were failing Oracle stores '' string as NULL Oracle cannot have identifiers larger than 30 characters added missing fixtures to test setup method | |||||
| * | added additional objects necessary for OracleAdapter specific tests | Raimonds Simanovskis | 2009-08-06 | 2 | -3/+48 | |
| | | | | | | | | | | if OracleAdapter is used then use VARCHAR2(4000) instead of CLOB datatype as CLOB data type has many limitations in Oracle SELECT WHERE clause which causes many unit test failures | |||||
| * | modified native_oracle/connection.rb to run it with oracle_enhanced adapter | Raimonds Simanovskis | 2009-08-06 | 1 | -7/+18 | |
| | | ||||||
| * | Fixed adapter test cases that were failing in oracle because the asserts ↵ | Rob Christie | 2009-08-06 | 1 | -13/+4 | |
| | | | | | | | | were looking for the presence of offset and limit which are not available in oracle. Changed the tests to check that the sql injection is not present in the output so that the tests are database adapter agnostic. | |||||
* | | Rename find_by_parts and find_by_parts? to find and exists? | Yehuda Katz | 2009-08-07 | 12 | -20/+20 | |
| | | ||||||
* | | Allow rails templates relative to the current path to be given. | José Valim | 2009-08-07 | 4 | -4/+25 | |
| | | ||||||
* | | Renamed presenter to renderer, added some documentation and defined its API. | José Valim | 2009-08-07 | 18 | -241/+294 | |
| | | ||||||
* | | Encapsulate respond_with behavior in a presenter. | José Valim | 2009-08-07 | 2 | -212/+183 | |
| | | ||||||
* | | Add destroyed? to ActiveRecord, include tests for polymorphic urls for ↵ | José Valim | 2009-08-07 | 8 | -76/+133 | |
| | | | | | | | | destroyed objects and refactor mime responds tests and documentation. | |||||
* | | Add nagivational behavior to respond_with. | José Valim | 2009-08-07 | 9 | -78/+215 | |
| | | ||||||
* | | Updated vendored thor to 0.11.5 | José Valim | 2009-08-07 | 36 | -354/+312 | |
| | | ||||||
* | | Merge branch 'master' of git://github.com/rails/rails into old | José Valim | 2009-08-07 | 4 | -14/+23 | |
|\ \ | ||||||
| * | | Get all ActionController partial rendering to use ActionView's partial code. ↵ | Yehuda Katz | 2009-08-07 | 4 | -14/+23 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Consequences: * It is not possible to always pre-determine the layout before going to ActionView. This was *already* broken for render :partial => @object, :layout => true. This is now handled by overriding render_to_body in layouts.rb and manually injecting the partial's response. This needs to be done in ActionController since ActionController knows enough to get _layout_for_option. There is probably a better abstraction here. * As a result, all partial rendering can correctly restrict their layouts to the mime type of the rendered partial. This could have previously caused a bug in some edge cases. * If other layout-like options are added, they might need to add special code for the case of render :partial. We should try to think of an alternate solution, if possible, but this works for the cases we know of now. | |||||
* | | | Merge branch 'master' of git://github.com/rails/rails into old | José Valim | 2009-08-07 | 96 | -756/+1001 | |
|\| | | ||||||
| * | | Whitespace | Yehuda Katz | 2009-08-07 | 1 | -7/+7 | |
| | | | ||||||
| * | | Continue reworking the partial path. | Yehuda Katz | 2009-08-07 | 2 | -47/+22 | |
| | | | | | | | | | | | | * TODO: Review ActionController calling render_template for certain partials. Might we be able to save logic by always delegating to AV's render_partial? | |||||
| * | | Modify various partial methods to carry along the block that can be passed ↵ | Yehuda Katz | 2009-08-07 | 3 | -44/+54 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in with render * _render_single_template, which renders a template without layout * _render_partial_unknown_type, which renders a partial of unknown type (the entry method for most partial rendering; supports strings, objects, and collections) * _render_partial_object, which renders a partial for a single object. * extracted _render_partial_path so it can be used to render the spacer without going through the public render :partial | |||||
| * | | Some more AV work: | Yehuda Katz | 2009-08-07 | 2 | -26/+25 | |
| | | | | | | | | | | | | | | | | | | | | | | | | * rename _render_partial to _render_partial_unknown_type to reflect that for this call, we don't know the type. * Merge _render_partial_with_block and _render_partial_with_layout to _render_partial * TODO: Check to see if any more logic can be shared * TODO: See about streamlining block path so we can get rid of @_proc_for_layout * Remove @exempt_from_layout as it is no longer needed | |||||
| * | | Replace _render_template_with_layout with _render_template since the layout ↵ | Yehuda Katz | 2009-08-07 | 7 | -21/+29 | |
| | | | | | | | | | | | | is optional | |||||
| * | | Some more AV refactoring: | Yehuda Katz | 2009-08-07 | 2 | -15/+6 | |
| | | | | | | | | | | | | | | | * remove no longer used _array_like_objects * _render_content_with_layout renamed to _render_content since layout it optional * remove check for optional layout before _render_content |