aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Use `inspect` in `type_cast_for_schema` for date/time and decimal valuesRyuta Kamizono2016-12-114-9/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently dumping defaults on schema is inconsistent. Before: ```ruby create_table "defaults", force: :cascade do |t| t.string "string_with_default", default: "Hello!" t.date "date_with_default", default: '2014-06-05' t.datetime "datetime_with_default", default: '2014-06-05 07:17:04' t.time "time_with_default", default: '2000-01-01 07:17:04' t.decimal "decimal_with_default", default: 1234567890 end ``` After: ```ruby create_table "defaults", force: :cascade do |t| t.string "string_with_default", default: "Hello!" t.date "date_with_default", default: "2014-06-05" t.datetime "datetime_with_default", default: "2014-06-05 07:17:04" t.time "time_with_default", default: "2000-01-01 07:17:04" t.decimal "decimal_with_default", default: "1234567890" end ```
* Merge pull request #27323 from kamipo/add_changelog_for_25227Matthew Draper2016-12-111-0/+4
|\ | | | | Add a changelog entry for #25227 [ci skip]
| * Add a changelog entry for #25227 [ci skip]Ryuta Kamizono2016-12-101-0/+4
| |
* | Merge pull request #27322 from kamipo/fix_ci_failureMatthew Draper2016-12-112-2/+2
|\ \ | |/ |/| Fix CI failure caused by #25227 and #25280 were merged at the same time
| * Fix CI failure caused by #25227 and #25280 were merged at the same timeRyuta Kamizono2016-12-102-2/+2
|/
* Merge pull request #25280 from ↵Sean Griffin2016-12-102-0/+16
|\ | | | | | | | | kamipo/prevent_range_error_for_belongs_to_associations Prevent `RangeError` for `belongs_to` associations
| * Prevent `RangeError` for `belongs_to` associationsRyuta Kamizono2016-10-102-0/+16
| | | | | | | | | | | | | | | | Currently to access `belongs_to` associations raises a `RangeError` if foreign key attribute has out of range value. It should return a nil value rather than raising a `RangeError`. Fixes #20140.
* | Merge pull request #25227 from kamipo/numeric_value_out_of_rangeSean Griffin2016-12-107-8/+26
|\ \ | | | | | | Translate numeric value out of range to the specific exception
| * | Translate numeric value out of range to the specific exceptionRyuta Kamizono2016-12-067-8/+26
| | | | | | | | | | | | Raise `ActiveRecord::RangeError` when values that executed are out of range.
* | | Merge pull request #27320 from ↵Matthew Draper2016-12-101-1/+1
|\ \ \ | | | | | | | | | | | | | | | | y-yagi/run_webpack_command_only_when_webpack_option_is_specified run `webpack` command only when webpack option is specified
| * | | run `webpack` command only when webpack option is specifiedyuuji.yaginuma2016-12-101-1/+1
|/ / /
* | | gemfile entry method need to return an empty array rather than nil (#27318)Yuji Yaginuma2016-12-091-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following error when executing rails new command. ``` (erb):9:in `block in template': undefined method `comment' for nil:NilClass (NoMethodError) ``` Follow up to #27288
* | | Use GitHub webpacker until closer to releaseDavid Heinemeier Hansson2016-12-091-1/+1
| | |
* | | Basic --webpack delegation to new webpacker gem (#27288)David Heinemeier Hansson2016-12-092-1/+16
| | |
* | | Merge pull request #27314 from kamipo/add_changelog_for_25451Matthew Draper2016-12-101-8/+13
|\ \ \ | | | | | | | | Add a changelog entry for #25451 [ci skip]
| * | | Add a changelog entry for #25451 [ci skip]Ryuta Kamizono2016-12-101-8/+13
| | | |
* | | | Do not raise exception when content_type is a empty stringRafael Mendonça França2016-12-092-1/+6
|/ / / | | | | | | | | | | | | When content type header is blank we were raising an exception because `empty?` was being called on nil.
* | | Merge pull request #27248 from stefanmb/masterSean Griffin2016-12-094-5/+67
|\ \ \ | | | | | | | | Idempotent option for after_commit :destroy callback
| * | | Emulate db trigger behaviour for after_commit :destroy, :updateStefan Budeanu2016-12-094-5/+67
|/ / / | | | | | | | | | | | | | | | Race conditions can occur when an ActiveRecord is destroyed twice or destroyed and updated. The callbacks should only be triggered once, similar to a SQL database trigger.
* | | Show message if Yarn is not installed (#27312)Guillermo Iguaran2016-12-091-1/+8
| | |
* | | Merge pull request #27311 from y-yagi/remove_assert_sendKasper Timm Hansen2016-12-091-1/+0
|\ \ \ | | | | | | | | remove deprecated `assert_send` from assertion list [ci skip]
| * | | remove deprecated `assert_send` from assertion list [ci skip]yuuji.yaginuma2016-12-091-1/+0
|/ / / | | | | | | | | | | | | `assert_send` was deprecated in minitest 5.10.0. Ref: https://github.com/seattlerb/minitest/commit/f95ef007ec64d956d88fedc37fd2ed7e106b777e
* | | Only have Yarn bundling commented out as we cant be sure Yarn is installedDavid Heinemeier Hansson2016-12-082-5/+2
| | |
* | | Fix ability to run railties test suiteDavid Heinemeier Hansson2016-12-081-0/+1
| | |
* | | fix broken tests (#27308)Yuji Yaginuma2016-12-081-3/+2
| | | | | | | | | Follow up to 0d20530e5edfd7d00fbc2a38ef5f87eca6ccc924
* | | specify `skip_yarn` option in API-only Application (#27309)Yuji Yaginuma2016-12-082-3/+12
| | |
* | | Merge pull request #27303 from toshimaru/fix/partial-variable-blockMatthew Draper2016-12-094-5/+17
|\ \ \ | | | | | | | | Enable `block` variable in view
| * | | split DELEGATION_RESERVED_METHOD_NAMES in halfToshimaru2016-12-095-10/+17
| | | |
| * | | Enable `block` variable in viewToshimaru2016-12-093-1/+6
| | | | | | | | | | | | | | | | Remove `block` keyword from reserved method names
* | | | Resolve association class correctly when assigning ids on a through associationMatthew Draper2016-12-093-1/+12
| | | |
* | | | Make ActiveModel::Errors backward compatible with 4.2Rafael Mendonça França2016-12-082-2/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | If a Error object was serialized in the database as YAML in the Rails 4.2 version, if we load in the Rails 5.0 version it will miss the @details instance variable so methods like #clear and #add will start to fail.
* | | | Merge pull request #27304 from utilum/fix_test_breakerSean Griffin2016-12-081-0/+1
|\ \ \ \ | |/ / / |/| | | Fix test breaking error uninitialized constant ActiveRecord::Type::Value
| * | | Fix test breaking error uninitialized constant ActiveRecord::Type::Value.utilum2016-12-081-0/+1
|/ / /
* | | Merge pull request #25051 from bf4/extract_notes_as_binarySean Griffin2016-12-081-1/+1
|\ \ \ | | | | | | | | Extract notes as binary
| * | | Extract notes from files in binaryBenjamin Fleischer2016-09-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prevents: ArgumentError: invalid byte sequence in UTF-8 railties/lib/rails/source_annotation_extractor.rb:115:in `=~' railties/lib/rails/source_annotation_extractor.rb:115:in `block in extract_annotations_from' And there's no reason we need to interpret the files as UTF-8 when scanning for annotations. Applies to Rails 4.2 as well.
* | | | Merge pull request #26696 from iainbeeston/only-ruby-types-in-activemodelSean Griffin2016-12-0810-35/+33
|\ \ \ \ | | | | | | | | | | | | | | | Moved database-specific ActiveModel types into ActiveRecord
| * | | | Moved database-specific ActiveModel types into ActiveRecordIain Beeston2016-10-1410-34/+33
| | | | | | | | | | | | | | | | | | | | ie. DecimalWithoutScale, Text and UnsignedInteger
* | | | | Merge pull request #26529 from prathamesh-sonpatki/fix-alias-attribute-issueSean Griffin2016-12-084-3/+43
|\ \ \ \ \ | | | | | | | | | | | | Check whether the current attribute being read is aliased or not before reading
| * | | | | Check whether the current attribute being write is aliased or not before writingPrathamesh Sonpatki2016-12-093-2/+20
| | | | | | | | | | | | | | | | | | | | | | | | - If aliased, then use the aliased attribute name.
| * | | | | Check whether the current attribute being read is aliased or not before readingPrathamesh Sonpatki2016-12-083-2/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - If aliased, then use the aliased attribute name. - Fixes #26417.
* | | | | | Make Yarn the default, drop default vendor/asset directories (#27300)David Heinemeier Hansson2016-12-0811-111/+34
|/ / / / /
* | | | | Merge pull request #27278 from kamipo/should_be_sync_primary_key_definitionSean Griffin2016-12-081-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Should be sync the `primary_key` definition with actually created
| * | | | | Should be sync the `primary_key` definition with actually createdRyuta Kamizono2016-12-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Actually the `primary_key` definition is not used but the inconsistency is confusing. Actual definition is `bigint auto_increment PRIMARY KEY` so `UNSIGNED` and `(8)` is unnecessary. See also #21607.
* | | | | | Add some documentation around internal APIs [ci skip]Sean Griffin2016-12-081-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While these method aren't public API, they are a non-trivial internal API which warrant a bit of explanation.
* | | | | | Merge pull request #27185 from kamipo/fix_apply_seconds_precisionSean Griffin2016-12-081-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix `apply_seconds_precision` not to be affected by `mathn`
| * | | | | | Fix `apply_seconds_precision` not to be affected by `mathn`Ryuta Kamizono2016-11-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently `apply_seconds_precision` cannnot round usec when after `require 'mathn'`. ``` irb(main):001:0> 1234 / 1000 * 1000 => 1000 irb(main):002:0> 1234 - 1234 % 1000 => 1000 irb(main):003:0> require 'mathn' => true irb(main):004:0> 1234 / 1000 * 1000 => 1234 irb(main):005:0> 1234 - 1234 % 1000 => 1000 ```
* | | | | | | Merge pull request #27289 from matthewd/fixture-file-moduleMatthew Draper2016-12-082-18/+22
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Only move fixture_file_upload to IntegrationTest
| * | | | | | | Only move fixture_file_upload to IntegrationTestMatthew Draper2016-12-072-18/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The rest of the helpers are better placed on Session -- and this is the only one that cares which class it is defined on.
* | | | | | | | Merge pull request #27271 from printercu/permantent_digest_in_testsMatthew Draper2016-12-082-1/+9
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Don't clear digest cache in test environment
| * | | | | | | | Fixed usage of cache_template_loadingMax Melentiev2016-12-062-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It disables recompilation of templates on every request in test env.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-16 05:14:08 +0000