aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | Merge pull request #9345 from ↵Rafael Mendonça França2013-02-201-10/+10
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | wangjohn/change_name_of_query_method_argument_checker_for_clarity Renaming the check_empty_arguments method to something more descriptive.
| * | | | | Renaming the check_empty_arguments method to something more descriptive.wangjohn2013-02-201-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The function is now called has_arguments? so that it's easier to tell that it's just checking to see if the args are blank or not.
* | | | | | removes relation bang methods from the AR changelog [ci skip]Xavier Noria2013-02-201-12/+0
| | | | | |
* | | | | | removes some remaining relation bang methods documentation [ci skip]Xavier Noria2013-02-201-3/+0
| | | | | |
* | | | | | puts a lambda around a default scope [ci skip]Xavier Noria2013-02-201-1/+1
| | | | | |
* | | | | | adds an example in the docs of #not with multiple conditions [ci skip]Xavier Noria2013-02-201-4/+8
| | | | | |
* | | | | | database.yml -> config/database.yml [ci skip]Xavier Noria2013-02-201-1/+1
| | | | | |
* | | | | | Revert "Merge pull request #4803 from lucascaton/master"Santiago Pastorino2013-02-203-5/+3
| |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit bb842e8d2111e50b21a14b8bd6d89371a4b9cd68, reversing changes made to 40c287c7983c20c498f6a8a2ea49e9a6455347f7. This was causing issues in one of our apps we just upgraded. ActionController::RoutingError: No route matches [GET] "/images/favicon.ico" favicon_link_tag now returns '/images/favicon.ico' and in 3.2 returned '/favicon.ico' Browsers by default look for favicon.ico in the root directory Conflicts: actionpack/CHANGELOG.md actionpack/lib/action_view/helpers/asset_tag_helper.rb
* | | | | Skip failing test and add a FIXME noteRafael Mendonça França2013-02-201-0/+2
| | | | |
* | | | | Merge pull request #9344 from senny/changelog_cleanupRafael Mendonça França2013-02-201-4/+4
|\ \ \ \ \ | | | | | | | | | | | | unify AR changelog entries [ci skip]
| * | | | | unify AR changelog entries [ci skip]Yves Senn2013-02-201-4/+4
|/ / / / /
* | | | | Merge pull request #8645 from senny/rename_index_on_rename_columnRafael Mendonça França2013-02-207-8/+73
|\ \ \ \ \ | | | | | | | | | | | | also rename indexes when a table or column is renamed
| * | | | | also rename indexes when a table or column is renamedYves Senn2013-02-207-8/+73
|/ / / / / | | | | | | | | | | | | | | | When a table or a column is renamed related indexes kept their name. This will lead to confusing names. This patch renames related indexes when a column or a table is renamed. Only indexes with names generated by rails will be renamed. Indexes with custom names will not be renamed.
* | | | | moves the new :nsec date format to the Active Support changelog [ci skip]Xavier Noria2013-02-202-6/+5
| | | | |
* | | | | revises the documentation of AR::Base.cache_timestamp_format [ci skip]Xavier Noria2013-02-201-2/+4
|/ / / /
* | | | Merge pull request #8613 from senny/8264_character_limit_for_indicesRafael Mendonça França2013-02-206-14/+69
|\ \ \ \ | | | | | | | | | | deal with long index names and internal sqlite3 operations
| * | | | reserve less chars for internal sqlite3 operationsYves Senn2013-02-201-7/+7
| | | | |
| * | | | reserve index name chars for internal rails operationsYves Senn2013-02-206-9/+64
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some adapter (SQLite3) need to perform renaming operations to support the rails DDL. These rename prefixes operate with prefixes. When an index name already uses up the full space provieded by `index_name_length` these internal operations will fail. This patch introduces `allowed_index_name_length` which respects the amount of characters used for internal operations. It will always be <= `index_name_length` and every adapter can define how many characters need to be reserved.
* | | | Merge pull request #9332 from ↵Rafael Mendonça França2013-02-203-15/+45
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | wangjohn/adding_documentation_to_error_raising_in_query_methods Tests to make sure empty arguments in WhereChain raise errors
| * | | | Added comments about the check_empty_arguments method which is calledwangjohn2013-02-203-15/+45
| | | | | | | | | | | | | | | | | | | | | | | | | for query methods in a where_clause. Also, modified the CHANGELOG entry because it had false information and added tests.
* | | | | Merge pull request #9342 from hone/db_migrate_with_database_urlRafael Mendonça França2013-02-201-1/+1
|\ \ \ \ \ | | | | | | | | | | | | Fix ActiveRecord::ConnectionAdapters::ConnectionSpecification::ResolverTest
| * | | | | make type_cast_value a class level methodTerence Lee2013-02-211-1/+1
| |/ / / /
* | | | | Merge pull request #9068 from wangjohn/transaction_callback_patchRafael Mendonça França2013-02-206-6/+89
|\ \ \ \ \ | | | | | | | | | | | | Reduced memory leak problem in transactions by lazily updating AR objects
| * | | | | Reduced memory leak problem in transactions by lazily updating AR objects ↵wangjohn2013-02-206-6/+89
| |/ / / / | | | | | | | | | | | | | | | with new transaction state. If AR object has a callback, the callback will be performed immediately (non-lazily) so the transaction still has to keep records with callbacks.
* | | | | Merge pull request #9341 from senny/move_precompiled_asset_config_to_applicationRafael Mendonça França2013-02-203-6/+10
|\ \ \ \ \ | |/ / / / |/| | | | move config.assets.precompile into config/application.rb
| * | | | move config.assets.precompile into config/application.rbYves Senn2013-02-203-6/+10
| | | | |
* | | | | Merge pull request #9120 from hone/db_migrate_with_database_urlRafael Mendonça França2013-02-205-10/+24
|\ \ \ \ \ | |/ / / / |/| | | | fix rake db:migrate when used with ENV['DATABASE_URL']
| * | | | update changelogTerence Lee2013-02-211-0/+3
| | | | |
| * | | | run the load_structure test in the test environmentTerence Lee2013-02-211-3/+10
| | | | |
| * | | | test DATABASE_URL without database.yml aroundTerence Lee2013-02-211-0/+2
| | | | |
| * | | | standardize database_configuration to a hashTerence Lee2013-02-213-7/+9
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | make connection_url_to_hash a class method This als prevents loading database.yml if it doesn't exist but DATABASE_URL does
* | | | Merge pull request #9328 from sikachu/ps-remove-xml-parserGuillermo Iguaran2013-02-205-342/+31
|\ \ \ \ | | | | | | | | | | Remove XML Parser from ActionDispatch
| * | | | Remove XML Parser from ActionDispatchPrem Sichanugrist2013-02-205-342/+31
|/ / / / | | | | | | | | | | | | | | | | If you want an ability to parse XML parameters, please install `actionpack-xml_parser` gem.
* | | | Whitespace :heart: and hash syntax changeRafael Mendonça França2013-02-201-23/+22
| | | |
* | | | Merge pull request #8060 from ↵Xavier Noria2013-02-203-3/+20
|\ \ \ \ | |/ / / |/| | | | | | | | | | | senny/7313_descriptive_error_message_for_missing_adapter descriptive error message when AR adapter was not found. Closes #7313
| * | | descriptive error message when AR adapter was not found. Closes #7313.Yves Senn2013-02-203-3/+20
|/ / /
* | | Merge pull request #9330 from bdmac/time_zone_select_dupAndrew White2013-02-193-1/+16
|\ \ \ | | | | | | | | Fix time_zone_options_for_select to not mutate TimeZones array
| * | | Fix time_zone_options_for_select to not mutate TimeZones arrayBrian McManus2013-02-193-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previous implementation of time_zone_options_for_select did not dup the ActiveSupport::TimeZone.all array. When :priority_zones were provided the method would reject! the zones from the memoized TimeZones array thus affecting future requests to the server. Essentially whatever zones were specified as :priority_zones would show up for the first request but then disappear from the time zone options on future requests.
* | | | Merge pull request #9331 from robertomiranda/upgrading-guideGuillermo Iguaran2013-02-191-0/+10
|\ \ \ \ | |/ / / |/| | | Improve upgrading guide with ActionDispatch::BestStandardsSupport remova...
| * | | Improve upgrading guide with ActionDispatch::BestStandardsSupport removalrobertomiranda2013-02-191-0/+10
|/ / /
* | | Better not use tab chars in the generator templateAkira Matsuda2013-02-201-5/+5
| | |
* | | Merge pull request #9324 from acapilleri/add_on_emptySteve Klabnik2013-02-191-0/+7
|\ \ \ | | | | | | | | added more accurate test for add_on_empty
| * | | added more accurate test for add_on_emptyAngelo capilleri2013-02-191-0/+7
| | | | | | | | | | | | | | | | | | | | with the current tests, if delete the assignment of is_empty in add_on_empty method the tests not fail. With this test, if we delete is_empty, the test fails
* | | | s/revertible/reversible/Xavier Noria2013-02-191-1/+1
| | | |
* | | | fixes a typo in the migrations guideXavier Noria2013-02-191-1/+1
| | | |
* | | | Merge pull request #9315 from ↵Steve Klabnik2013-02-191-23/+0
|\ \ \ \ | |/ / / |/| | | | | | | | | | | Takehiro-Adachi/remove-unecessary-tests-from-ar-base_testrb delete duplicated tests in AR base_test.rb
| * | | delete duplicated tests in AR base_test.rbTakehiro Adachi2013-02-191-23/+0
| | | | | | | | | | | | | | | | These are duplicated with the tests which are in relations_test.rb
* | | | moves a CHANGELOG entry from AR to APXavier Noria2013-02-192-4/+4
| | | |
* | | | small tweaks in the AR CHANGELOGXavier Noria2013-02-191-4/+4
| | | |
* | | | Merge pull request #9258 from wangjohn/blank_argument_errors_in_arelRafael Mendonça França2013-02-192-9/+34
|\ \ \ \ | | | | | | | | | | Raising an error when query methods have blank arguments.
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-22 16:36:21 +0000