| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | | | |
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
This fixes issue #10066
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove code duplication
|
| | |/ / / /
| |/| | | | |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
wangjohn/moving_check_for_test_environment_into_rails_env
Moved the check for the rails test environment into rails.rb
Closes #10238
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
can select frameworks separately when running rake test.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Trying to lookup the parent class when the association is being built
runs the risk of generating uninitialized constant errors because
classes haven't been fully defined yet. To work around this we look up
the class at runtime through the `association` method.
Fixes #10197.
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
when transitioning to new association" until a proper fix is found for #10197"
This reverts commit 7389df139a35436f00876c96d20e81ba23c93f0a.
Conflicts:
activerecord/test/cases/timestamp_test.rb
|
|\ \ \ \ \
| | | | | |
| | | | | | |
fixed missing comma in example
|
|/ / / / / |
|
|/ / / / |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
transitioning to new association" until a proper fix is found for #10197
|
|\ \ \ \
| | | | |
| | | | | |
ActiveRecord having clause bug fix
|
| | | | |
| | | | |
| | | | |
| | | | | |
should be empty.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
refactor initialization of array
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The changes in b79adc4323 had a bug where if the time in the String
was in standard time but the current time was in daylight savings then
the calculated adjustment was off by an hour.
This commit fixes this and adds extra tests for the following:
* time in string is standard time, current time is standard time
* time in string is standard time, current time is daylight savings
* time in string is daylight savings, current time is standard time
* time in string is daylight savings, current time is daylight savings
Fixes #10306.
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
extract arrays to constants in Mapper
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove redundant variable
|
| |/ / / / |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Use MethodNotAllowed exception rather than UnknownHttpMethod
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Created a registry for ActiveSupport::Subscriber queues
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
subscriber queues. Helps limit the number of thread locals.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Also assign nil in dirty nullable_datetime test. Closes #10237
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Update counter cache when pushing into association
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This commit fixes a regression bug in which counter_cache columns
were not being updated correctly when newly created records were
being pushed into an assocation. EG:
# this was fine
@post.comment.create!
# this was fine
@comment = Comment.first
@post.comments << @comment
# this would not update counters
@post.comments << Comment.create!
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
extract no content response codes to a constant
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Fixes skipping object callback filters
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This allows you to skip callbacks that are defined by objects, e.g. for
`ActionController`:
skip_after_filter MySpecialFilter
Previously this didn't work due to a bug in how Rails compared callbacks
in `Callback#matches?`. When a callback is compiled, if it's an object
filter (i.e. not a method, proc, etc.), `Callback` now defines a method on
`@klass` that is derived from the class name rather than `@callback_id`.
So, when `skip_callback` tries to find the appropriate callback to
remove, `Callback` can regenerate the method name for the filter
object and return the correct value for `Callback#matches?`.
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
extract array to a constant
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Extract path into variable
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
fix README links in the main README.md
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
neerajdotname/fix-wrong-test-name-and-failure-message
fix wrong test description and failure message
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Added tests for if condition in Active Model callbacks
|
| |/ / / / / |
|