| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|
|
| |
... 'shared' OID, ArrayParser and Cast helpers, also re-arranged Column's dependencies
|
|\
| |
| | |
Refactor delete_records method
|
| |
| |
| |
| | |
this change was unneccsary as nothing was gained from it
|
| |
| |
| |
| |
| |
| |
| | |
Rename delete_all_records because this name better describes
what the method is doing. We can then remove :all from the
hm:t version and pull out the unoptimized call to load_target
in delete_records and pass it directly.
|
| |
| |
| |
| |
| |
| | |
Refactor delete_count method to only handle delete_all or nullify/nil cases
and not destroy and switch to if/else rather than case statement. This
refactoring allows removal of :all symbol usage.
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor by creating two methods delete_all_records and delete_records
to be called by delete_all and delete (or destroy) respectively.
This reduces the number of conditionals required to handle _how_
records get deleted.
The new delete_count method handles how scope is applied to which
delete action.
A delete_all_records method also has to be called in has_many_through
association because of how the methods are chained. This will be
refactored later on.
|
|\
| |
| |
| |
| | |
eileencodes/remove-deprecation-warning-no-longer-needed
remove deprecation warning
|
| |
| |
| |
| |
| | |
This deprecation was released in 4.1.0 and can be removed for 4.2.0,
deprecation message / handling is no longer necessary.
|
| |
| |
| |
| | |
Then we can avoid nil checks
|
|/ |
|
| |
|
| |
|
|
|
|
| |
no need for redefine_method
|
| |
|
| |
|
|\
| |
| | |
[postgres] include PgArrayParser directly
|
| |
| |
| |
| | |
if not found
|
|\ \
| | |
| | | |
[ci skip] Fix two factual errors and highlight code in generators guide.
|
| | | |
|
|\ \ \
| | | |
| | | | |
[Fixes #15064] Calling number_to_delimited on a ActiveSupport::SafeBuffer results in mangled output
|
| | | |
| | | |
| | | |
| | | | |
rather than use non-public SafeBuffer API.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
`ActiveSupport::SafeBuffer` values aren't mangled.
Fixes #15064
|
|\ \ \ \
| | | | |
| | | | | |
Update and add tests in array_ext_test.rb
|
| | | | |
| | | | |
| | | | |
| | | | | |
Removed `FIMXE` tag to require necessary file but not the whole core_ext
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Fix `test_to_with_instruct` typo to `test_to_xml_with_instruct`
- Rename `test_to_xml` to `test_to_xml_with_hash_elements` to make test
name more specific.
- Add `test_to_xml_with_non_hash_elements` and
`test_to_xml_with_non_hash_different_type_elements`
`to_xml` behaves different when containing elements are same and
different types.
- Add `test_to_xml_with_indent_set`
|
| | | | | |
|
|\ \ \ \ \
| |_|_|/ /
|/| | | | |
Remove falsy deprecation note in AS guides [ci skip]
|
| | | | |
| | | | |
| | | | | |
This is no longer true as @jeremy removed the deprecation in 7a5601c.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Do not check defined?(CGI) on every call #to_query
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Dup options hash to prevent modifications
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`options[:default]` and `options[:raise]` can be mistakenly added to the `options` hash. This can be a problem if you're reusing the same object.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
* by default composite types are mapped as `OID::Identity` and issue a warning
* the user is advised to register his own `OID::Type` to make use of composite types
Registering a new `OID::Type` does currently not allow to specify the type casting
behavior when writing to the database. In order for it to work we need to use the
values within `@attributes`. They are already being type casted and are ready to be
written to the DB.
See https://github.com/rails/rails/blob/57643c961feb24b662620d330e71103a830003e8/activerecord/lib/active_record/attribute_methods.rb#L460-L462
|
| |/ / / /
|/| | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
It's usage has been removed in 325c9d5e5235db4b5210d9db6c863835d1ac7eed.
|
| |_|_|/
|/| | | |
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Fix regression on `assert_redirected_to`.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`assert_redirected_to` would fail if there is no controller set on
a `ActionDispatch::IntegrationTest`, as _compute_redirect_to_location
would be called on the controller to build the url.
This regression was introduced after 1dacfbabf3bb1e0a9057dd2a016b1804e7fa38c0.
[fixes #14691]
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
zuhao/refactor_actionmailer_i18n_with_controller_test
Use with_translation helper to clean up I18n stored translations.
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Clean up deliveries after each test.
|
| | | | | | |
|