| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Remove `cast_type` in `ColumnDefinition`
|
| | |_|/ / / /
| |/| | | | |
| | | | | | |
| | | | | | | |
This is no longer needed.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
/cc @zzak
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
andreynering/add-foreign-key-subsection-in-upgrading-guide
Adding subsection on 'Upgrading' guide about foreign key support
[ci skip]
|
| | | | | | | | |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Fix some typos in railties/lib/rails/engine.rb [ci-skip]
|
|/ / / / / / / / |
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Fix typo in Rails::Application#migration_railties documentation [ci-skip]
|
|/ / / / / / / / |
|
|\ \ \ \ \ \ \ \
| |_|/ / / / / /
|/| | | | | | | |
Use keyword argument in `transaction`
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The keys are already validated, so it is better to use the built-in
feature to do this.
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
Fix wrong kwarg "record" from #18872
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
PR #18772 changed the parameters of `stale?` to use `kwargs`.
[As for this comment](https://github.com/rails/rails/pull/18872/files#r24456288)
the default value for the `etag` parameter should be `record`, not `nil`.
This commit fixes the code and introduces a test that:
- passed before #18872
- fails on the current master (after #18772)
- passes again after setting the default value of `etag` to `record`.
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
Convert stale? and fresh_when to use keyword arguments.
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Like for real this time. I checked.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fixed typos in ActiveRecord CHANGELOG [ci skip]
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Add an option `end` to `find_in_batches`
|
| | |_|_|_|_|/
| |/| | | | |
| | | | | | |
| | | | | | | |
that complements the `start`parameter to specify where to stop batch processing
|
| |/ / / / /
|/| | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The various databases don't actually need significantly different
handling for this behavior, and they can achieve it without knowing
about the type of the object.
The old implementation was returning a string, which will cause problems
such as breaking TZ aware attributes, and making it impossible for the
adapters to supply their logic for time objects.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
alex-handley/enhancement/dependent_documentation_fix
Documentation Fix: Corrects explanation of what happens when dependent is not set
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
By default the foreign key will remain set with the parent id after
destroy is fired.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Fixes #18871
|
|\ \ \ \ \ \ \
| |_|_|/ / / /
|/| | | | | | |
Document lazy lookup behavior for controllers [ci skip]
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Pull request #7082 added lazy lookup to controllers using the translate
method, but the documentation still stated that it was available for
views only.
[ci skip]
|
| |_|_|/ / /
|/| | | | |
| | | | | |
| | | | | | |
Significantly faster than `SimpleDelegator`.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove warning from ActionView::Helpers::Tags::Translator
|
| | |_|/ / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This removes the following warning:
/GitHub/rails/actionview/lib/action_view/helpers/tags/translator.rb:19: warning: private attribute?
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
An array type is a part of `sql_type`
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`sql_type` is reused in `lookup_cast_type`. If making it a part of
`sql_type` when handled array option first, it isn't necessary to do
again.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
The default of the global might change. It's better to reset it to
what it was than a hardcoded value.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
yuki24/remove-warning-from-generators-named-base-test
Remove warning from generator named base test
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This removes the following warning:
railties/test/generators/named_base_test.rb:9: warning: method redefined; discarding old pluralize_table_names
activesupport/lib/active_support/core_ext/class/attribute.rb:86: warning: previous definition of pluralize_table_names was here
railties/test/generators/named_base_test.rb:9: warning: method redefined; discarding old pluralize_table_names=
activesupport/lib/active_support/core_ext/class/attribute.rb:83: warning: previous definition of pluralize_table_names= was here
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Remove warning from Plugin Generator
|
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This removes the following warning:
rails/railties/lib/rails/generators/rails/plugin/plugin_generator.rb:321: warning: shadowing outer local variable - content
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Explicitly ignored wildcard verbs from head_routes
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
In match_head_routes, deleted the routes in which request.request_method was empty (matches all HTTP verbs) when responding to a HEAD request. This prevents catch-all routes (such as Racks) from intercepting the HEAD request.
Fixes #18698
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Added by 101c19f55f5f1d86d35574b805278f11e9a1a48e.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
kamipo/fix_rounding_problem_for_postgresql_timestamp_column
Fix rounding problem for PostgreSQL timestamp column
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | | |
If timestamp column have the precision, it need to format according to
the precision of timestamp column.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Respect the database default charset for `schema_migrations` table.
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The charset of `version` column in `schema_migrations` table is depend
on the database default charset and collation rather than the encoding
of the connection.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add `auto_increment?` instead of `extra == 'auto_increment'`
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove unused line
|
| |/ / / / |
|