aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Let Ruby deal with method visibility.Jon Leighton2011-09-134-23/+60
| | | | | | Check respond_to_without_attributes? in method_missing. If there is any method that responds (even private), let super handle it and raise NoMethodError if necessary.
* Reset column info when messing with columns.Jon Leighton2011-09-131-0/+2
| | | | | | | We are subclassing Session here, but messing with the columns will affect the attribute methods defined on the Session superclass, and therefore other tests, unless we properly isolate it by resetting column info before and after the test run.
* Always generate attribute methods on the base class.Jon Leighton2011-09-134-6/+36
| | | | | | | | | | | | | | This fixes a situation I encountered where a subclass would cache the name of a generated attribute method in @_defined_class_methods. Then, when the superclass has it's attribute methods undefined, the subclass would always have to dispatch through method_missing, because the presence of the attribute in @_defined_class_methods would mean that it is never generated again, even if undefine_attribute_methods is called on the subclass. There various other confusing edge cases like this. STI classes share columns, so let's just keep all the attribute method generation state isolated to the base class.
* Raise error when using write_attribute with a non-existent attribute.Jon Leighton2011-09-138-25/+47
| | | | | | | | | Previously we would just silently write the attribute. This can lead to subtle bugs (for example, see the change in AutosaveAssociation where a through association would wrongly gain an attribute. Also, ensuring that we never gain any new attributes after initialization will allow me to reduce our dependence on method_missing.
* Make protected method public so we avoid method_missing.Jon Leighton2011-09-131-4/+5
|
* Fix warnings.Jon Leighton2011-09-131-1/+1
| | | | Make sure we don't redefine an already-defined attribute method.
* Add deprecation for doing `attribute_method_suffix ''`Jon Leighton2011-09-133-8/+22
|
* refactoringJon Leighton2011-09-131-19/+11
|
* Use an empty AttributeMethodMatcher by default.Jon Leighton2011-09-132-2/+26
| | | | | | This means that attribute methods which don't exist will get generated when define_attribute_methods is called, so we don't have to use hacks like `attribute_method_suffix ''`.
* Alias id= if necessary, rather than relying on method_missingJon Leighton2011-09-131-0/+4
|
* Merge pull request #2988 from guilleiguaran/remove-extra-lineSantiago Pastorino2011-09-121-1/+0
|\ | | | | Remove odd asignation
| * Remove odd asignationGuillermo Iguaran2011-09-121-1/+0
|/
* Use the proper executable on tests.José Valim2011-09-121-1/+1
|
* Merge pull request #2985 from kennyj/masterSantiago Pastorino2011-09-122-1/+17
|\ | | | | fix https://github.com/rails/rails/issues/2582 (with testcase)
| * fix https://github.com/rails/rails/issues/2582 (with testcase)kennyj2011-09-132-2/+18
| |
* | Merge pull request #2678 from jmileham/ares_content_length_bugJon Leighton2011-09-122-4/+36
|\ \ | | | | | | ActiveResource shouldn't rely on the presence of Content-Length
| * | ActiveResource shouldn't rely on the presence of Content-LengthJohn Mileham2011-09-111-1/+9
| | |
| * | Failing test: ActiveResource shouldn't rely on the presence of Content-LengthJohn Mileham2011-09-091-3/+27
| | |
* | | Just provide the executable for railtie. This should be fine since Rubygems ↵José Valim2011-09-123-9/+7
| | | | | | | | | | | | now warns before overriding them.
* | | Merge pull request #2984 from jrgifford/masterXavier Noria2011-09-1289-0/+1417
|\ \ \ | | | | | | | | Added getting_started application to railties/guides/code/getting_started
| * | | Added getting_started code, updated guide with link to rails github repo and ↵James Gifford2011-09-1289-0/+1417
|/ / / | | | | | | | | | path to code
* | | Merge pull request #2936 from joelmoss/migration_statusSantiago Pastorino2011-09-111-5/+7
| | | | | | | | | | | | db:migrate:status not looking at all migration paths
* | | Merge branch 'master' of github.com:lifo/docrailsVijay Dev2011-09-114-10/+10
|\ \ \
| * \ \ Merge pull request #66 from hasanove/masterEmin Hasanov2011-09-111-1/+1
| |\ \ \ | | | | | | | | | | typo in asset pipeline guide
| | * | | Fix typo in "must-revalidate" header nameEmin Hasanov2011-09-111-1/+1
| |/ / /
| * | | Fix for :instance_reader => false code exampleAndy Lindeman2011-09-101-1/+1
| | | |
| * | | Revert "Fixed syntax error in "block setting of attributes" example."Ray Baxter2011-09-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Code and CHANGELOGS can't be edited in docrails. You'll need to make this change in rails/rails. This reverts commit 465752ba6bf2cc124dc78f4a9eb7a1d74dd8c868.
| * | | Fixed syntax error in "block setting of attributes" example.Erik Ostrom2011-09-101-1/+1
| | | |
| * | | Update to conform to rails 3.1 generated caodeMichael P Laing2011-09-101-2/+2
| | | |
| * | | Travis-ci build image should link to the rails travis ci build page rather ↵Jeff Dutil2011-09-081-1/+1
| | | | | | | | | | | | | | | | than to the image.
| * | | some copy-editsVijay Dev2011-09-082-5/+5
| | | |
* | | | Merge pull request #2974 from md5/csrf_token_warningSantiago Pastorino2011-09-101-1/+1
|\ \ \ \ | | | | | | | | | | Use ensure instead of rescue
| * | | | Use ensure instead of rescueMike Dillon2011-09-101-1/+1
| | | | |
* | | | | Merge pull request #2972 from md5/masterAaron Patterson2011-09-103-1/+19
|\| | | | | | | | | | | | | | Use log.warn instead of debug for CSRF token warning
| * | | | Fix changelog entryMike Dillon2011-09-101-1/+1
| | | | |
| * | | | Add test for warning and CHANGELOG entryMike Dillon2011-09-102-0/+18
| | | | |
| * | | | Change log level for CSRF token verification warningMike Dillon2011-09-101-1/+1
| | | | |
* | | | | clarify that documentation bugs have to be reported as Rails issues. [Closes ↵Xavier Noria2011-09-101-0/+4
| | | | | | | | | | | | | | | | | | | | #2858]
* | | | | Merge pull request #2970 from deepakprasanna/masterSantiago Pastorino2011-09-101-0/+25
|\ \ \ \ \ | | | | | | | | | | | | Added a case to check the status of the migration after a rollback and redo.
| * | | | | added test for db migrate:redoDeepak Prasanna2011-09-101-0/+25
| |/ / / /
* | | | | Merge pull request #2968 from arunagw/form_helper_testVijay Dev2011-09-101-2/+1
|\ \ \ \ \ | |/ / / / |/| | | | No need to use </form> here. It's already in whole_form block
| * | | | No need to use </form> here. It's already in whole_form blockArun Agrawal2011-09-101-2/+1
|/ / / /
* | | | Merge pull request #2957 from waseem/migration_status_testsSantiago Pastorino2011-09-091-0/+24
|\ \ \ \ | | | | | | | | | | Tests for rake db:migrate:status.
| * | | | Tests for rake db:migrate:status.Waseem Ahmad2011-09-091-1/+25
| | | | |
* | | | | Merge pull request #2876 from alex3/patch-1Santiago Pastorino2011-09-093-1/+32
|\ \ \ \ \ | | | | | | | | | | | | Fixed assets precompile regex
| * | | | | Fixed assets precompile regex, now accepts ProcsAlex Yakoubian2011-09-083-1/+32
| | | | | |
* | | | | | Merge pull request #2966 from arunagw/no_use_warnings_removedSantiago Pastorino2011-09-092-3/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | Not used variables removed. Warnings removed.
| * | | | | | Not used variables removed. Warnings removed.Arun Agrawal2011-09-102-3/+3
|/ / / / / /
* | | | | | railties depends on actionpack, so put actionpack in the include pathAaron Patterson2011-09-091-1/+7
| | | | | |
* | | | | | rake already ships with a ruby commandAaron Patterson2011-09-091-2/+1
| | | | | |
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-09 09:48:50 +0000