aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | Make error message clearer that :on requires a symbol, not a stringCarol Nichols2014-12-072-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The validation added in 5a3dc8092d19c816b0b1203945639cb91d065847 will reject values for the `:on` option for after_commit and after_rollback callbacks that are string values like `"create"`. However, the error message says ":on conditions for after_commit and after_rollback callbacks have to be one of create,destroy,update". That looks like a string value *would* be valid. This commit changes the error message to say ":on conditions for after_commit and after_rollback callbacks have to be one of [:create, :destroy, :update]", making it clearer that symbols are required.
* | | Merge pull request #17896 from GBH/globbing_route_mailer_previewRafael Mendonça França2014-12-082-1/+12
|\ \ \ | | | | | | | | fixing mailer previews for apps with globbing route
| * | | fixing mailer previews for apps with globbing routeOleg2014-12-032-1/+12
| | | |
* | | | Merge pull request #17969 from tiii/add-brackets-around-attribute_nameRafael Mendonça França2014-12-081-1/+1
|\ \ \ \ | | | | | | | | | | add brackets around attribute_name [ci skip]
| * | | | add brackets around attribute_name_tiii2014-12-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | since 'attr_name_will_change!' is not an actual method it should be clearer that you have to insert the attribute name as in line 104 [ci skip]
* | | | | Fix type case of "validations" and word-wrap from #17954 [ci skip]Zachary Scott2014-12-081-2/+3
| | | | |
* | | | | Merge pull request #17966 from mikechau/update-ar-store-validation-documentationZachary Scott2014-12-081-1/+4
|\ \ \ \ \ | | | | | | | | | | | | Add note to Store about uniqueness validation (#17954) [skip ci]
| * | | | | Add note to Store about uniqueness validation (#17954) [skip ci]Mike Chau2014-12-081-1/+4
| |/ / / /
* | | | | Merge pull request #17953 from kirs/test-activejob-generatorRafael Mendonça França2014-12-081-0/+29
|\ \ \ \ \ | |/ / / / |/| | | | Test coverage for ActiveJob generator
| * | | | Test coverage for ActiveJob generatorKir Shatrov2014-12-071-0/+29
| | | | |
* | | | | Merge pull request #17963 from neerajdotname/wordsmitthingRichard Schneeman2014-12-081-3/+3
|\ \ \ \ \ | |_|_|/ / |/| | | | minor sentences fixes
| * | | | minor sentences fixesNeeraj Singh2014-12-071-3/+3
|/ / / /
* | | | Merge pull request #17959 from eileencodes/fix-grammar-on-reflectionZachary Scott2014-12-071-3/+3
|\ \ \ \ | | | | | | | | | | Fix grammar of sentence in Reflection documentation [ci skip]
| * | | | Fix grammar of sentence in Reflection documentationeileencodes2014-12-071-3/+3
|/ / / /
* | | | Merge pull request #17950 from y-yagi/postgres_guideRichard Schneeman2014-12-071-0/+3
|\ \ \ \ | | | | | | | | | | [ci skip] add `enable_extension` to PostgreSQL hstore example
| * | | | [ci skip] add `enable_extension` to PostgreSQL hstore exampleyuuji.yaginuma2014-12-071-0/+3
|/ / / /
* | | | Merge pull request #17944 from tjschuck/mounted_named_routes_regressionSantiago Pastorino2014-12-062-14/+43
|\ \ \ \ | | | | | | | | | | Mounted Rack apps should have default named routes based on app name
| * | | | Mounted Rack apps should have default named routes based on app nameT.J. Schuck2014-12-062-14/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a regression in 4.2.0 from 4.1.8. https://github.com/rails/rails/pull/17823 fixed a similar regression regarding _explicitly_ named routes for a mounted Rack app, but there was another regression for the default value. With a route like: Rails.application.routes.draw do mount Mountable::Web, at: 'some_route' end The "Prefix" column of rake routes gives the following: - 4.1.8: mountable_web - 4.2.0.beta1-4: [nothing] - 4.2.0.rc1: [nothing] - 4.2.0.rc2: some_route <- regression This fixes the default to go back to being based off the name of the class like the docs specify: https://github.com/rails/rails/blob/785d04e3109f69d0b9b9f4732179592f0ef04e52/actionpack/lib/action_dispatch/routing/mapper.rb#L558-L560 Explicitly named routes still work correctly per https://github.com/rails/rails/pull/17823: Rails.application.routes.draw do mount Mountable::Web, at: 'some_route', as: 'named' end - 4.1.8: named - 4.2.0.beta1-4: [nothing] - 4.2.0.rc1: [nothing] - 4.2.0.rc2: named
* | | | | Merge pull request #17942 from yui-knk/fix/upgrading.mdRichard Schneeman2014-12-061-1/+1
|\ \ \ \ \ | | | | | | | | | | | | [ci skip] update rails version to 3.2.21
| * | | | | [ci skip] update rails version to 3.2.21yui-knk2014-12-061-1/+1
| |/ / / /
* | | | | Merge pull request #17943 from jeremywadsack/doc_cache_importabilityRichard Schneeman2014-12-061-0/+4
|\ \ \ \ \ | |/ / / / |/| | | | Add Guides note to change cache namespace
| * | | | Add Guides note to change cache name space as Entry data is incompatible ↵Jeremy Wadsack2014-12-041-0/+4
| | | | | | | | | | | | | | | | | | | | between 3.2 and 4.0
* | | | | Add `force: true` to tables created in PG testsSean Griffin2014-12-052-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the tests are interupted and the teardown block doesn't run, the developer needs to delete these manually in order to be able to run the tests again.
* | | | | Correctly respect subtypes for PG arrays and rangesSean Griffin2014-12-053-10/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The type registration was simply looking for the OID, and eagerly fetching/constructing the sub type when it was registered. However, numeric types have additional parameters which are extracted from the actual SQL string of the type during lookup, and can have their behavior change based on the result. We simply need to use the block form of registration, and look up the subtype lazily instead. Fixes #17935
* | | | | Merge pull request #17932 from brooksreese/masterRafael Mendonça França2014-12-052-2/+2
|\ \ \ \ \ | | | | | | | | | | | | Fix grammar in Rakefile markup [ci skip]
| * | | | | Fix sentence structure [ci skip]Brooks Reese2014-12-051-1/+1
| | | | | |
| * | | | | Fix grammar in Rakefile markup [ci skip]Brooks Reese2014-12-051-1/+1
| | | | | |
* | | | | | Merge pull request #17934 from rubys/dev_webconsoleRafael Mendonça França2014-12-051-0/+10
|\ \ \ \ \ \ | | | | | | | | | | | | | | Use latest web-console when using --dev or --edge
| * | | | | | Use latest web-console when using --dev or --edgeSam Ruby2014-12-051-0/+10
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: http://intertwingly.net/projects/AWDwR4/checkdepot-215/makedepot.log
* | | | | | Merge pull request #17930 from sergey-alekseev/remove-unused-generalized-tableRafael Mendonça França2014-12-052-49/+0
|\ \ \ \ \ \ | |/ / / / / |/| | | | | remove unused `#generalized_table` and `#optional_parts`
| * | | | | remove unused `#optional_parts`Sergey Alekseev2014-12-051-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This method was copied from journey at https://github.com/rails/rails/commit/56fee39c392788314c44a575b3fd66e16a50c8b5#diff-2cfaf53c860732fea8689d6f2002594bR78. `grep -nr 'optional_parts' .`
| * | | | | remove unused `#generalized_table`Sergey Alekseev2014-12-051-45/+0
| | | | | | | | | | | | | | | | | | | | | | | | This method wass copied from journey at https://github.com/rails/rails/commit/56fee39c392788314c44a575b3fd66e16a50c8b5#diff-d89de8881fc4b9f10cb3e4fc7b2463f3R53. However it looks the method was unused in journey at those point as well.
* | | | | | Include missing requireDavid Heinemeier Hansson2014-12-051-0/+1
| | | | | |
* | | | | | Merge pull request #17817 from aripollak/hide-activejob-argsDavid Heinemeier Hansson2014-12-052-1/+14
|\ \ \ \ \ \ | |/ / / / / |/| | | | | GlobalID objects are logged by their URI, not #inspect on the object, to prevent logging private data
| * | | | | Inline to_global_id conversionAri Pollak2014-12-041-5/+1
| | | | | |
| * | | | | Use try instead of checking for GlobalID::IdentificationAri Pollak2014-12-041-5/+1
| | | | | |
| * | | | | Only filter GIDable objects; remove cosmetic changesAri Pollak2014-12-012-16/+14
| | | | | |
| * | | | | Hide potentially sensitive ActiveJob params from logsAri Pollak2014-11-282-11/+34
| | | | | | | | | | | | | | | | | | | | | | | | * Show GlobalID instead of full object .inspect output
* | | | | | Merge pull request #17925 from rebyn/german_typoSantiago Pastorino2014-12-052-3/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix typo in "Hello World" template in German
| * | | | | | Typo: Hello = Guten Tag (in German)Tu Hoang2014-12-052-3/+3
|/ / / / / /
* | | | | | Merge pull request #17919 from mrgilman/stop-supporting-nested-arraysSean Griffin2014-12-044-40/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | Remove deprecated behavior allowing nested arrays as query values
| * | | | | | Remove deprecated behavior allowing nested arrays as query valuesMelanie Gilman2014-12-044-40/+5
| | | | | | |
* | | | | | | Correctly handle multiple attribute method prefix/suffixes which matchSean Griffin2014-12-042-6/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Active Record defines `attribute_method_suffix :?`. That suffix will match any predicate method when the lookup occurs in Active Model. This will make it incorrectly decide that `id_changed?` should not exist, because it attempts to determine if the attribute `id_changed` is present, rather than `id` with the `_changed?` suffix. Instead, we will look for any correct match.
* | | | | | | Merge pull request #17920 from ↵Sean Griffin2014-12-041-1/+1
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | calebthompson/dont-rely-on-environment-task-for-schema-load Remove environment dependency for db:schema:load
| * | | | | | Remove environment dependency for db:schema:loadCaleb Thompson2014-12-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All of the behavior :environment was giving (that db:schema:load needed) was provided as well with :load_config. This will address an issue introduced in https://github.com/rails/rails/pull/15394. The fact that db:schema:load now drops and creates the database causes the Octopus gem to have [an issue](https://github.com/tchandy/octopus/issues/273) during the drop step for the test database (which wasn't happening in db:schema:load before). The error looks like: ActiveRecord::StatementInvalid: PG::ObjectInUse: ERROR: cannot drop the currently open database : DROP DATABASE IF EXISTS "app_test" Because of the timing, this issue is present in master, 4-2-*, and 4.1.8. A note to forlorn developers who might see this: "Additionally" in a commit message means you should have a separate commit, with a separate justification for changes. Small commits with big messages are your friends.
* | | | | | | Merge pull request #17916 from mrgilman/deprecate-class-handlerSean Griffin2014-12-043-4/+17
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Deprecate `Class` handler in `PredicateBuilder`
| * | | | | | Deprecate `Class` handler in `PredicateBuilder`Melanie Gilman2014-12-043-4/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Users should pass strings to queries instead of classes
* | | | | | | Merge pull request #17797 from y-yagi/donot_delete_mailer_layoutsRafael Mendonça França2014-12-043-4/+23
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Don't remove mailer layouts files
| * | | | | | | Don't remove mailer layouts filesyuuji.yaginuma2014-11-273-4/+23
| | | | | | | |
* | | | | | | | Merge pull request #17825 from aripollak/fix-activejob-sidekiq-integrationRafael Mendonça França2014-12-041-1/+2
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix Sidekiq ActiveJob integration setup Conflicts: activejob/test/support/integration/adapters/sidekiq.rb
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-22 23:36:27 +0000