| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \ \
| | | | | |
| | | | | | |
[ci skip] Improve grammar/syntax in AR validations docs.
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Pass over CHANGELOGS [ci skip]
|
|/ / / / / / |
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Reducing AR::ConPool's critical (synchronized) section
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Renamed `@reserved_connections` -> `@thread_cached_conns`. New name
clearly conveys the purpose of the cache, which is to speed-up
`#connection` method.
The new `@thread_cached_conns` now also uses `Thread` objects as keys
(instead of previously `Thread.current.object_id`).
Since there is no longer any synchronization around
`@thread_cached_conns`, `disconnect!` and `clear_reloadable_connections!`
methods now pre-emptively obtain ownership (via `checkout`) of all
existing connections, before modifying internal data structures.
A private method `release` has been renamed `thread_conn_uncache` to
clear-up its purpose.
Fixed some brittle `thread.status == "sleep"` tests (threads can go
into sleep even without locks).
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Move post checkout connection verification out of mutex.synchronize.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove redundant require 'set' lines
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Dead blog/site links [ci skip]
|
|/ / / / / / |
|
|\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | | |
remove warning from integer ext test
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
this removes the following warning:
```
test/core_ext/integer_ext_test.rb:34: warning: ambiguous first argument; put parentheses or a space even after `-' operator
test/core_ext/integer_ext_test.rb:38: warning: ambiguous first argument; put parentheses or a space even after `-' operator
```
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Do not put partial name to local_assigns when rendering without an object
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When one rendered a partial template without specifying an object
or a collection (e.g. <%= render partial: 'partial_name' %>), Rails
would make an object called :partial_name available in local_assigns.
I don't think this was the intended behavior, since no local variable
called 'partial_name' gets defined in the view.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
[ci skip] Remove comments about Rails 3.1
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Stems from https://github.com/rails/rails/pull/20105#issuecomment-100900939
where @senny said:
> From my point of view, all the docs (guides, API) are version bound.
> They should describe that version and continue to be available when newer versions are released.
> The cross referencing can be done by the interested user.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
[ci skip] Improve phrasing in AR migrations docs.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
* insert 'and' into a poorly formed sentence.
* avoid using 'reverse' twice in the same sentence (which would indicate
the opposite of what is meant)
|
|\ \ \ \ \ \ \
| |_|_|/ / / /
|/| | | | | | |
Rails documentation standard is american english. [ci skip]
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
remove redundant parenthesis
|
| | | | | | | |
|
|\| | | | | |
| |_|_|_|/ /
|/| | | | | |
remove redundant parenthesis.
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Minor comment fix
|
|/ / / / / |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Fixnum#zero?
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
In Rails 4.0, json decoding relied on MultiJson. This changed from 4.1
forward since it reached its end of life, and this extra argument was
kept for compatibility. We are safe to remove it now.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove call to sanitize_sql_hash_for_conditions
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This method has already been removed.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This can resolve confusing situation when a top level constant exists
but a namespaced version is identified.
Related to #19531.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
https://github.com/agrobbin/rails into agrobbin-sti-subclass-from-attributes
Conflicts:
activerecord/CHANGELOG.md
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
If your STI class looks like this:
```ruby
class Company < ActiveRecord::Base
self.store_full_sti_class = false
class GoodCo < Company
end
class BadCo < Company
end
end
```
The expectation (which is valid) is that the `type` in the database is saved as
`GoodCo` or `BadCo`. However, another expectation should be that setting `type`
to `GoodCo` would correctly instantiate the object as a `Company::GoodCo`. That
second expectation is what this should fix.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
:nodoc: postgresql add_column
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Add full set of MySQL CLI options to support SSL authentication when using db:structure dump and load
|
| | |/ / / / /
| |/| | | | |
| | | | | | |
| | | | | | | |
db:structure dump and load
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Add more detailed comment about _assign_attribute method [ci skip]
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
fix minor problems
|
|\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | |
| | | | | | | |
| | | | | | | | |
vngrs/refactor_abstract_mysql_adabter_type_to_sql_method
Refactor abstract_mysql_adapter type_to_sql method
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
[ci skip] Don’t encourage `sudo gem install`
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
I think we are better off leaving `sudo` outside of the documented
way of installing gems (`activerecord`, `actionpack`, …).
We don’t want newbies to think that `sudo` is required or, even worse, than
they actually have to type `[sudo] gem install`.
In most scenarios, `sudo` is not needed to install gems, and people who do
need it, probably already know about it.
What do you think? :grin:
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
[ci skip] Fix `transaction` code example
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix default value in guide [ci skip]
|
| | |/ / / /
| |/| | | | |
|