aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Map :bigint as NUMBER(19) sql_type by using `:limit => 19` for OracleYasuo Honda2015-06-012-2/+6
| | | | | | | | | | | | | | | | | | | since NUMBER(8) is not enough to store the maximum number of bigint. Oracle NUMBER(p,0) as handled as integer because there is no dedicated integer sql data type exist in Oracle database. Also NUMBER(p,s) precision can take up to 38. p means the number of digits, not the byte length. bigint type needs 19 digits as follows. $ irb 2.2.2 :001 > limit = 8 => 8 2.2.2 :002 > maxvalue_of_bigint = 1 << ( limit * 8 - 1) => 9223372036854775808 2.2.2 :003 > puts maxvalue_of_bigint.to_s.length 19 => nil 2.2.2 :004 >
* Merge pull request #20371 from davydovanton/doc-adapter-lookupYves Senn2015-06-011-0/+4
|\ | | | | Update documentation for QueueAdapters::lookup [ci skip]
| * [skip ci] Update documentation for QueueAdapters::lookupAnton Davydov2015-06-011-0/+4
| |
* | Merge pull request #20394 from mechanicles/use-symMatthew Draper2015-06-011-2/+5
|\ \ | | | | | | [ci skip] Used 'instance_variables' in example for consistency.
| * | [ci skip] Used 'instance_variables' in example for consistency.Santosh Wadghule2015-06-011-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | - Found that checking instance_variables elements using string object gives us 'false' value. `instance_variables.include? "@articles" # => false` - Used only 'instance_variables' instead of using '.include?' on it. So that it will return recent instance variables list.
* | | Merge pull request #20396 from nkondratyev/fix-guidesKasper Timm Hansen2015-06-011-2/+0
|\ \ \ | |/ / |/| | Remove description of `dependency_loading` option
| * | Remove description of `dependency_loading` optionNikolay Kondratyev2015-06-011-2/+0
|/ / | | | | | | | | | | This option has been removed in e6747d87f3a061d153215715d56acbb0be20191f [ci skip]
* | Merge pull request #20393 from yui-knk/fix/guide2Arun Agrawal2015-06-011-1/+1
|\ \ | | | | | | [ci skip] Fix `above` -> `below`
| * | [ci skip] Fix `above` -> `below`yui-knk2015-06-011-1/+1
|/ /
* | Merge pull request #20392 from equiamos/equiamos-fix-typos-docsZachary Scott2015-05-311-5/+5
|\ \ | | | | | | Fixed typos [ci skip]
| * | Fixed typos. [ci skip]Morgan Owens2015-05-311-5/+5
| | |
* | | Use `any?` rather than `present?` to check argseileencodes2015-05-312-2/+2
|/ / | | | | | | | | | | It's better to use Ruby methods when possible over methods defined by Active Support because then it does not need to rely on any dependencies.
* | no rails command short-cuts in the getting-started guide. [ci skip]Yves Senn2015-05-311-1/+1
| | | | | | | | The full command name is more expressive.
* | minor formatting changes in changelogs. [ci skip]Yves Senn2015-05-312-7/+7
| |
* | Attempt to fix travis failuresSean Griffin2015-05-301-0/+3
| | | | | | | | | | The version of SQLite used by Travis is outdated. We need to install a newer version.
* | Ensure symbols passed to `select` are always quotedSean Griffin2015-05-304-10/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Our general contract in Active Record is that strings are assumed to be SQL literals, and symbols are assumed to reference a column. If a from clause is given, we shouldn't include the table name, but we should still quote the value as if it were a column. Upon fixing this, the tests were still failing on SQLite. This was because the column name being returned by the query was `"\"join\""` instead of `"join"`. This is actually a bug in SQLite that was fixed a long time ago, but I was using the version of SQLite included by OS X which has this bug. Since I'm guessing this will be a common case for contributors, I also added an explicit check with a more helpful error message. Fixes #20360
* | Add docs and changelog entry for 73aab03 [ci skip]Sean Griffin2015-05-302-1/+15
| |
* | Merge pull request #20380 from kamipo/add_changelog_for_17654Eileen M. Uchitelle2015-05-301-0/+13
|\ \ | | | | | | Add CHANGELOG entry for #17654
| * | Add CHANGELOG entry for #17654 [ci skip]Ryuta Kamizono2015-05-301-0/+13
|/ /
* | Merge pull request #20378 from vngrs/fix_doc_of_match_methodKasper Timm Hansen2015-05-301-3/+6
|\ \ | | | | | | match method doc fix [ci skip]
| * | match method doc fix [ci skip]Mehmet Emin İNAÇ2015-05-301-3/+6
|/ / | | | | | | | | | | match method without setting `:via` option has been deprecated fix minor typo
* | Merge pull request #20375 from yoongkang/docfixClaudio B.2015-05-301-1/+1
|\ \ | | | | | | [ci skip] match without via is now deprecated
| * | [ci skip] match without via is now deprecatedYoong Kang Lim2015-05-301-1/+1
| | |
* | | Merge pull request #20370 from manishspuri/masterGodfrey Chan2015-05-308-4/+56
|\ \ \ | |/ / |/| | | | | Add tmp directory before touching
| * | Add test to ensure tmp:clear works when tmp is missingYoong Kang Lim2015-05-301-0/+7
| | | | | | | | | | | | See #20299.
| * | Generate a `.keep` file in `tmp` folderYoong Kang Lim2015-05-304-1/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A lot of scripts assumes the existence of this folder and most would fail if it is absent. One example of this is `rake restart` (before the previous commit) – it tries to `touch tmp/restart.txt`, which would fail if `tmp` does not exist, which was the case for a freshly-cloned project as `tmp` is `.gitignored` by default. See #20299. [Yoong Kang Lim, Sunny Juneja]
| * | `rake restart` should work without a `tmp` folderYoong Kang Lim2015-05-303-3/+12
|/ / | | | | | | | | | | | | | | | | | | | | | | | | In restart.rake, the creation of tmp/restart.txt would fail if the tmp folder does not exist in the app. This is a problem because apps cloned using git would not have the tmp folder, as the folder is in .gitignore. This commit creates the tmp folder if it does not exist. Fixes #20299 [Yoong Kang Lim, Sunny Juneja]
* | Require yaml for isolation testRafael Mendonça França2015-05-291-0/+1
| | | | | | | | | | It was removed when we removed mocha at 5a6ae7f7539216931f2b3f4aa53394ac4136c74e
* | Merge pull request #20370 from manishspuri/masterKasper Timm Hansen2015-05-292-5/+5
|\ \ | | | | | | formatting changes
| * | formatting changesunknown2015-05-292-5/+5
|/ /
* | Make the wording less confusingRafael Mendonça França2015-05-291-1/+1
| | | | | | | | | | | | This partially reverts commit ac02df5c7827630a91acd9a6b916db9eda1f38b4. [ci skip]
* | Merge pull request #20367 from manishspuri/masterRafael Mendonça França2015-05-292-2/+2
|\ \ | | | | | | minor text change [ci skip]
| * | minor text changeManish Puri2015-05-291-1/+1
| | |
| * | Update inline_preview_interceptor.rbManish Puri2015-05-291-1/+1
|/ /
* | Merge pull request #20365 from ↵Rafael Mendonça França2015-05-295-79/+89
|\ \ | | | | | | | | | | | | repinel/revert-19878-replace_alias_chains_with_prepend Revert "Replace use of alias chains with prepend at core_ext/date and…
| * | Revert "Replace use of alias chains with prepend at core_ext/date and ↵Roque Pinel2015-05-295-79/+89
| | | | | | | | | | | | core_ext/time"
* | | Merge pull request #20366 from Gaurav2728/gaurav-mailerMatthew Draper2015-05-301-1/+0
|\ \ \ | |/ / |/| | not require mail file
| * | not require mail fileGaurav Sharma2015-05-291-1/+0
|/ / | | | | | | | | | | ``` it added in this commit (https://github.com/rails/rails/commit/2a25c4ce6da6ea23ebdf44e7eb2d2441dbea20a1), now no warnings occur. ```
* | Merge pull request #20364 from ernie/update-serialize-docsSean Griffin2015-05-291-0/+9
|\ \ | | | | | | | | | | | | | | | Update docs for ActiveRecord `serialize` [ci skip]
| * | Update docs for ActiveRecord `serialize`Ernie Miller2015-05-291-0/+9
|/ / | | | | | | | | | | | | | | | | | | | | | | For certain column types, using `serialize` is unnecessary, or the user may get unexpected contents back from the DB adapter (which is handling some basic deserialization for them). Call this out in the documentation. For background, see: https://gist.github.com/ernie/33f75f2294885b9806f9 https://twitter.com/erniemiller/status/604262907442905090
* | Merge pull request #20355 from segiddins/seg-bundler-1-10Santiago Pastorino2015-05-292-2/+4
|\ \ | | | | | | Bundler 1.10 should work now!
| * | Generate Bundler 1.10.1 lockfileSamuel E. Giddins2015-05-281-0/+3
| | |
| * | Revert "Use bundler < 1.10 until its bugs are fixed"Samuel E. Giddins2015-05-281-1/+1
| | | | | | | | | | | | This reverts commit 81b42970f02d07ca5007bbce920b489d80172636.
| * | Revert "Uninstall bundler 1.10"Samuel E. Giddins2015-05-281-1/+0
| | | | | | | | | | | | This reverts commit 410d246bc0ddabe47f0bf54116be9087bd3d4bda.
| * | Revert "Force the uninstall"Samuel E. Giddins2015-05-281-1/+1
| | | | | | | | | | | | This reverts commit 9ff901bd3e046b0373b28459269146707b5bf8c9.
* | | Merge pull request #20358 from tgxworld/remove_codeSantiago Pastorino2015-05-291-2/+0
|\ \ \ | | | | | | | | Remove unused code.
| * | | Remove unused code.Guo Xiang Tan2015-05-291-2/+0
| |/ / | | | | | | | | | Code was moved into the `assign` method.
* | | Merge pull request #20354 from arunagw/fix-warning-ambiguous-first-argumentYves Senn2015-05-291-1/+1
|\ \ \ | |/ / |/| | Fix warning about ambiguous first argument
| * | Fix warning about ambiguous first argumentArun Agrawal2015-05-291-1/+1
|/ /
* | Merge pull request #19878 from pabloh/replace_alias_chains_with_prependRafael Mendonça França2015-05-285-89/+79
|\ \ | | | | | | Replace use of alias chains with prepend at core_ext/date and core_ext/time
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 00:25:48 +0000