| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
|\
| |
| | |
Creating a class to build the default middleware stack.
|
| |
| |
| |
| |
| |
| |
| | |
A lot of logic for building the default middleware stack is currently
kept in Application class, but this can be encapsulated and made more
modular by being moved to its own class. Also refactored a couple of the
helper methods.
|
| | |
|
|\ \
| | |
| | | |
Removing a repetitive comment and refactoring the Application class in Railties
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Railties.
The comment on the +env_config+ method is repetitive, likely to get
outdated, and provides no useful information which cannot be gleamed
from the code. I'm therefore removing it. I'm also refactoring the check
for the presence of a secret_token in the configuration.
|
|\ \ \
| | | |
| | | | |
Calls to the application constant have been refactored
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Rails.application when drawing routes and creating other configurations
on the application.
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* master: (142 commits)
Use Colspan in th Tags
Added test for link_to_unless to make sure the result consistency.
Escape the string even when the condition of link_to_unless is not satisfied.
Add CHANGELOG entry for #10969
Use a case insensitive URI Regexp for #asset_path
collection tags accept html attributes as the last element of collection
Rewind StringIO instances before be parsed again
Use xml instead already parsed xml
Updated the doc for const_regexp [ci skip]
Make test name descriptive and add reference to original regression commit
fixture setup does not rely on `AR::Base.configurations`.
regression test + mysql2 adapter raises correct error if conn is closed.
cleanup, remove trailing whitespace from AR changelog
'json' gem is no more required under JRuby
fix typos
Fix AS changelog [ci skip]
Update the HTML boolean attributes per the HTML 5.1 spec
Changing const_regexp to check for constant name.
valid_app_const? -> valid_const?
Add CHANGELOG entry for #10740
...
|
| |\ \ \ \
| | | | | |
| | | | | | |
Use Colspan in th Tags
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Is it more suitable that using ```<th colspan="3">``` instead of three empty ```<th>```? It is simple, but what i am missing about it?
Change repetitive th tags to use colspan attribute
Update CHANGELOG.md
Update CHANGELOG.md
|
| |\ \ \ \ \
| | |/ / / /
| |/| | | | |
Always escape the result of link_to_unless method
|
| | | | | | |
|
| | | | | | |
|
| |\ \ \ \ \
| | |/ / / /
| |/| | | | |
correct documentation about active_record.default_timezone
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
| |\ \ \ \ \
| | |_|_|/ /
| |/| | | | |
Use a case insensitive URI Regexp for #asset_path
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Context: https://gist.github.com/radar/5793814
The `URI_REGEXP` that various AssetUrl helpers use is currently case
sensitive when checking for a URI scheme. This means if you try to pass
a URL like `HTTP://www.example.com/path/to/image.jpg`, you end up with
a bogus asset path: `/assets/HTTP://www.example.com/path/to/image.jpg`.
URLs are case insensitive, so this regexp should be as well.
Signed-off-by: David Celis <me@davidcel.is>
|
| |\ \ \ \
| | | | | |
| | | | | | |
collection tags accept html attributes as the last element of collection
|
| |/ / / / |
|
| |\ \ \ \
| | |_|_|/
| |/| | | |
Fix build after #10727
|
| | | | | |
|
| |/ / / |
|
| |\ \ \
| | | | |
| | | | | |
Fix XmlMini different backends tests
|
| | | | | |
|
| |\ \ \ \
| | | | | |
| | | | | | |
Updated the doc for const_regexp [ci skip]
|
| |/ / / / |
|
| |\ \ \ \
| | | | | |
| | | | | | |
Update HTML boolean attributes per the HTML 5.1 spec
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- Add attributes `allowfullscreen`, `default`, `inert`, `sortable`,
`truespeed`, `typemustmatch`.
- Fix attribute `seamless` (previously misspelled `seemless`).
- Use `assert_dom_equal` instead of `assert_equal` in test.
|
| |\ \ \ \ \
| | | | | | |
| | | | | | | |
Fix test, addresss => address
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
fixture setup does not rely on `AR::Base.configurations`.
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
As you can also configure your database connection using `ENV["DATABASE_URL"]`,
the fixture setup can't reply on the `.configurations` Hash.
As the fixtures are only loaded when ActiveRecord is actually used
(`rails/test_help.rb`) it should be safe to drop the check for an existing configuration.
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
'json' gem is no more required under JRuby
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
regression test + mysql2 adapter raises correct error if conn is closed.
|
| |/ / / / / / / |
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| | |/ / / / / /
| |/| | | | | | |
fix typos
|
| | | | | | | | |
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Fix wrong method name
|
| | | |_|/ / / /
| | |/| | | | | |
|
| |\ \ \ \ \ \ \
| | |/ / / / / /
| |/| | | | | | |
We need to check exception name to be nil
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
We need to return Regexp.escape(camel_cased_word)
if the split is blank.
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
[ci skip]
|
| |\ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
HashWithIndifferentAccess#select working as intended
|