| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When changing the generated integration tests to assert redirects with
an absolute path this redirection check in `assert_redirected_to` against
the absolute response location would now pass:
https://github.com/rails/rails/blob/af245aaf3a1c447752a1b5895adddc66e5f73c00/actionpack/lib/action_dispatch/testing/assertions/response.rb#L55
Thus we'd break early instead of hitting `assert_operator` and have
2 fewer assertions per `assert_redirected_to` as `assert_operator`
is composed of 2 assertions internally:
https://github.com/seattlerb/minitest/blob/4e146b1515b19a5c474e39c174b037510f6dbc6e/lib/minitest/assertions.rb#L254-L258
Deduct 2 assertions for 2 redirects taking the expected count down by 4
in total for the two failing tests.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove public/ files for API apps
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- Fixes #25180
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
second is now irrelevant with the dedicated API mode
|
|/ / / / / |
|
|\ \ \ \ \
| |_|_|_|/
|/| | | | |
fix incorrect class name [ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Use `add_index` instead of `execute` in guides [ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] Reword doc for around_enqueue callback
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
Taken literally, the documentation suggests that the callback gets
called twice (before and after enqueueing). By wording it similarly to
that of around_perform this confusion is avoided.
|
|\ \ \ \
| | | | |
| | | | | |
cometic updates to security guide - fixes #25058 [ci skip]
|
|/ / / / |
|
|\ \ \ \
| |_|_|/
|/| | | |
Remove unused `association_for_table` private method
|
| | | |
| | | |
| | | |
| | | | |
`association_for_table` is unused since 50a8cdf.
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] Fix ActionCable Guides
|
| |/ / /
| | | |
| | | |
| | | | |
Default worker pool size was changed from 100 to 4 at #24376
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
y-yagi/add_missing_as_option_to_deprecation_message
add missing `as` to request kwargs of `ActionDispatch::IntegrationTest`
|
| |/ / /
| | | |
| | | |
| | | | |
Follow up to #21671
|
|\ \ \ \
| |/ / /
|/| | | |
Add test for `delegate_missing_to` where method doesn't exist
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Bash markdown syntax
|
|/ / /
| | |
| | | |
Added 'sh' for markdown formatting as bash.
|
|\ \ \
| | | |
| | | | |
Fix `has_one` `enum` `where` queries
|
| | | |
| | | |
| | | |
| | | | |
Fixes #25128
|
|\ \ \ \
| |/ / /
|/| | | |
Docs: Clarify when assoc. methods persist [ci skip]
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
Because I can never remember if `collection_singular_ids=` persists
or not (it does).
[ci skip]
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | | |
Revert back to a compatible bundler version
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Add tests for keyword arg to: for Module#delegate
|
| |/ / |
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
Allow failures until test runs are consistently stable, not hanging.
Closes #24943.
Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
|
|\ \
| | |
| | | |
Normalize whitespace for Hash#compact documentation
|
|/ /
| |
| |
| | |
This is a similar change that occurred for Hash#except in #21087.
|
| |
| |
| |
| | |
And make sure that it doesn't even try to call the method in the target.
|
|\ \
| | |
| | | |
Build action_cable.js with Blade
|
| | |
| | |
| | |
| | | |
Introduced in d6f2000a67cc63aa67414c75ce77de671824ec52 and was only used by Action Cable. Now handled by Action Cable’s assets:compile task.
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | | |
Introduce Module#delegate_missing_to
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When building decorators, a common pattern may emerge:
class Partition
def initialize(first_event)
@events = [ first_event ]
end
def people
if @events.first.detail.people.any?
@events.collect { |e| Array(e.detail.people) }.flatten.uniq
else
@events.collect(&:creator).uniq
end
end
private
def respond_to_missing?(name, include_private = false)
@events.respond_to?(name, include_private)
end
def method_missing(method, *args, &block)
@events.send(method, *args, &block)
end
end
With `Module#delegate_missing_to`, the above is condensed to:
class Partition
delegate_missing_to :@events
def initialize(first_event)
@events = [ first_event ]
end
def people
if @events.first.detail.people.any?
@events.collect { |e| Array(e.detail.people) }.flatten.uniq
else
@events.collect(&:creator).uniq
end
end
end
David suggested it in #23824.
|
|\ \ \ \
| | | | |
| | | | | |
Cloning depth set to 1
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Improved commands in README with markdown formatting
|
| | | | | |
|
|/ / / /
| | | |
| | | | |
Adding '$' to emulate shell syntax
|
| | | |
| | | |
| | | | |
[ci skip]
|
|\ \ \ \
| |_|/ /
|/| | | |
Use RAILS_MAX_THREADS as pool size on all adapters
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When RAILS_MAX_THREADS is set, the postgresql adapter uses it as the
connection pool size, so that there are always enough connections
available to serve Action Cable requests.
The same logic applies when using any other adapter.
|