| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | | |
[Jon Moss & Xavier Noria]
|
|\ \ \
| |/ /
|/| | |
Active Storage: Explicit form field in basic example
|
|/ /
| |
| | |
Also fix syntax highlighting in the more advanced JS example.
|
|\ \
| | |
| | |
| | |
| | | |
bogdanvlviv/document-year_format-option-of-date_select
Add to docs mention about `:year_format` option of date select
|
|/ /
| |
| |
| |
| |
| | |
Follow up #32190
[ci skip]
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Update fugit to latest version
|
|/ /
| |
| |
| |
| |
| |
| | |
[fugit 1.1.3](https://github.com/floraison/fugit/commit/03a3ee86f3cd5d929442dd25896b99acbd151947)
fixes warnings that show up in ActiveJob tests.
See [CI](https://travis-ci.org/rails/rails/jobs/394107740#L3764-L3778).
|
|\ \
| | |
| | |
| | | |
Add `use_year_names` option to date_select tag
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
to customize year
names. Lambda should be passed to use this option. Example:
date_select('user_birthday', '', start_year: 1998, end_year: 2000, year_format: ->year { "Heisei #{year - 1988}" })
The HTML produced:
<select id="user_birthday__1i" name="user_birthday[(1i)]">
<option value="1998">Heisei 10</option>
<option value="1999">Heisei 11</option>
<option value="2000">Heisei 12</option>
</select>
/* The rest is omitted */
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Fix actionpack changelog typo
[ci skip]
|
| | | |
| | | |
| | | |
| | | | |
I spotted it while working on a PR.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
thomasdziedzic-pd/add-use_authenticated_message_encryption-documentation
add documentation for config.active_support.use_authenticated_message_encryption
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
config.active_support.use_authenticated_message_encryption [ci skip]
related to https://github.com/rails/rails/issues/33170
|
| | | |
| | | |
| | | |
| | | | |
Follow up of 15367a2c674bf19eeefa12ccb64391bdd50d883d.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Since `aliases` is a part of `JoinDependency` and already cached at
1a723c65bbe91ad969b67416233d20eff6d2a46a.
|
|/ / /
| | |
| | |
| | | |
It was no longer used since d7ddaa530fd1b94e22d745cbaf2e8a5a34ee9734.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Convert hashes into parameters
Ensure `ActionController::Parameters#transform_values` and
`ActionController::Parameters#transform_values!` converts hashes into
parameters.
* fixup! Convert hashes into parameters
[Rafael Mendonça França + Kevin Sjöberg]
|
|\ \ \
| | | |
| | | | |
Reduce Memory Allocation when using .pluck
|
| | | |
| | | |
| | | |
| | | | |
to speed up pluck
|
|\ \ \ \
| | | | |
| | | | | |
Removed useless utility classes inside HABTM association builder
|
| |/ / / |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently, column aliases which is used for eager loading are calculated
before constructing all table aliases in FROM clause.
`JoinDependency#join_constraints` constructs table aliases for `joins`
first, and then always re-constructs table aliases for eager loading.
If both `joins` and eager loading are given a same table association,
the re-construction would cause the discrepancy between column aliases
and table aliases.
To avoid the discrepancy, the column aliases should be calculated after
all table aliases are constructed.
Fixes #30603.
|
|\ \ \ \
| |/ / /
|/| | | |
Add support for more HTTP cache controls
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
From <https://tools.ietf.org/html/rfc5861>:
> The stale-if-error HTTP Cache-Control extension allows a cache to
> return a stale response when an error -- e.g., a 500 Internal Server
> Error, a network segment, or DNS failure -- is encountered, rather
> than returning a "hard" error. This improves availability.
>
> The stale-while-revalidate HTTP Cache-Control extension allows a
> cache to immediately return a stale response while it revalidates it
> in the background, thereby hiding latency (both in the network and on
> the server) from clients.
These are useful, fully standardized parts of the HTTP protocol with
widespread support among CDN vendors. Supporting them will make it
easier to utilize reverse proxies and CDNs from Rails.
|
|\ \ \ \
| | | | |
| | | | | |
Fix Ruby version in `.ruby-version`
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Since #30016 Rails generates `.ruby-version` file
in order to help Ruby version manager tools like `rbenv`, `rvm`
determine which Ruby version should be used for the current Rails
project.
Since #32649 Rails sets Ruby version to the file compatible with MRI/JRuby
by default.
Pull Request #31496 reports that `.ruby-version` doesn't match ruby version other
than stable version and recommends to use `ENV["RBENV_VERSION"]`, and
`ENV["rvm_ruby_string"]` in order to set correct Ruby version to the file
that `rbenv` or `rvm` can understand.
Also, there is another similar issue that reports the same case if use
JRuby https://github.com/jruby/jruby/issues/5144.
Closes #31496, https://github.com/jruby/jruby/issues/5144.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add test case for the `|` token in Journey scanner
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Journey's scanner tokenizes the `|` (:OR) operator when scanning route
urls such as `"/:foo|*bar"`. However, the current scanner test does not
have any test cases for the `|` operator. This commit adds a test case
for this particular token.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add docs for ActiveRecord::Migration#say, #say_with_time, #suppress_messages [ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`touch` option was added to `increment!` (#27660) and `update_counters`
(#26995). But that option behaves inconsistently with
`Persistence#touch` method.
If `touch` option is passed attribute names, it won't update
update_at/on attributes unlike `Persistence#touch` method.
Due to changed from `Persistence#touch` to `increment!` with `touch`
option, #31405 has a regression that `counter_cache` with `touch` option
which is passed attribute names won't update update_at/on attributes.
I think that the inconsistency is not intended. To get back consistency,
ensure that `touch` option updates update_at/on attributes.
|
|/ / / /
| | | |
| | | |
| | | | |
`optparse` is unused since #26977.
|
| | | |
| | | |
| | | |
| | | | |
Ref: https://github.com/ruby/ruby/blob/cc77a811298bd7ab1c422f7f999b93c858327da9/lib/net/http/response.rb#L138-L155
|
| | | |
| | | |
| | | |
| | | | |
It is necessary to specify a value to `config.active_storage`.
|
|\ \ \ \
| | | | |
| | | | | |
Fix rubocop violations
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
https://codeclimate.com/github/rails/rails/issues
`bundle exec rubocop -a`
Related to e4e1b62007fe40c4277ebc30067837a91bf25967
|
|\ \ \ \
| | | | |
| | | | | |
Update example for whitelisting arbitrary hashes
|
|/ / / /
| | | |
| | | | |
Since the ability to whitelist arbitrary hashes was added (https://github.com/rails/rails/issues/9454 was resolved by https://github.com/rails/rails/commit/e86524c0c5a26ceec92895c830d1355ae47a7034), this example is no longer outside of what strong_params can do. Moved this specific example out of the "Outside the Scope" section and into the regular "Examples" section, but left the "Outside the Scope" section as it was since the advice is still relevant for weirder whitelisting situations (maybe someone wants to add a new example that can't be handled natively).
|
|/ / /
| | |
| | |
| | | |
[ci skip]
|
|\ \ \
| | | |
| | | |
| | | | |
Allow prefix/suffix options for store accessors
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
bogdanvlviv/update-active_support_core_extensions-guide
Update "Active Support Core Extensions" Guide
[ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Remove general sentence that explains that all methods that Active Support
brings to `Date` `Time`, `DateTime` are defined in
`active_support/core_ext/date/calculations.rb` since it isn't true.
Add a references to an appropriate file where methods are defined
like it is done with the other methods in this guide.
Context https://github.com/rails/rails/pull/32552#discussion_r181216246
Related to #32543, #32552
[ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This may seem like an unnecessary refactoring but some apps want / need
to configure the information passed to the query cache logger. In order
to do that we can add a method here that can be easily overridden by the
app itself, rather than hacking the query cache logger to include that
information.
To override apps can call
```
def cache_notifications_info
super.merge(connected_host: "hostname")
end
```
This will take what's already in the query cache logger and add
`@something="yea"` to the object.
At GitHub we use this to log the number of queries that are cached, the
connection host and the connection url.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Remove reference to session_store.rb initializer
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Rails no longer generates this file, but Google is still packed with results
suggesting it should exist, so that the doc still pointed me to it threw me
off (had I deleted it or something?). Probably be better to be vague and
prompt the user to stick it in a config file they own.
#33124
|
|\ \ \ \
| | | | |
| | | | | |
Add comma to example in guides/source/active_storage_overview.md [ci skip]
|
|/ / / / |
|