aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #15542 from Gaurav2728/gaurav-remove_shutdown_linkArthur Nogueira Neves2014-06-069-15/+17
|\ | | | | remove rubyforge.org that was shut down [ci skip]
| * remove rubyforge.org that was shut down [ci skip]Gaurav Sharma2014-06-069-15/+17
| |
* | Unwrap another html_escapeMatthew Draper2014-06-071-2/+2
| | | | | | | | /cc @tenderlove
* | Merge pull request #15554 from sgrif/sg-klassRafael Mendonça França2014-06-066-21/+0
|\ \ | | | | | | Removed unused `klass` definitions from types
| * | Removed unused `klass` definitions from typesSean Griffin2014-06-066-21/+0
|/ / | | | | | | Only `Date` and `Time` are handled.
* | eliminate more wasteful allocationsAaron Patterson2014-06-061-2/+2
| |
* | Merge pull request #15552 from sgrif/sg-remove-klass-special-caseRafael Mendonça França2014-06-062-4/+7
|\ \ | | | | | | Remove composed_of special case from multi-parameter attributes
| * | Remove composed_of special case from multi-parameter attributesSean Griffin2014-06-062-4/+7
| | | | | | | | | | | | | | | As we move towards removing the `klass` method from `column`, the else clause as it stands right now will become the only case.
* | | Merge pull request #15551 from sgrif/sg-numeric-typesRafael Mendonça França2014-06-062-9/+9
|\ \ \ | | | | | | | | Don't mess with `_before_type_cast` for numeric types
| * | | Don't mess with `_before_type_cast` for numeric typesSean Griffin2014-06-062-9/+9
| |/ /
* | | remove another wasteful AS::SafeBuffer allocationAaron Patterson2014-06-061-1/+1
| | |
* | | eliminate wasteful AS::SafeBuffer allocationAaron Patterson2014-06-061-1/+1
| | |
* | | Revert "Merge pull request #15550 from sgrif/sg-numeric-types"Rafael Mendonça França2014-06-061-8/+7
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit be1db9946616a4005bb7be45656cc0f84d75d915, reversing changes made to 6680ee9427ae2639e404cd3b9538f54e136057c6. Reason: This changed a behavior where numeric attributes when receiving blank values didn't change its value.
* | | Merge pull request #15550 from sgrif/sg-numeric-typesRafael Mendonça França2014-06-061-7/+8
|\ \ \ | |/ / |/| | Don't mess with `_before_type_cast` for numeric types
| * | Don't mess with `_before_type_cast` for numeric typesSean Griffin2014-06-061-7/+8
|/ /
* | Merge pull request #15548 from ↵Yves Senn2014-06-061-0/+4
|\ \ | |/ |/| | | | | zuhao/refactor_actionmailer_i18n_with_controller_test Restore I18n.locale to default after test.
| * Restore I18n.locale to default after test.Zuhao Wan2014-06-071-0/+4
|/ | | | | | | | | | If i18n_with_controller_test.rb were to run first, the I18n.locale will be changed to :de, and the following tests in base_test.rb will fail: "subject gets default from I18n" “default subject can have interpolations” "translations are scoped properly" "implicit multipart with default locale"
* Merge pull request #15544 from zuhao/refactor_actionmailer_test_caseSantiago Pastorino2014-06-061-0/+8
|\ | | | | Restore test deliveries properly in ActionMailer.
| * Restore test deliveries properly in ActionMailer.Zuhao Wan2014-06-071-0/+8
|/ | | | | | | | | | | `ActionMailer::Base.delivery_method` and `ActionMailer::Base.perform_deliveries` have leaked states. "delivery method can be customized per instance" and "delivery method can be customized in subclasses not changing the parent" in delivery_methods_test.rb will fail if test_helper_test.rb (in which TestHelperMailerTest is inherited from ActionMailer::TestCase) runs before it.
* Merge pull request #15533 from sgrif/sg-missing-schema-testsYves Senn2014-06-061-0/+29
|\ | | | | Add missing test cases for schema dumping defaults
| * Add missing test cases for schema dumping defaultsSean Griffin2014-06-061-0/+29
| |
* | credit JoseLuis Torres for #15051. [JoseLuis Torres]Yves Senn2014-06-061-1/+1
| | | | | | | | [ci skip]
* | `ActiveRecord::SchemaMigration` has no primary key.Yves Senn2014-06-063-0/+24
| | | | | | | | | | | | | | | | | | | | Before this patch, using `ActiveRecord::Base.primary_key_prefix_type` with `:table_name_with_underscore` would change the `SchemaMigration` model to have a primary key. This resulted in broken queries for PG because it tried to return the inserted PK (which does not exist). Closes #15051. Closes #15419.
* | test refactor, don't hardcode default for `table_name_prefix`.Yves Senn2014-06-061-1/+2
| |
* | test refactor, don't hardcode `primary_key_prefix_type` default.Yves Senn2014-06-061-0/+3
| | | | | | | | /cc @zuhao
* | serialized Type should delegate `type_cast_for_write` to underlying TypeYves Senn2014-06-062-1/+36
|/ | | | | | | This adds a regression test for #14411, which was fixed by #15503. Closes #14411 Closes #14595
* Merge pull request #15503 from sgrif/sg-json-hstore-storageYves Senn2014-06-069-20/+29
|\ | | | | Bring type casting behavior of hstore/json in line with serialized
| * Bring type casting behavior of hstore/json in line with serializedSean Griffin2014-06-049-20/+29
| | | | | | | | | | `@raw_attributes` should not contain the type-cast, mutable version of the value.
* | Merge pull request #15540 from nbibler/http-headers-setYves Senn2014-06-061-8/+21
|\ \ | | | | | | Use a frozen Set instance for CGI_VARIABLES.
| * | Use a frozen Set instance for CGI_VARIABLES.Nathaniel Bibler2014-06-051-8/+21
| | | | | | | | | Also expand the CGI_VARIABLE name listing to multiple lines for cleaner diffs and legibility.
* | | `bin/rake db:migrate:status` works with legacy migration numbers.Yves Senn2014-06-065-4/+22
| | | | | | | | | | | | | | | | | | | | | The migration numbers were normalized different ways. This left the task output in an inconsistent state. Closes #15538.
* | | docs, update `includes` + `where` example in AR guide. [ci skip]Yves Senn2014-06-061-3/+16
| | | | | | | | | | | | Closes #15541.
* | | Merge pull request #14971 from versioncontrol/#14785Yves Senn2014-06-063-1/+26
|\ \ \ | |/ / |/| | | | | Baseclass becomes! subclass
| * | Fix Baseclass becomes! subclass.Edo Balvers2014-05-133-1/+26
| | |
* | | Merge pull request #15536 from sgrif/sg-remove-whiny-nil-thingRafael Mendonça França2014-06-051-8/+0
|\ \ \ | | | | | | | | Remove optimization that was required with whiny nils
| * | | Remove optimization that was required with whiny nilsSean Griffin2014-06-051-8/+0
| | | | | | | | | | | | | | | | Whiny nils is no longer a thing, so we no longer need this optimization
* | | | Merge pull request #15535 from coreyward/patch-1Rafael Mendonça França2014-06-051-2/+2
|\ \ \ \ | | | | | | | | | | Avoid misuse of underscore argument
| * | | | Avoid misuse of underscore argumentCorey Ward2014-06-051-2/+2
|/ / / / | | | | | | | | Per convention, underscore-only argument names should be used for unused parameters.
* | | | Merge pull request #15530 from zuhao/refactor_actionpack_reloader_testMatthew Draper2014-06-061-0/+5
|\ \ \ \ | | | | | | | | | | Reset callbacks after test.
| * | | | Reset callbacks after test.Zuhao Wan2014-06-051-0/+5
| | | | | | | | | | | | | | | | | | | | Otherwise the state of callback chain is leaked.
* | | | | Merge pull request #15513 from zenspider/remove_flush_output_bufferAaron Patterson2014-06-053-91/+0
|\ \ \ \ \ | | | | | | | | | | | | Removed CaptureHelper#flush_output_buffer as it is only used in tests.
| * | | | | Removed CaptureHelper#flush_output_buffer as it is only used in tests.Ryan Davis2014-06-043-91/+0
| | | | | | | | | | | | | | | | | | | | | | | | reviewed: @tenderlove
* | | | | | Merge pull request #15523 from gregmolnar/doc_fixZachary Scott2014-06-051-1/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | document include_blank's usage with a string [ci skip]
| * | | | | | document include_blank's usage with a string [ci skip]Greg Molnar2014-06-051-1/+4
| | | | | | |
* | | | | | | Merge pull request #15532 from zuhao/refactor_actionpack_response_testYves Senn2014-06-051-2/+4
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Restore Response.default_headers after test.
| * | | | | | | Restore Response.default_headers after test.Zuhao Wan2014-06-051-2/+4
| | |_|_|/ / / | |/| | | | |
* | | | | | | Merge pull request #15531 from zuhao/refactor_actionpack_request_testYves Senn2014-06-051-1/+2
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Avoid hard-coded value in test setup/teardown.
| * | | | | | Avoid hard-coded value in test setup/teardown.Zuhao Wan2014-06-051-1/+2
|/ / / / / /
* | | | | | Merge pull request #15529 from zuhao/refactor_actionpack_mime_type_testYves Senn2014-06-052-8/+0
|\ \ \ \ \ \ | | | | | | | | | | | | | | Make sure Mime::Type is not altered after tests.
| * | | | | | Mime::PNG is already defined.Zuhao Wan2014-06-052-8/+0
| |/ / / / /
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-16 19:55:02 +0000