aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #30927 from y-yagi/remove_unused_fixture_templateRyuta Kamizono2017-10-191-11/+0
|\ | | | | Remove unused `FixtureTemplate` class
| * Remove unused `FixtureTemplate` classyuuji.yaginuma2017-10-191-11/+0
|/ | | | `FixtureTemplate` is no longer used since 3d7892d.
* Merge pull request #30579 from ↵Sean Griffin2017-10-184-12/+83
|\ | | | | | | | | bogdanvlviv/fix_ar_internal_metadata_for_a_test_database Fix `bin/rails db:setup` and `bin/rails db:test:prepare` create wrong ar_internal_metadata's data for a test database.
| * `ActiveRecord::Tasks::DatabaseTasks.load_schema` has always to establish ↵bogdanvlviv2017-10-152-3/+11
| | | | | | | | | | | | | | | | | | | | | | | | database connection When load schema from `structure.sql`, database connection isn't established. `ActiveRecord::Tasks::DatabaseTasks.load_schema` has to establish database connection since it executes ``` ActiveRecord::InternalMetadata.create_table ActiveRecord::InternalMetadata[:environment] = environment ```
| * Fix `bin/rails db:setup` and `bin/rails db:test:prepare` create wrong ↵bogdanvlviv2017-10-154-9/+72
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ar_internal_metadata's data for a test database. Before: ``` $ RAILS_ENV=test rails dbconsole > SELECT * FROM ar_internal_metadata; key|value|created_at|updated_at environment|development|2017-09-11 23:14:10.815679|2017-09-11 23:14:10.815679 ``` After: ``` $ RAILS_ENV=test rails dbconsole > SELECT * FROM ar_internal_metadata; key|value|created_at|updated_at environment|test|2017-09-11 23:14:10.815679|2017-09-11 23:14:10.815679 ``` Fixes #26731.
* | Merge pull request #30923 from rails/chromedriverhelperGuillermo Iguaran2017-10-182-0/+4
|\ \ | | | | | | Improve out-of-box experience with System tests including chromedriver-helper by default
| * | Improve out-of-box experience with System tests including ↵Guillermo Iguaran2017-10-182-0/+4
| | | | | | | | | | | | chromedriver-helper by default
* | | Merge pull request #30918 from yahonda/diag_seed_42296Ryuta Kamizono2017-10-191-0/+2
|\ \ \ | |/ / |/| | Enable `hstore` extention disabled at the end of `test_migrate_enable_and_disable_extension`
| * | Enable `hstore` extention disabled at the end of ↵Yasuo Honda2017-10-181-0/+2
| | | | | | | | | | | | | | | | | | | | | `InvertibleMigrationTest#test_migrate_enable_and_disable_extension` to avoid failure of `PostgresqlArrayTest#test_schema_dump_with_shorthand` which expects `hstore` extension enabled.
* | | Merge pull request #30915 from ↵Ryuta Kamizono2017-10-182-2/+2
|\ \ \ | | | | | | | | | | | | | | | | bogdanvlviv/migration-version-in-bug_report_templates Set proper migration' version in bug report templates
| * | | Set proper migration' version in bug report templatesbogdanvlviv2017-10-182-2/+2
|/ / /
* | | Merge pull request #30914 from ↵Eileen M. Uchitelle2017-10-181-0/+11
|\ \ \ | |/ / |/| | | | | | | | bogdanvlviv/active_record_basics-guides-add-destroy_all Add mention how to delete several records in bulk to Active Record Basics Guides [ci skip]
| * | Add mention how to delete several records in bulk to Active Record Basics ↵bogdanvlviv2017-10-181-0/+11
|/ / | | | | | | Guides [ci skip]
* | Merge pull request #30912 from y-yagi/remove_unused_unknown_controllerRyuta Kamizono2017-10-181-3/+0
|\ \ | | | | | | Remove unused `UnknownController` class
| * | Remove unused `UnknownController` classyuuji.yaginuma2017-10-181-3/+0
| | | | | | | | | | | | `UnknownController` was added in b1999be, but it is not used anywhere.
* | | Merge pull request #30911 from y-yagi/remove_unnecessary_allow_failure_trueRyuta Kamizono2017-10-181-1/+1
|\ \ \ | | | | | | | | Remove unnecessary `allow_failure: true` option
| * | | Remove unnecessary `allow_failure: true` optionyuuji.yaginuma2017-10-181-1/+1
| |/ / | | | | | | | | | | | | `routes` task always returns zero to status, so status is not to non-zeno. Ref: https://github.com/rails/rails/blob/b1867c480dd5476948ff0492ea2f91e2c2fcb04b/railties/lib/rails/tasks/routes.rake#L30
* | | Merge pull request #30910 from y-yagi/fix_typo_in_allow_failure_argumentRyuta Kamizono2017-10-181-1/+1
|\ \ \ | |/ / |/| | Fix typo in `allow_failure` argument [ci skip]
| * | Fix typo in `allow_failure` argument [ci skip]yuuji.yaginuma2017-10-181-1/+1
|/ / | | | | | | Ref: https://github.com/rails/rails/blob/3be123ba26cad461a80d7d680819e71c1388a241/railties/test/isolation/abstract_unit.rb#L243
* | Should test `LegacyPrimaryKeyTest` to both `V5_0` and `V4_2`Ryuta Kamizono2017-10-181-15/+34
| |
* | Merge pull request #30909 from ahorek/compatibility_fixRyuta Kamizono2017-10-182-1/+4
|\ \ | | | | | | 42 compatibility - use int instead of bigint
| * | compatibility - use int instead of bigintpavel2017-10-182-1/+4
| | |
* | | Merge pull request #30876 from y-yagi/selenium_chrome_headlessEileen M. Uchitelle2017-10-176-1/+41
|\ \ \ | |/ / |/| | Add headless chrome driver to System Tests
| * | Add headless chrome driver to System Testsyuuji.yaginuma2017-10-176-1/+41
| | |
* | | Merge pull request #30907 from yhirano55/update_mailing_list_url_in_i18n_guideRyuta Kamizono2017-10-171-3/+3
|\ \ \ | | | | | | | | Update mailing list URL in I18n guide [ci skip]
| * | | Update mailing list URL in I18n guide [ci skip]Yoshiyuki Hirano2017-10-171-3/+3
|/ / /
* | | Merge pull request #30901 from aditya-kapoor/fix-range-to-sSean Griffin2017-10-162-1/+12
|\ \ \ | | | | | | | | Fix `to_s(:db)` for range comprising of alphabets.
| * | | Fix `to_s(:db)` for range comprising of alphabets.Aditya Kapoor2017-10-162-1/+12
|/ / /
* | | Merge pull request #30899 from eugeneius/rm_force_reload_docsGeorge Claghorn2017-10-152-5/+1
|\ \ \ | |_|/ |/| | Remove association(true) references from docs [ci skip]
| * | Remove association(true) references from docs [ci skip]Eugene Kenny2017-10-162-5/+1
|/ / | | | | | | | | Passing `true` to force an association to reload its records from the database was deprecated in 5.0 and removed in 5.1.
* | Remove extra spaces in the args in the `time_zone_select` [ci skip]Ryuta Kamizono2017-10-161-6/+6
| | | | | | | | Follow up of #30862.
* | Merge pull request #30862 from ↵Eileen M. Uchitelle2017-10-151-1/+1
|\ \ | | | | | | | | | | | | yhirano55/remove_needless_space_in_action_view_guide Remove a needless space in Action View Guide [ci skip]
| * | Remove a needless space in Action View Guide [ci skip]Yoshiyuki Hirano2017-10-121-1/+1
| |/
* | Merge pull request #30872 from yhirano55/capitalize_sprockets_in_engine_guideEileen M. Uchitelle2017-10-151-1/+1
|\ \ | | | | | | Capitalize "sprockets" in Engine guide [ci skip]
| * | Capitalize "sprockets" in Engine guide [ci skip]Yoshiyuki Hirano2017-10-131-1/+1
| |/
* | Add a test case that eager-loading with a polymorphic association and using ↵Ryuta Kamizono2017-10-161-0/+4
| | | | | | | | | | | | | | | | | | | | | | `exists?` This test covers the case of 02da8aea. Previously `exists?` was always eager-loading the includes values. But now it is eager-loaded only when necessary since 07a611e0. So the case of the eager-loading had not covered in the test.
* | Fix longer sequence name detection for serial columns (#28339)Ryuta Kamizono2017-10-156-4/+64
| | | | | | | | | | | | | | | | We already found the longer sequence name, but we could not consider whether it was the sequence name created by serial type due to missed a max identifier length limitation. I've addressed the sequence name consideration to respect the max identifier length. Fixes #28332.
* | Merge pull request #30860 from olimart/patch-1Eileen M. Uchitelle2017-10-151-0/+1
|\ \ | | | | | | Update Gemfile with comment for Active Storage group
| * | Update GemfileOlivier2017-10-111-0/+1
| |/
* | MySQL: Don't lose `auto_increment: true` in the `db/schema.rb`Ryuta Kamizono2017-10-153-0/+47
| | | | | | | | | | | | | | | | | | | | Currently `AUTO_INCREMENT` is implicitly used in the default primary key definition. But `AUTO_INCREMENT` is not only used for single column primary key, but also for composite primary key. In that case, `auto_increment: true` should be dumped explicitly in the `db/schema.rb`. Fixes #30894.
* | Merge pull request #30896 from y-yagi/remove_unused_before_filtersRyuta Kamizono2017-10-151-6/+0
|\ \ | | | | | | Remove unused `before_filters`
| * | Remove unused `before_filters`yuuji.yaginuma2017-10-151-6/+0
| | | | | | | | | | | | | | | This method added by 1008511. It is unnecessary because it is no longer called by 19c3495.
* | | Merge pull request #30892 from yhirano55/add_accept_charset_to_form_in_js_guideRyuta Kamizono2017-10-151-1/+1
|\ \ \ | |/ / |/| | Add accept-charset to the output of form_with in JS guide [ci skip]
| * | Add accept-charset to the output of form_with in JS guide [ci skip]Yoshiyuki Hirano2017-10-151-1/+1
|/ /
* | Fix `COUNT(DISTINCT ...)` for `GROUP BY` with `ORDER BY` and `LIMIT`Ryuta Kamizono2017-10-143-1/+11
| | | | | | | | | | | | | | | | | | | | This is the fix for the regression of #29848. In #29848, I've kept existing select list in the subquery for the count if ORDER BY is given. But it had accidentally affect to GROUP BY queries also. It should keep the previous behavior in that case. Fixes #30886.
* | Show the failed queries in `test_has_one_does_not_use_order_by`Ryuta Kamizono2017-10-141-1/+2
| | | | | | | | | | | | For investigating the cause of failure. https://travis-ci.org/rails/rails/jobs/287474883#L797-L799
* | Merge pull request #30889 from ↵Ryuta Kamizono2017-10-141-0/+6
|\ \ | | | | | | | | | | | | yhirano55/add_unpermitted_parameters_hook_to_instrument_guide Add unpermitted_parameters hook to instrumentation guide [ci skip]
| * | Add unpermitted_parameters.action_controller hook to instrument guide [ci skip]Yoshiyuki Hirano2017-10-141-0/+6
| | |
* | | Merge pull request #30888 from y-yagi/fix_test_name_for_daemon_optionGeorge Claghorn2017-10-131-2/+2
|\ \ \ | |/ / |/| | Fix test name for daemon option test
| * | Fix test name for daemon option testyuuji.yaginuma2017-10-141-2/+2
| | | | | | | | | | | | | | | | | | | | | In this test file, "server option" refers to the server used to start Rails(e.g. `puma`, `thin`). But this test, "server option" is not specified. Therefore, I think that it is incorrect that `server_option` is included in the test name.
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-06 03:09:03 +0000