| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| | |
prathamesh-sonpatki/fix-cache-key-for-loaded-empty-collection
Fix ActiveRecord::Relation#cache_key for loaded empty collection
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Before this patch if we try to find cache_key of a loaded but empty
collection it used to give error because of trying to call `updated_at`
on `nil` value generated by
`collection.max_by(×tamp_column).public_send(timestamp_column)`.
- This commit fixes above error by checking if size is greater than zero
or not.
|
|\ \
| | |
| | | |
Fix `ActionController::Parameters#==` bug
|
| | |
| | |
| | |
| | | |
See bug #21032.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
y-yagi/add_application_mailer_rb_to_mountable_engine
add application_mailer.rb to template of mountable engine
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
since 9446e38ba47c9ca3be2ad668d8a8bea0141be6fc, generated mailer inherents from ApplicationMailer,
ApplicationMailer is required in the mountable engine.
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] fix #23157
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This is a similar case to wanting ot use bind params for limit and
offset. Right now passing a range grows the amount of prepared
statements in an unbounded fashion. We could avoid using prepared
statements in that case, similar to what we do with arrays, but there's
a known number of variants for ranges.
This ends up duplicating some of the logic from Arel for how to handle
potentially infinite ranges, and that behavior may be removed from Arel
in the future.
Fixes #23074
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Fix warning introduced in API response fix
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | | |
https://github.com/vipulnsward/rails/commit/77acc004efad07dfd4d4f83be14ef897968a3fd9 when fixing API responses.
- render :text is deprecated, so added an assertion for it.
|
|\ \ \ \
| | | | |
| | | | | |
updating secrets.yml template to use rails command instead of rake
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Improve Docs for ActionController::MimeResponds#respond_to
|
| | | | | |
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Re-add ActionController::ApiRendering
|
| | |/ /
| |/| |
| | | |
| | | |
| | | | |
- Fixes bug #23142.
- Bug was occurring only with ActionController::API, because `_process_options` wasn't being run for API requests, even though it was being run for normal app requests.
|
|\ \ \ \
| |/ / /
|/| | | |
insert newlines into code samples in Upgrading section of Asset Pipeline doc
|
|/ / /
| | |
| | |
| | | |
[ci skip]
|
|\ \ \
| | | |
| | | | |
Fix marking of custom routes for Journey
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The Mapper build_path method marks routes where path parameters are part
of a path segment as custom routes by altering the regular expression, e.g:
get '/foo-:bar', to: 'foo#bar'
There were some edge cases where certain constructs weren't being picked
up and this commit fixes those.
Fixes #23069.
|
|\ \ \ \
| | | | |
| | | | | |
Response etags to always be weak: Prefixed 'W/' to value returned by Act...
|
| | | | |
| | | | |
| | | | |
| | | | | |
ActionDispatch::Http::Cache::Response#etag= such that etags set in fresh_when and stale? are weak. For #17556.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Small doc update per RF [ci skip]
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Add CHANGELOG.md entry for #22950
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
[ci skip]
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | |
| | | | | |
| | | | | | |
gsamokovarov/after-create-update-destroy-commit-docs
Fix the API documentation layout of after_*_commit
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Just noticed this on the [edge API].
[ci skip]
[edge API]: http://edgeapi.rubyonrails.org/classes/ActiveRecord/Transactions/ClassMethods.html
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 5d1b7c3b441654e8008dcd303f5367883ec660a6.
The change here didn't actually fix the issue it was trying to fix, and
this isn't the correct way to fix either issue. The problem is switching
from the builder to grouping with find_all/regex is now very dependent
on how you structure your path pattern.
|
|\ \ \ \
| | | | |
| | | | | |
Changed html_safe to raw in AV
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
of html_safe in favour of raw() in AV helpers.
Also changed usage of html_safe to make use of raw() instead so that the intended behaviour is verified with raw()
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Pluralize counter_cache column name in example [ci skip]
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
Adapterize storage for ActionCable
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- adapter -> pubsub (re)rename internally
- Change variable names to match method names
- Add EventMachine `~> 1.0` as a runtime dependency of ActionCable
- Refactor dependency loading for adapters
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Escape the channel name when subscribing in PG
- Refactor popping the queue to make it easier to read
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We now only create one adapter instance for the server, so it can hold
the listener. This in turn allows the listener to get the PG connection
from the adapter, which will be a good place to allow more flexible
configuration.
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|
| | | | | |
|