| Commit message (Collapse) | Author | Age | Files | Lines | ||
|---|---|---|---|---|---|---|
| ... | ||||||
| | * | | Revert "reminder to run bundle after setting up rails-dev-box" | Vijay Dev | 2012-12-29 | 1 | -7/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 41381c19d1f3920ee9540aff0d35209cb43fb057. Reason: This doesn't quite fit the flow where it's added. Let's add this someplace else if it's explicitly required. [ci skip] | |||||
| | * | | Fixed couple of typos | Fabrizio Regini | 2012-12-27 | 1 | -1/+1 | |
| | | | | ||||||
| | * | | removed TIP: :allow_nil/:allow_blank is ignored by the presence validator | Colin Kelley | 2012-12-26 | 1 | -4/+0 | |
| | | | | | | | | | | | | | These tips were documenting an inconsistency issue https://github.com/rails/rails/issues/8621. That issue is resolved by https://github.com/rails/rails/issues/8622. | |||||
| | * | | reminder to run bundle after setting up rails-dev-box | Ace Suares | 2012-12-24 | 1 | -0/+7 | |
| | | | | ||||||
| | * | | Add rake test description | sanemat | 2012-12-24 | 1 | -0/+2 | |
| | | | | ||||||
| | * | | Add rake default to description | sanemat | 2012-12-24 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | Merge pull request #8641 from arunagw/warning_removed_unused_var | Steve Klabnik | 2012-12-28 | 1 | -1/+2 | |
| |\ \ \ | | | | | | | | | Remove 'assigned but unused variable' warning | |||||
| | * | | | Remove 'assigned but unused variable' warning | Arun Agrawal | 2012-12-28 | 1 | -1/+2 | |
| | | | | | ||||||
| * | | | | Introduce assert_not to replace 'assert !foo' | Jeremy Kemper | 2012-12-28 | 3 | -0/+39 | |
| |/ / / | ||||||
| * | | | Consistent punctuation for @jaroslawr :bowtie: | Jeremy Kemper | 2012-12-27 | 1 | -1/+1 | |
| | | | | ||||||
| * | | | Merge pull request #8634 from senny/rewrite_order_dependent_test_case | Rafael Mendonça França | 2012-12-27 | 1 | -1/+2 | |
| |\ \ \ | | | | | | | | | rewrite order dependent test case | |||||
| | * | | | rewrite order dependent test case. #8185 | Yves Senn | 2012-12-27 | 1 | -1/+2 | |
| |/ / / | | | | | | | | | | | | | | | | As reported (https://github.com/rails/rails/pull/8185#issuecomment-11702226) this test relied on the order a hash was serialized. Comparing the parsed hash makes the test no longer order dependent. | |||||
| * | | | Merge pull request #8627 from schneems/schneems/routes-1-9 | Rafael Mendonça França | 2012-12-26 | 1 | -1/+1 | |
| |\ \ \ | | | | | | | | | Ruby 1.9 style hash in Route Inspector | |||||
| | * | | | Ruby 1.9 style hash in Route Inspector | schneems | 2012-12-27 | 1 | -1/+1 | |
| | | | | | ||||||
| * | | | | Make test logs easier to read. | Jeremy Kemper | 2012-12-26 | 2 | -13/+11 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | Tagging every message in tests makes the logs really wide. It's great for grepping, but annoying to open in an editor or a narrow terminal. Try out a different approach: spit out a heading before each test. | |||||
| * | | | | Extract the component rendering of collection_radio_buttons and | Rafael Mendonça França | 2012-12-26 | 2 | -2/+14 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | collection_check_boxes to a private method. It will make easier to extend. Example: class CollectionRadioButtons < ActionView::Helpers::Tags::CollectionRadioButtons include CollectionExtensions def render wrap_rendered_collection(super, @options) end private def render_component(builder) builder.radio_button + builder.label(:class => "collection_radio_buttons") end end | |||||
| * | | | | Fix collection_radio_buttons with the option `:checked` with value of | Rafael Mendonça França | 2012-12-26 | 2 | -1/+8 | |
| | | | | | | | | | | | | | | | | | `false` | |||||
| * | | | | This change doesn't need a CHANGELOG entry. | Rafael Mendonça França | 2012-12-26 | 1 | -5/+0 | |
| | | | | | | | | | | | | | | | | | [ci skip] | |||||
| * | | | | Add CHANGELOG entry for #8622 | Rafael Mendonça França | 2012-12-26 | 2 | -2/+7 | |
| | | | | | ||||||
| * | | | | Merge pull request #8598 from NARKOZ/refactor-highlight | Santiago Pastorino | 2012-12-26 | 1 | -2/+2 | |
| |\ \ \ \ | | | | | | | | | | | refactor highlight method: return fast if text or phrases are blank | |||||
| | * | | | | fetch highlighter option only when needed | Nihad Abbasov | 2012-12-24 | 1 | -2/+2 | |
| | | | | | | ||||||
| * | | | | | Revert the change at ActiveModel::Errors#add_on_blank and fix in the | Rafael Mendonça França | 2012-12-26 | 3 | -14/+8 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | right place. The EachValidator#validate already handle :allow_blank and :allow_nil, correctly. Closes #8622. Fix #8621. | |||||
| * | | | | | Tests and fix for validates_presence of :allow_nil, :allow_blank | Colin Kelley | 2012-12-26 | 2 | -1/+41 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: activemodel/lib/active_model/errors.rb | |||||
| * | | | | | Note about migration timestamps. | Steve Klabnik | 2012-12-26 | 1 | -1/+3 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We should mention that the ordering matters with regards to timestamps, and not imply that it's just for uniqueness purposes. Closes #8610. | |||||
| * | | | | | Consistent use of single and double quotes | Rafael Mendonça França | 2012-12-26 | 1 | -10/+10 | |
| | | | | | | ||||||
| * | | | | | Merge pull request #8616 from senny/8612_respect_yaml_keywords | Rafael Mendonça França | 2012-12-26 | 4 | -7/+48 | |
| |\ \ \ \ \ | | | | | | | | | | | | | quote column names in generated fixture files | |||||
| | * | | | | | quote column names in generated fixture files | Yves Senn | 2012-12-26 | 4 | -7/+48 | |
| | | | | | | | ||||||
| * | | | | | | Fix CHANGELOG style [ci skip] | Rafael Mendonça França | 2012-12-26 | 2 | -6/+6 | |
| | | | | | | | ||||||
| * | | | | | | Merge pull request #5100 from ↵ | Rafael Mendonça França | 2012-12-26 | 3 | -6/+29 | |
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | paukul/validate_on_condition_on_transaction_callbacks Validate :on option on after_commit and after_rollback callbacks | |||||
| | * | | | | | | validate :on option on after_commit and after_rollback callbacks | Pascal Friederich | 2012-12-26 | 3 | -6/+29 | |
| | | | | | | | | ||||||
| * | | | | | | | We need to check explictly that env['action_dispatch.show_exceptions'] | Rafael Mendonça França | 2012-12-26 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | is false. If it is nil we can't raise the exception | |||||
| * | | | | | | | Merge pull request #8600 from shime/patch-1 | Rafael Mendonça França | 2012-12-26 | 1 | -4/+3 | |
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | more descriptive return parameters | |||||
| | * | | | | | | | more descriptive return parameters | Hrvoje Šimić | 2012-12-26 | 1 | -4/+3 | |
| | | | | | | | | | ||||||
| * | | | | | | | | Revert "Ignore /bin on new apps" -- given the move to default binstubs, we ↵ | David Heinemeier Hansson | 2012-12-26 | 1 | -4/+3 | |
| | |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | want you to check those in! This reverts commit 35c554f0bf518e1068e79002a462c3deba649e9b. | |||||
| * | | | | | | | Merge pull request #8608 from ↵ | Rafael Mendonça França | 2012-12-25 | 2 | -1/+19 | |
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | senny/8576_cant_inherit_from_deprecated_buffered_logger deprecation warning when BufferedLogger is instantiated | |||||
| | * | | | | | | | deprecation warning when BufferedLogger is instantiated | Yves Senn | 2012-12-25 | 2 | -1/+19 | |
| | | |/ / / / / | |/| | | | | | ||||||
| * | | | | | | | Merge pull request #8609 from senny/buffered_logger_documentation | Guillermo Iguaran | 2012-12-25 | 3 | -5/+5 | |
| |\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | replace AS::BufferedLogger doc mentions with AS::Logger | |||||
| | * | | | | | | replace AS::BufferedLogger doc mentions with AS::Logger | Yves Senn | 2012-12-25 | 3 | -5/+5 | |
| |/ / / / / / | ||||||
| * | | | | | | Merge pull request #8607 from ↵ | Rafael Mendonça França | 2012-12-25 | 2 | -2/+20 | |
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | senny/8576_cant_inherit_from_deprecated_buffered_logger ActiveSupport::BufferedLogger can be subclassed | |||||
| | * | | | | | | ActiveSupport::BufferedLogger can be subclassed | Yves Senn | 2012-12-25 | 2 | -2/+20 | |
| |/ / / / / / | ||||||
| * | | | | | | Merge pull request #8592 from rafaelfranca/warning_fix | Guillermo Iguaran | 2012-12-24 | 1 | -1/+5 | |
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | Remove warning of intance variable not initialized | |||||
| | * | | | | | | Remove warning of intance variable not initialized | Rafael Mendonça França | 2012-12-23 | 1 | -1/+5 | |
| | | | | | | | | ||||||
| * | | | | | | | Merge pull request #8604 from zoltankiss/minor_fixes | Guillermo Iguaran | 2012-12-24 | 1 | -1/+1 | |
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | minor grammar fix | |||||
| | * | | | | | | | minor grammar fix | Zoltan Kiss | 2012-12-24 | 1 | -1/+1 | |
| |/ / / / / / / | ||||||
| * | | / / / / | silences "possibly useless use of :: in void context" warnings | Xavier Noria | 2012-12-24 | 1 | -7/+3 | |
| | |_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The AS utility silence_warnings does not really silence this one, because it is issued at parse-time. It seemed to in some places because the constant was the only expression in the block and therefore it was its return value, that could potentially be used by silence_warnings are return value of the yield call. To bypass the warning we assign to a variable. The chosen variable is "_" because it is special-cased in parse.c not to issue an "assigned but unused variable" warning in turn. | |||||
| * | | | | | | Merge pull request #8601 from amatsuda/chmod_x | Rafael Mendonça França | 2012-12-24 | 2 | -0/+0 | |
| |\ \ \ \ \ \ | |_|/ / / / |/| | | | | | chmod -x from non-script files | |||||
| | * | | | | | chmod -x from non-script files | Akira Matsuda | 2012-12-24 | 2 | -0/+0 | |
| |/ / / / / | ||||||
| * | | | | | Merge pull request #8595 from amatsuda/regex_warning | Rafael Mendonça França | 2012-12-23 | 1 | -1/+1 | |
| |\ \ \ \ \ | | | | | | | | | | | | | "warning: ambiguous first argument; put parentheses or even spaces" | |||||
| | * | | | | | "warning: ambiguous first argument; put parentheses or even spaces" | Akira Matsuda | 2012-12-24 | 1 | -1/+1 | |
| |/ / / / / | ||||||
| * | | | | | Merge pull request #8594 from amatsuda/rm_sqlite2 | Guillermo Iguaran | 2012-12-23 | 1 | -13/+5 | |
| |\ \ \ \ \ | | | | | | | | | | | | | I don't think we're supporting SQLite 2 | |||||
 |
index : rails.git | |
| Mirror of official rails repo with custom fixes. | Harald Eilertsen |
| aboutsummaryrefslogtreecommitdiffstats |