aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix precompile asset_host testGuillermo Iguaran2011-09-131-1/+1
|
* Merge pull request #3000 from guilleiguaran/fix-relative-url-rootSantiago Pastorino2011-09-131-4/+2
|\ | | | | Fix for relative url root in assets
| * Fix for relative url root in assetsGuillermo Iguaran2011-09-131-4/+2
|/
* Merge pull request #2996 from guilleiguaran/move-assets-testsSantiago Pastorino2011-09-132-31/+31
|\ | | | | Move asset tests to assets_test file
| * Move asset tests to assets_test fileGuillermo Iguaran2011-09-132-31/+31
| |
* | always rewrite_relative_url_rootSantiago Pastorino2011-09-132-6/+2
|/
* Merge pull request #2993 from deepakprasanna/generator_test_fixSantiago Pastorino2011-09-121-1/+1
|\ | | | | fixed the failing generators_test in railties.
| * fixed the failing generators_testDeepak Prasanna2011-09-131-1/+1
|/
* Merge pull request #2977 from guilleiguaran/fix-relative-root-in-assetsSantiago Pastorino2011-09-123-3/+22
|\ | | | | Set relative url root in assets when controller isn't available for Sprockets
| * Set relative url root in assets when controller isn't available for ↵Guillermo Iguaran2011-09-133-3/+22
| | | | | | | | | | | | Sprockets. Fix #2435 See https://github.com/rails/sass-rails/issues/42 for details
* | Merge pull request #2987 from kennyj/masterSantiago Pastorino2011-09-122-0/+19
|\ \ | | | | | | fix https://github.com/rails/rails/issues/2947 (with testcase)
| * | fix https://github.com/rails/rails/issues/2947 (with testcase)kennyj2011-09-132-0/+19
| | |
* | | removing backwards compatibility moduleAaron Patterson2011-09-123-9/+8
| | |
* | | point rails at Journey for dev and edgeAaron Patterson2011-09-122-0/+3
| | |
* | | partially expand the parameters to `match`Aaron Patterson2011-09-121-3/+3
| | |
* | | unfactor the Route class to private factory methodsAaron Patterson2011-09-122-45/+42
| | |
* | | reduce dependencies of external objects in the Route classAaron Patterson2011-09-122-16/+18
| | |
* | | delete unused code, pass path explicitly to journeyAaron Patterson2011-09-122-28/+7
| | |
* | | adjust route inspection to work with JourneyAaron Patterson2011-09-121-1/+2
| | |
* | | all routes can be stored in the Journey Routes objectAaron Patterson2011-09-123-6/+6
| | |
* | | clear! does not need to be called from initializeAaron Patterson2011-09-121-4/+3
| | |
* | | reuse the route collection and formatter by clearing themAaron Patterson2011-09-121-6/+10
| | |
* | | Instantiate each part of our routing system:Aaron Patterson2011-09-121-7/+8
| | | | | | | | | | | | | | | | | | * A collection of Routes * The Router, which consults the collection of routes * A formatter that consults the collection of routes
* | | stop freezing the routesAaron Patterson2011-09-121-1/+0
| | |
* | | stop using a hash for parameterizingAaron Patterson2011-09-121-11/+9
| | |
* | | Switching rack-mount to journey.Aaron Patterson2011-09-123-2/+10
| | |
* | | Deprecate using method_missing for attributes that are columns.Jon Leighton2011-09-132-0/+30
| | | | | | | | | | | | | | | | | | This shouldn't ever happen unless people are doing something particularly weird, but adding a deprecation in case there are bugs not caught by our tests.
* | | Add an attribute_missing method to ActiveModel::AttributeMethods.Jon Leighton2011-09-132-8/+26
| | | | | | | | | | | | This can be overloaded by implementors if necessary.
* | | Avoid double super call in some cases.Jon Leighton2011-09-131-5/+4
| | | | | | | | | | | | | | | If super was false earlier, it is still going to be false, so we don't need to call it again at the end of the method.
* | | Let Ruby deal with method visibility.Jon Leighton2011-09-134-23/+60
| | | | | | | | | | | | | | | | | | Check respond_to_without_attributes? in method_missing. If there is any method that responds (even private), let super handle it and raise NoMethodError if necessary.
* | | Reset column info when messing with columns.Jon Leighton2011-09-131-0/+2
| | | | | | | | | | | | | | | | | | | | | We are subclassing Session here, but messing with the columns will affect the attribute methods defined on the Session superclass, and therefore other tests, unless we properly isolate it by resetting column info before and after the test run.
* | | Always generate attribute methods on the base class.Jon Leighton2011-09-134-6/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a situation I encountered where a subclass would cache the name of a generated attribute method in @_defined_class_methods. Then, when the superclass has it's attribute methods undefined, the subclass would always have to dispatch through method_missing, because the presence of the attribute in @_defined_class_methods would mean that it is never generated again, even if undefine_attribute_methods is called on the subclass. There various other confusing edge cases like this. STI classes share columns, so let's just keep all the attribute method generation state isolated to the base class.
* | | Raise error when using write_attribute with a non-existent attribute.Jon Leighton2011-09-138-25/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | Previously we would just silently write the attribute. This can lead to subtle bugs (for example, see the change in AutosaveAssociation where a through association would wrongly gain an attribute. Also, ensuring that we never gain any new attributes after initialization will allow me to reduce our dependence on method_missing.
* | | Make protected method public so we avoid method_missing.Jon Leighton2011-09-131-4/+5
| | |
* | | Fix warnings.Jon Leighton2011-09-131-1/+1
| | | | | | | | | | | | Make sure we don't redefine an already-defined attribute method.
* | | Add deprecation for doing `attribute_method_suffix ''`Jon Leighton2011-09-133-8/+22
| | |
* | | refactoringJon Leighton2011-09-131-19/+11
| | |
* | | Use an empty AttributeMethodMatcher by default.Jon Leighton2011-09-132-2/+26
| | | | | | | | | | | | | | | | | | This means that attribute methods which don't exist will get generated when define_attribute_methods is called, so we don't have to use hacks like `attribute_method_suffix ''`.
* | | Alias id= if necessary, rather than relying on method_missingJon Leighton2011-09-131-0/+4
| | |
* | | Merge pull request #2988 from guilleiguaran/remove-extra-lineSantiago Pastorino2011-09-121-1/+0
|\ \ \ | | | | | | | | Remove odd asignation
| * | | Remove odd asignationGuillermo Iguaran2011-09-121-1/+0
|/ / /
* | | Use the proper executable on tests.José Valim2011-09-121-1/+1
| | |
* | | Merge pull request #2985 from kennyj/masterSantiago Pastorino2011-09-122-1/+17
|\| | | | | | | | fix https://github.com/rails/rails/issues/2582 (with testcase)
| * | fix https://github.com/rails/rails/issues/2582 (with testcase)kennyj2011-09-132-2/+18
| | |
* | | Merge pull request #2678 from jmileham/ares_content_length_bugJon Leighton2011-09-122-4/+36
|\ \ \ | | | | | | | | ActiveResource shouldn't rely on the presence of Content-Length
| * | | ActiveResource shouldn't rely on the presence of Content-LengthJohn Mileham2011-09-111-1/+9
| | | |
| * | | Failing test: ActiveResource shouldn't rely on the presence of Content-LengthJohn Mileham2011-09-091-3/+27
| | | |
* | | | Just provide the executable for railtie. This should be fine since Rubygems ↵José Valim2011-09-123-9/+7
| | | | | | | | | | | | | | | | now warns before overriding them.
* | | | Merge pull request #2984 from jrgifford/masterXavier Noria2011-09-1289-0/+1417
|\ \ \ \ | | | | | | | | | | Added getting_started application to railties/guides/code/getting_started
| * | | | Added getting_started code, updated guide with link to rails github repo and ↵James Gifford2011-09-1289-0/+1417
|/ / / / | | | | | | | | | | | | path to code
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-09 09:56:14 +0000