| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \
| |/ / /
|/| | | |
Adds more clarity on how to use custom rake tasks with arguments passed to it [ci skip]
|
|/ / /
| | |
| | |
| | | |
[ci skip]
|
|\ \ \
| | | |
| | | | |
[skip ci] Fix typos in guides
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
[skip ci] Fix typo in actionmailer documentation
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
[ci skip] Fix dead link
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
getting_started.html#the-mvc-architecture is lost by this commit
2f06c94e38a116fdfa43d7b7117e6bf911a0bff5 (Mar 14 2012 !).
So replace it with wikipedia link.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If there was a polymorphic hm:t association with a scope AND second
non-scoped hm:t association on a model the polymorphic scope would leak
through into the call for the non-polymorhic hm:t association.
This would only break if `hotel.drink_designers` was called before
`hotel.recipes`. If `hotel.recipes` was called first there would be
no problem with the SQL.
Before (employable_type should not be here):
```
SELECT COUNT(*) FROM "drink_designers" INNER JOIN "chefs" ON
"drink_designers"."id" = "chefs"."employable_id" INNER JOIN
"departments" ON "chefs"."department_id" = "departments"."id" WHERE
"departments"."hotel_id" = ? AND "chefs"."employable_type" = ?
[["hotel_id", 1], ["employable_type", "DrinkDesigner"]]
```
After:
```
SELECT COUNT(*) FROM "recipes" INNER JOIN "chefs" ON "recipes"."chef_id"
= "chefs"."id" INNER JOIN "departments" ON "chefs"."department_id" =
"departments"."id" WHERE "departments"."hotel_id" = ? [["hotel_id", 1]]
```
From the SQL you can see that `employable_type` was leaking through when
calling recipes. The solution is to dup the chain of the polymorphic
association so it doesn't get cached. Additionally, this follows
`scope_chain` which dup's the `source_reflection`'s `scope_chain`.
This required another model/table/relationship because the leak only
happens on a hm:t polymorphic that's called before another hm:t on the
same model.
I am specifically testing the SQL here instead of the number of records
becasue the test could pass if there was 1 drink designer recipe for the
drink designer chef even though the `employable_type` was leaking through.
This needs to specifically check that `employable_type` is not in the SQL
statement.
|
|\ \ \
| | | |
| | | | |
add mailer suffix to comments for email previews
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
[ci skip]Doc fix about association hierarchy
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
Cleaning actionview tests
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Fix typo in Action Pack changelog
|
|/ / / |
|
|\ \ \
| | | |
| | | | |
[ci skip] Subject-verb agreement
|
|/ / / |
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
AndrewHendrie/AndrewHendrie-guides-testing-partials-patch
Asserting partials modification
|
| | | |
| | | |
| | | | |
Changed "create Articles view" to "new article view". The create action doesn't typically have a view assigned to it. The view that's being referred to is the 'new' Article view.
|
|\ \ \ \
| | | | |
| | | | | |
Add `rake initializer`
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This task prints out initializers for an application. It is useful to
develop a rubygem which involves the initialization process.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Closes #19321. [ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Return truthy value from head method
|
| | |_|/ /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | | |
It was returning false in normal circumstances.
This broke the `head :ok and return if` construct.
Add appropriate test.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
`QueueAdapters` now does lazy lookup
|
| | | | | | |
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | |
| | | | | | |
Update sprockets links to point to rails org
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[ci skip] correct output of select
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[CI SKIP] Correct output of options_for_select
|
|/ / / / / |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Fix typo in the Testing Your Mailers docs
|
|/ / / /
| | | |
| | | | |
* [ci skip]
|
|\ \ \ \
| | | | |
| | | | | |
Use request.session.id instead of request.session_options[:id]
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
As of the upgrade to Rack 1.5, request.session_options[:id] is no
longer populated. Reflect this change in the tests by using
request.session.id instead.
Related change in Rack:
https://github.com/rack/rack/commit/83a270d6
|
|\ \ \ \
| | | | |
| | | | | |
Use a more conservative `const_get` over `constantize`
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
304 response should not include Content-Type header
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Rack::Lint raises an error saying "Content-Type header found in 304
response, not allowed".
|
|\ \ \ \ \
| | | | | |
| | | | | | |
[ci skip] Take NOTE: as paragraph to make NOTE block
|
|/ / / / / |
|