| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This should fix travis. For real this time! This is the one!
The readpartial(100) meant that an earlier assert_stdout could chomp up
the output that a later assert_stdout wants, meaning that the later
assertion fails.
Reading only 1 byte at a time ensure that we don't read any more than is
necessary to verify the assertion.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Use "Fixes" in place of "Fix" in changelogs for consistency [ci skip]
|
|/ / / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Update documentation for collection<< to reflect behavior for new parent objects.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
collection<< does not automatically fire update sql unless the parent object
is not a new record (and thus has a primary key).
eg:
p = Post.new
p.comments << Comment.new
does not call update sql until:
p.save
at which point it saves the parent object and then the collection object.
changes that to the
|
|\ \ \ \ \ \
| |_|_|_|/ /
|/| | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This replicates the situation described in
https://github.com/rails/strong_parameters/issues/114
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
this was pulled out of Rails 4, see rails/rails#8399 for the discussion
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | | |
if there's content for the right column, then we need the two-column class, if not the one-column
|
| | |_|_|/
| |/| | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This should fix travis.
Also ensuring that we don't try to kill when pid is nil.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Renumbering the comments in the application boot process.
|
|/ / / / / |
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
ensure response.stream is closed
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
Preserve magic comments and content encoding of copied migrations.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
During insertion of "# This migration comes from ... " comment at the beginning of
a migration, presence of magic comment was not considered.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix incorrectly appended square brackets to a multiple select box
Before:
select(:category, [], {}, {:multiple => true, :name => "post[category][]"})
# => <select name="post[category][][]" ...>
After:
select(:category, [], {}, {:multiple => true, :name => "post[category][]"})
# => <select name="post[category][]" ...>
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
If an explicit name has been given and it already ends with "[]"
Before:
select(:category, [], {}, multiple: true, name: "post[category][]")
# => <select name="post[category][][]" ...>
After:
select(:category, [], {}, multiple: true, name: "post[category][]")
# => <select name="post[category][]" ...>
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
Remove extra whitespace and fix a comment
|
|/ / / / /
| | | | |
| | | | | |
minor comment fix for consistency
|
| |_|_|/
|/| | |
| | | |
| | | | |
Introduced in be3e10cd26bc8ec29c6474d03a08a8e733108e7d.
|
|\ \ \ \
| | | | |
| | | | | |
Add rake test description
|
| | | | |
| | | | |
| | | | |
| | | | | |
No behavior change
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
wangjohn/refactoring_nested_associations_for_readability
Refactored nested associations so they are more readable.
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
which make it clearer about what's going on.
|
| | | | |
| | | | |
| | | | |
| | | | | |
[ci skip]
|
| | | | |
| | | | |
| | | | |
| | | | | |
Thanks @neerajdotname for noticing this bug.
|
| | | | | |
|
| | | | | |
|
|\ \ \ \ \
| |_|/ / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fix ActiveRecord `subclass_from_attrs` when eager_load is false.
Conflicts:
activerecord/CHANGELOG.md
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
It cannot find subclass because all classes are loaded automatically
when it needs.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Refactored test case with standard variable names
|
|/ / / / / |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
I've also added a proper acceptance test which reproduced the issue.
Closes #9513, #9515.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Use the index name explicitly provided in a migration when reverting.
Fixes #8868
Conflicts:
activerecord/CHANGELOG.md
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
schema_statements uses the column name by default to construct the index name, and then raises an exception if it doesn't exist, even if the name option is specified, which causes #8858. this commit makes index_name_for_remove fall back to constructing the index name to remove based on the name option.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
cfabianski/disable_prepared_statement_when_preparing_a_query
Unprepared Visitor + unprepared_statement
Conflicts:
activerecord/CHANGELOG.md
|
| |/ / / / / |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Using latest AR-JDBC for JRuby
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Introduced in f1082b8588a9144eedb34d511f0074031f692d98.
Full changelog in 9f007d7fe5f90257c71baa2c4e7c76fb44512986.
[ci skip]
|
| | | | | | |
|