aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Bring back the test cases for `presence`Godfrey Chan2014-08-291-0/+5
| | | | | | | | | | | | This was removed by mistake in 5e51bdd
* | | Forgot to set Migration.verbose at f8d9a51949d6f6cfcab7cc7d501e137836eb88dc ↵Akira Matsuda2014-08-301-1/+1
| | | | | | | | | | | | :bomb:
* | | reduce object allocations in utc_offsetAaron Patterson2014-08-291-2/+2
| | | | | | | | | | | | | | | | | | `try` allocates an array on every call, we should avoid calling it in hotspots. This reduced AttributeMethodsTest#test_setting_time_zone_aware_attribute_with_string from 18k allocations to 14k
* | | We tenderized the wrong method! Object#try already had the yield option, ↵David Heinemeier Hansson2014-08-295-34/+20
| | | | | | | | | | | | just needed some tenderloving instance_eval to fit the bill
* | | Clarify the origin of this great addition to Rails :trollface: :trollface ↵David Heinemeier Hansson2014-08-291-1/+1
| | | | | | | | | | | | :trollface:
* | | Use instance_eval on @tenderlove's suggestion :trollface:David Heinemeier Hansson2014-08-293-7/+8
| | |
* | | Update examples to show real worthDavid Heinemeier Hansson2014-08-292-2/+11
| | |
* | | Added yield to Object#presenceDavid Heinemeier Hansson2014-08-293-1/+23
| | |
* | | Merge branch 'master' of github.com:rails/railsDavid Heinemeier Hansson2014-08-29181-1044/+1779
|\ \ \
| * \ \ Merge pull request #16746 from cristianbica/fix-backburner-adapterGodfrey Chan2014-08-291-1/+1
| |\ \ \ | | | | | | | | | | Fixed Active Job Backburner adapter
| | * | | Fixed Active Job Backburner adapterCristian Bica2014-08-301-1/+1
| |/ / /
| * | | Don't allow AR::Tasks::DatabaseTasks.migrate to mutate Migration.verbose valueAkira Matsuda2014-08-301-1/+3
| | | | | | | | | | | | | | | | This fixes random test failure in migrator_test.rb
| * | | Merge pull request #16741 from robin850/am-isolated-wo-bundleSantiago Pastorino2014-08-291-3/+2
| |\ \ \ | | | | | | | | | | Make test:isolated run without bundler for Action Mailer
| | * | | Make test:isolated run without bundler for Action MailerRobin Dupret2014-08-291-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Action Mailer tests weren't able to run in isolation without the bundle exec prefix since we were requiring gems before requiring abstract_unit. We don't need the `gem` call thus and the require_relative since the test directory should be present in the load path when we run any test.
| * | | | Merge pull request #16742 from robin850/rbx-aj-sidekiqSantiago Pastorino2014-08-291-8/+2
| |\ \ \ \ | | |/ / / | |/| | | Avoid skipping Sidekiq tests on Rubinius
| | * | | Avoid skipping Sidekiq tests on RubiniusRobin Dupret2014-08-291-8/+2
| |/ / / | | | | | | | | | | | | | | | | Now that Travis provides support for Rubinius 2.2.10, we can run the Sidekiq tests against this version.
| * | | Some documentation fixes [ci skip]Robin Dupret2014-08-293-10/+10
| | | |
| * | | Don't test PostgreSQL implementation detailsAkira Matsuda & Kohei Suzuki2014-08-291-3/+0
| | | | | | | | | | | | | | | | | | | | Asserting that the message contains "QUERY PLAN" is enough for the adapter's test. The plan may vary according to number of tuples etc. but that's out of our concern.
| * | | Merge pull request #16740 from seuros/activejobYves Senn2014-08-295-20/+25
| |\ \ \ | | | | | | | | | | [ActiveJob] extract JobBuffer from helper
| | * | | [ActiveJob] extract JobBuffer from helperAbdelkader Boudih2014-08-295-20/+25
| |/ / /
| * | | Revert "Merge pull request #16254 from ↵Yves Senn2014-08-291-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | zuhao/refactor_activerecord_attribute_decorators_test" This reverts commit 16fe19831548f108c113094d106663497fc190d5, reversing changes made to 4c81c8ce533896be28bdc0b055ff30bb9dee1316. The call to `Model.reset_column_information` was to express the intent of the test. `reset_column_information` itself can trigger SQL queries because it checks for a tables existance. Let's move it outside of the block. /cc @sgrif
| * | | Merge pull request #16739 from y-yagi/patch-6Yves Senn2014-08-292-2/+2
| |\ \ \ | | | | | | | | | | [ci skip] Fix example code of ActiveRecord::FixtureSet.context_class
| | * | | [ci skip] Fix example code of ActiveRecord::FixtureSet.context_classyuuji.yaginuma2014-08-292-2/+2
| | | | |
| * | | | Merge pull request #16728 from splattael/invalid_address_errorYves Senn2014-08-292-1/+8
| |\ \ \ \ | | |/ / / | |/| | | Don't rescue IPAddr::InvalidAddressError
| | * | | Don't rescue IPAddr::InvalidAddressErrorPeter Suschlik2014-08-292-1/+8
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | IPAddr::InvalidAddressError does not exist in Ruby 1.9.3 and fails for JRuby in 1.9 mode. As IPAddr::InvalidAddressError is a subclass of ArgumentError (via IPAddr::Error) just rescuing ArgumentError is fine.
| * | | Reset ActiveRecord::Migration.message_count counter before start testingAkira Matsuda2014-08-291-1/+1
| | | |
| * | | Bring original puts back after finishing testsAkira Matsuda2014-08-292-4/+12
| | | |
| * | | Silence another test that runs migrationsAkira Matsuda2014-08-291-0/+5
| | | |
| * | | MigrationTest doesn't need to be verbose anymoreAkira Matsuda2014-08-291-1/+1
| | | |
| * | | No tests are dealing with ActiveRecord::Migration.message_count here anymoreAkira Matsuda2014-08-291-1/+0
| | | |
| * | | Reset ActiveRecord::Migration.verbose to the value beforeAkira Matsuda2014-08-292-2/+5
| | | |
| * | | Demodulize ActiveRecord::MigratorTestAkira Matsuda2014-08-291-284/+282
| | | |
| * | | Merge pull request #16637 from Agis-/redirect-with-constraint-routeAaron Patterson2014-08-283-2/+31
| |\ \ \ | | | | | | | | | | Fix the router ignoring constraints when used together with a redirect route
| | * | | Don't ignore constraints in redirect routesAgis-2014-08-253-2/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/rails/rails/commit/402c2af55053c2f29319091ad21fd6fa6b90ee89 introduced a regression that caused any constraints added to redirect routes to be ignored. Fixes #16605
| * | | | Avoid using heredoc for user warningsGodfrey Chan2014-08-2810-61/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using heredoc would enforce line wrapping to whatever column width we decided to use in the code, making it difficult for the users to read on some consoles. This does make the source code read slightly worse and a bit more error-prone, but this seems like a fair price to pay since the primary purpose for these messages are for the users to read and the code will not stick around for too long.
| * | | | No transaction for a test that creates fixtures in the test bodyAkira Matsuda2014-08-291-0/+1
| | | | |
| * | | | make it easy to copy & paste the config from deprecation warning.Yves Senn2014-08-281-2/+3
| | | | | | | | | | | | | | | | | | | | [ci skip]
| * | | | User Model#last to certainly get lastly created dataAkira Matsuda2014-08-281-1/+1
| | | | | | | | | | | | | | | | | | | | This test would fail when executed after any test that calls fixtures(:binaries)
| * | | | Move model definition to test/models for test order indenendencyAkira Matsuda2014-08-283-29/+15
| | | | |
| * | | | Move association definition to the model fileAkira Matsuda2014-08-282-2/+1
| | | | |
| * | | | Be sure that test fixtures satisfy referential integrity before calculatingAkira Matsuda2014-08-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There exists some other test files that load :minivans fixtures but don't load :speedometers. Loading :speedometers here prevents the following error when this test was run after such test: CalculationsTest#test_should_group_by_association_with_non_numeric_foreign_key: ActiveRecord::RecordNotFound: Couldn't find all Speedometers with 'speedometer_id': (ABC, s1) (found 1 results, but was looking for 2)
| * | | | Expectations firstAkira Matsuda2014-08-284-9/+9
| | | | |
| * | | | Reset RACK_ENV after modified in a test caseAkira Matsuda2014-08-281-0/+1
| | | | |
| * | | | Rails.root should be a PathnameAkira Matsuda2014-08-281-1/+1
| | | | |
| * | | | No need to sort testsAkira Matsuda2014-08-283-3/+3
| | | | | | | | | | | | | | | | | | | | Dir.glob result must be already sorted anyway
| * | | | Test everythingAkira Matsuda2014-08-281-1/+1
| | | | | | | | | | | | | | | | | | | | This actually was testing test everything, so why not do it simpler?
| * | | | AP test files does no more need to be alphabetically sorted hereAkira Matsuda2014-08-281-4/+1
| | | | |
| * | | | Ignore SCHEMA queries when asserting no queriesAkira Matsuda2014-08-285-22/+22
| | | | |
| * | | | Reset schema properly after schema changing testAkira Matsuda2014-08-281-0/+2
| | | | |
| * | | | Merge pull request #16727 from BanzaiMan/travis-yml-fixRafael Mendonça França2014-08-271-0/+1
| |\ \ \ \ | | | | | | | | | | | | Add language directive to .travis.yml
generated by cgit v1.2.3 (git 2.25.1) at 2025-03-23 22:12:47 +0000