| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Follow up to 8b69f1e
|
|\
| |
| | |
Add `quoted_time` for truncating the date part of a time column value
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Context #24522.
TIME column on MariaDB doesn't ignore the date part of the string when
it coerces to time.
```
root@localhost [test] > CREATE TABLE `foos` (`id` int AUTO_INCREMENT PRIMARY KEY, `start` time(0), `finish` time(4)) ENGINE=InnoDB;
Query OK, 0 rows affected (0.02 sec)
root@localhost [test] > INSERT INTO `foos` (`start`, `finish`) VALUES ('2000-01-01 12:30:00', '2000-01-01 12:30:00.999900');
Query OK, 1 row affected, 2 warnings (0.00 sec)
Note (Code 1265): Data truncated for column 'start' at row 1
Note (Code 1265): Data truncated for column 'finish' at row 1
root@localhost [test] > SELECT `foos`.* FROM `foos`;
+----+----------+---------------+
| id | start | finish |
+----+----------+---------------+
| 1 | 12:30:00 | 12:30:00.9999 |
+----+----------+---------------+
1 row in set (0.00 sec)
root@localhost [test] > SELECT `foos`.* FROM `foos` WHERE `foos`.`start` = '2000-01-01 12:30:00' LIMIT 1;
Empty set (0.00 sec)
root@localhost [test] > SELECT `foos`.* FROM `foos` WHERE `foos`.`start` = '12:30:00' LIMIT 1;
+----+----------+---------------+
| id | start | finish |
+----+----------+---------------+
| 1 | 12:30:00 | 12:30:00.9999 |
+----+----------+---------------+
1 row in set (0.00 sec)
```
|
|\
| |
| | |
Test against MariaDB 10.0
|
| |
| |
| |
| |
| |
| |
| |
| | |
- Specify we want to run on latest stable ruby for mariadb
- change in runs of builds
Make mariadb? method publicly available
|
|\ \
| | |
| | | |
[ci skip] Remove extra `so` from the Action Pack CHANGELOG
|
|/ / |
|
|\ \
| | |
| | | |
:nodoc: version method.
|
| |/
| |
| |
| |
| |
| |
| |
| | |
Reason:
- Its not publicly used method.
- Exposing it makes an assumption that other adapters support it based on its usage - ActiveRecord::Base.connection.version
[ci skip]
|
|\ \
| | |
| | | |
Update ActionMailer base documentation [ci skip]
|
| | | |
|
|\ \ \
| | | |
| | | | |
Fixed bug introduced in #24519. Makes build green again
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | | |
Add ruby 2.2.2+ version requirement for Rails 5 apps
|
| | |/
| |/|
| | |
| | | |
[ci skip]
|
|\ \ \
| | | |
| | | | |
Switch to keyword args for attribute_changed?
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Previously we were assuming that the only valid types for encoding were
arrays and hashes. However, any JSON primitive is an accepted value by
both PG and MySQL.
This does involve a minor breaking change in the handling of `default`
in the schema dumper. This is easily worked around, as passing a
hash/array literal would have worked fine in previous versions of Rails.
However, because of this, I will not be backporting this to 4.2 or
earlier.
Fixes #24234
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
We are using compare_without_coercion.
|
|\ \ \ \
| | | | |
| | | | |
| | | | | |
extension synonyms yml and yaml
|
| | | | | |
|
|\ \ \ \ \
| |_|/ / /
|/| | | | |
Generate `cable.js` file if does not exist when generating channel
|
| | |/ /
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Before this, while generating a channel, we were not creating
`cable.js` if it does not already exist.
- We have similar code for application mailer here -
https://github.com/rails/rails/commit/0b3ae023d27197417541932632055cd6be4810c4.
- Based on the comment -
https://github.com/rails/rails/issues/24418#issuecomment-205421995.
|
|\ \ \ \
| | | | |
| | | | | |
prevent 'attribute_changed?' from returning nil
|
| |/ / / |
|
|\ \ \ \
| | | | |
| | | | | |
Lesser '.' objects for number helpers
|
| | | | |
| | | | |
| | | | |
| | | | | |
do the same string manipulation. This was we avoid the duplicate strings with freeze and append modifies existing string
|
| | | | |
| | | | |
| | | | |
| | | | | |
iteration of calling the helper. Eases on some memory bloat
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Note that the fact that mtimes in the future are ignore was documented
just a few lines above. Since we know this has to be done, and the code
is quite clear due to variable naming, I think we can get rid of the
comment in the middle of the loop and shorten it even further.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Guides changelog pass [ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
https://github.com/rails/rails/pull/23176
[ci skip]
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- Made all sentences to end properly
[ci skip]
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Handle max_time edge cases for epoch times and add test
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | | |
|
|/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In 04ac5655be91f49cd4dfe2838df96213502fb274 I assumed that we would
never want to pass the "table_name.column_name" form to where with a
symbol. However, in Ruby 2.2 and later, you can quote symbols using the
new hash syntax, so it's a semi-reasonable thing to do if we want to
support the dot notation (which I'd rather deprecate, but that would be
too painful of a migration).
Instead we've changed the definition of "this is a table name with a
dot" to when the value associated is a hash. It would make very little
sense to write `where("table_name.column_name": { foo: :bar })` in any
scenario (other than equality for a JSON column which we don't support
through `where` in this way).
Close #24514.
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | |
| | | | | |
| | | | | | |
BlakeMesdag/activesupport-fileupdate-checker-mtime-optimization
Use a single loop in ActiveSupport:FileUpdateChecker#max_mtime
|
| | | | | | |
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
ActiveSupport::FileUpdateChecker#max_mtime
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Railties CHANGELOG Pass [ci skip]
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Added missing config to complete config names
- Fixed route generators changelog grammar.
- rake:stats => rake stats
- Fixed grammar of assert_file change
- Make sure we end all sentences
[ci skip]
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
prathamesh-sonpatki/add-config-to-deprecation-warning
Add `config` to the deprecation warnings of deprecated config options
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
speed up ActiveModel::Dirty#attribute_changed?
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Benchmark results:
Warming up --------------------------------------
old code 32.176k i/100ms
new code 34.837k i/100ms
Calculating -------------------------------------
old code 1.595M (± 3.5%) i/s - 7.947M
new code 1.942M (± 3.9%) i/s - 9.685M
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Encourage best practice in the HTTP Token authentication example code
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
`authenticate` method, to use the `secure_compare` method with two constant-length strings. This defends against timing attacks, and is best practice. Using `==` for sensitive actions is not recommended, and this was the source of a CVE fixed in October 2015: https://github.com/rails/rails/commit/17e6f1507b7f2c2a883c180f4f9548445d6dfbda
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | | |
Clean up all Rails 5 warnings. Revert auto-added periods.
|