| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \
| | |
| | | |
Update turbolinks-rails for passing railties test
|
| | |
| | |
| | |
| | | |
Ref - https://github.com/turbolinks/turbolinks-rails/pull/3
|
|\ \ \
| |/ /
|/| |
| | |
| | | |
y-yagi/donot_explicitly_mention_eventmachine_in_template
don’t explicitly mention EventMachine [ci skip]
|
|/ /
| |
| |
| | |
Follow up to 6accef4e11b0c793e1c085536b5ed27f32b6a0c3
|
|\ \ |
|
| |\ \
| | | |
| | | | |
move CHANGELOG entry to the appropriate position [ci skip]
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Dummy apple icon files has been added after the 5.0.0.beta2 release.
ref: #23455
|
|/ / / |
|
| | | |
|
| | | |
|
|\ \ \
| |/ /
|/| | |
add missing include to engine test example [ci skip]
|
| | |
| | |
| | |
| | |
| | | |
Using url helper method of engine in example code,
include `Engine.routes.url_helpers` is required to use helper method of engine.
|
|\ \ \
| |/ /
|/| | |
Remove the assumption of schema in DATABASE_URL
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If you set the DATABASE_URL environment variable to `mydatabase` by accident, you end up getting a series of errors that are hard to trace. For example:
```
warning: already initialized constant ActiveRecord::Base::OrmAdapter
```
Turns out the cascade of errors is due to the error raised by `.tr` being called on `nil`.
This commit makes sure that `scheme` is set before calling `.tr` on it. My previous iteration used `@uri.scheme.try(:tr, '-', '_')` but using the `&&` logical operator is a fair bit faster: http://stackoverflow.com/questions/26655032/try-vs-performance
With this change, the error message becomes much more understandable:
```
FATAL: database "mydatabase" does not exist (ActiveRecord::NoDatabaseError)
```
|
|\ \ \
| | | |
| | | | |
Don't publicize Kernel core extensions
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is a reaction to a [bug] we hit in web-console. The cause of it was
a `Kernel` extension called `#console` that was public and was fighting
over Railties with console block to be run on `rails console`. We solved
it by making the method private. We did that through `module_function`
so `::Kernel.console` can be invoked even in `BasicObject`.
I'm proposing to make most of the core Active Support `Kernel`
extensions `module_function` as well. Those are currently public and we
are polluting every `Object` public interface with them.
```ruby
>> Object.new.respond_to? :silence_warnings
=> true
>> Object.new.respond_to? :with_warnings
=> true
>> Object.new.respond_to? :enable_warnings
=> true
>> Object.new.respond_to? :suppress
=> true
``
Some extensions like `Kernel#class_eval` should be public, but most of
them don't really need to be.
[bug]: https://github.com/rails/web-console/issues/184
|
|\ \ \ \
| | | | |
| | | | | |
Add documentation about `ActiveModel::Errors#[]` method to describe how it works [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
hotlink to the source and results for AWDwR tests
|
|/ / / / / |
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Remove jquery-rails gem from generator if --skip-sprockets is true
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
on sprockets environment
- Remove jquery-rails if --skip-sprockets is true
Fixes #23431
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Update assertion on redis in generated Gemfile
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Redis now included in Gemfile but commented out. This change was made in
91864439c7aebb6ca710831aac6781903a433904 and is causing the test
failure.
See https://travis-ci.org/rails/rails/jobs/106994913#L1025
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Pass api only option to rails rails:update task to update only based on api Apps
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fixes #23470
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
All grown up and shit!
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
So no need to have it on by default in the Gemfile.
|
| |_|_|/ /
|/| | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
So it can properly show stats for an app with 1,000,000+ LOC
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This reverts commit 293bd95c3e77275193130bc14c986348aae8b0e2.
This broke the header :<
|
| |/ / /
|/| | | |
|
|\ \ \ \
| | | | |
| | | | | |
Remove commented out code in `ci/travis.rb` [ci skip]
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
kamipo/innodb_supports_fulltext_and_spatial_indexes
InnoDB supports FULLTEXT and Spatial Indexes [ci skip]
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | | |
https://dev.mysql.com/doc/refman/5.7/en/innodb-fulltext-index.html
https://dev.mysql.com/doc/refman/5.7/en/creating-spatial-indexes.html
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Active Record supports MySQL >= 5.0
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Currently some features uses `information_schema` (e.g. foreign key
support). `information_schema` introduced since MySQL 5.0.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Document the fact that Action Cable does not require a multi-threaded app server
|
| | |_|/ / /
| |/| | | |
| | | | | |
| | | | | | |
[ci skip]
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
SQLite 2 support has been dropped [ci skip]
|
|/ / / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Remove unused dependency
|
| | |_|/ / /
| |/| | | |
| | | | | | |
railties uses method_source, activesupport does not. I assume code was refactored and the dependency wasn't removed.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Defer Arel attribute lookup to the model class
|
| | | | | | |
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This still isn't as separated as I'd like, but it at least moves most of
the burden of alias mapping in one place.
|