aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | [skip ci] arel -> ArelVishal Telangre2019-05-111-1/+1
| |/ / / / / / / | | | | | | | | | | | | | | | | As per the documentation guides, we write `Arel` instead of `arel`.
* | | | | | | | Merge pull request #36244 from vishaltelangre/patch-3Ryuta Kamizono2019-05-121-3/+3
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | [ci skip] Typo: ActiveSuppport -> ActiveSupport
| * | | | | | | [ci skip] Typo: ActiveSuppport -> ActiveSupportVishal Telangre2019-05-111-3/+3
|/ / / / / / /
* | | | | | | Merge pull request #36241 from ↵Xavier Noria2019-05-111-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | vishaltelangre/fix-confusing-sentence-in-upgrade-guide [ci skip] Fix confusing sentence in upgrade guide
| * | | | | | | [ci skip] Fix confusing sentence in upgrade guideVishal Telangre2019-05-111-1/+1
| | |_|_|/ / / | |/| | | | |
* | | | | | | Merge pull request #36242 from shekhar-patil/masterVipul A M2019-05-111-1/+1
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | [ci skip] Corrected the sentence in upgrade guide
| * | | | | | Corrected the sentence in upgrade guideshekhar-patil2019-05-111-1/+1
|/ / / / / /
* | | | | | Merge branch 'migration-timestamp-fix'Gannon McGibbon2019-05-104-0/+20
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | Closes #28707.
| * | | | | | Add class option timestamps to migration generatorMichael Duchemin2019-02-094-0/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes GH#28706. Now rails g migration create_users and rails g model User have the same behavior for timestamps since they implement the same migration template. The expected behavior is that this create table migration will create the table with timestamps unless you pass --no-timestamps or --skip-timestamps to the generator. The expected migration should match what you get when you use the model generator. Using the migration generator, which doesn't have a class_option for timestamps would cause them to not be added to the migration file. Now the migration behavior of the migration generator, create_table only, is aligned with the migration behavior of the model generator. Also modified relevant example of ActiveRecord Migrations Guide.
* | | | | | | Merge pull request #36184 from vishaltelangre/as-monotonic-timed-subscriberEileen M. Uchitelle2019-05-104-9/+131
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Introduce ActiveSupport::Notifications.monotonic_subscribe
| * | | | | | | Introduce ↵Vishal Telangre2019-05-104-9/+131
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'ActiveSupport::Notifications::Fanout::Subscribers::MonotonicTimed' and 'ActiveSupport::Notifications::monotonic_subscribe' Also, change the signature of ‘ActiveSupport::Notifications::Fanout#subscribe’ to accept optional ‘monotonic’ boolean argument. Then initialize either a ‘Timed’ or ‘MonotonicTimed’ subscriber based on the value of ‘monotonic’ parameter. Introduce ‘ActiveSupport::Notifications::monotonic_subscribe’ method Also, provision ‘ActiveSupport::Notifications::subscribed’ to optionally accept ‘monotonic’ boolean argument. Update documentation for ActiveSupport::Notifications Add tests Update guides documentation under the 'Active Support Instrumentation' chapter Incorporate feedback: use optional keyword argument to specify optional 'monotonic' option to 'subscribed' method Fix a typo
* | | | | | | | Merge pull request #36181 from jamesdabbs/jcd/action-mailbox-forGeorge Claghorn2019-05-095-5/+30
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Expose `mailbox_for` method
| * | | | | | | | Add CHANGELOG entryJames Dabbs2019-05-091-0/+2
| | | | | | | | |
| * | | | | | | | Delegate to the correct method in `ActionMailbox.mailbox_for`James Dabbs2019-05-051-1/+1
| | | | | | | | |
| * | | | | | | | Rename variable to represent typeJames Dabbs2019-05-051-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | per comments from CR
| * | | | | | | | Expose `mailbox_for` methodJames Dabbs2019-05-044-5/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, the only exposed entry point into the ApplicationMailbox's configured routing system is to call `route`, which performs a lot of work to fully `process` inbound email. It'd be nice to have a way (e.g. in test) of checking which mailbox an email would route to without necessarily processing it yet.
* | | | | | | | | fixes configuration examples [ci skip]Xavier Noria2019-05-091-3/+3
| |/ / / / / / / |/| | | | | | |
* | | | | | | | Merge pull request #36225 from ↵Yuji Yaginuma2019-05-091-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | deivid-rodriguez/workaround_sass_rails_requirement Use a better requirement for sass-rails 6 prereleases
| * | | | | | | | Use a better requirement for sass-rails 6 prereleasesDavid Rodríguez2019-05-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is the behavior I naively expect for the operator when used with a single digit, but it's definitely an edge case for it, and it doesn't seem to work as expected for including prereleases. Using >= works fine and make the intention more clear anyways.
* | | | | | | | | Merge pull request #36223 from sharang-d/revert-36214Ryuta Kamizono2019-05-091-1/+1
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | Fix indentation of the config.eager_load nil warning
| * | | | | | | | Fix indentation of the config.eager_load nil warningSharang Dashputre2019-05-091-1/+1
|/ / / / / / / /
* | | | | | | | Merge pull request #36216 from utilum/update_resque_schedulerRyuta Kamizono2019-05-091-16/+16
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | bundle update resque-scheduler to latest version
| * | | | | | | | bundle update resque-scheduler to latest versionutilum2019-05-081-16/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resque 2.0 includes grammar fixes for warnings tickled by our tests. Updating resque-scheduler also requires and updates resque to version 2.0. ``` $ ruby -v ruby 2.6.2p47 (2019-03-13 revision 67232) [x86_64-linux] ```
* | | | | | | | | Merge pull request #36221 from jhawthorn/middleware_instrumentationRafael França2019-05-083-6/+17
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Only build middleware proxy when instrumentating
| * | | | | | | | | Only build middleware proxy when instrumentatingJohn Hawthorn2019-05-083-6/+17
|/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The instrumentation proxy adds three stack frames per-middleware, even when nothing is listening. This commit, when the middleware stack is built, only adds instrumentation when the `process_middleware.action_dispatch` event has already been subscribed to. The advantage to this is that we don't have any extra stack frames in apps which don't need middleware instrumentation. The disadvantage is that the subscriptions need to be in place when the middleware stack is built (during app boot). I think this is likely okay because temporary AS::Notifications subscriptions are strongly discouraged.
* | | | | | | | | documents restriction for explicit namespaces [ci skip]Xavier Noria2019-05-081-0/+34
| | | | | | | | |
* | | | | | | | | documents how to use the classic autoloader in Rails 6 [ci skip]Xavier Noria2019-05-081-0/+11
| | | | | | | | |
* | | | | | | | | Merge pull request #36214 from abhaynikam/36211-fix-indentationRafael França2019-05-081-5/+5
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | Fix indentation for config.eager_load nil warning message
| * | | | | | | | | Fix indentation for config.eager_load nil warning messageAbhay Nikam2019-05-081-5/+5
| |/ / / / / / / /
* | | | | | | | | Merge pull request #36215 from rmacklin/update-testing-guideVipul A M2019-05-081-1/+1
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | Update testing guide to reflect changes from #36047 [ci skip]
| * | | | | | | | Update testing guide to reflect changes from #36047Richard Macklin2019-05-081-1/+1
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In #36047 we moved `take_failed_screenshot` from an `after_teardown` hook to a `before_teardown` hook. However, I didn't realize the Testing rails guide was explicitly mentioning that it happened inside `after_teardown`. So this updates the docs to be consistent with that change. [ci skip]
* | | | | | | | Auto-correct `Style/RedundantBegin` offenceRyuta Kamizono2019-05-081-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This offenced code is introduced from forward ported #36196, since looks like 6-0-stable branch isn't checked by CodeClimate.
* | | | | | | | Fix broken markup in CHANGELOG [ci skip]Ryuta Kamizono2019-05-081-8/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/rails/rails/blob/65bdd6ad085a02b976cd36f135c2a5ffb522e5a0/activesupport/CHANGELOG.md
* | | | | | | | Remove forward ported CHANGELOG [ci skip]Ryuta Kamizono2019-05-081-4/+0
| | | | | | | |
* | | | | | | | documents autoloading in the upgrading guide [ci skip]Xavier Noria2019-05-081-0/+172
| |_|_|_|_|/ / |/| | | | | |
* | | | | | | Merge pull request #36196 from st0012/fix-29947Eileen M. Uchitelle2019-05-078-4/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Hide malformed parameters from error page Accidentally merged this to 6-0-stable so forward porting it to master here instead.
* | | | | | | Merge pull request #36203 from st0012/fix-command-in-contributing-guideRyuta Kamizono2019-05-081-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Update directory name in example commands [ci skip]
| * | | | | | | Update directory name in sample commandsst00122019-05-081-1/+1
| | | | | | | |
* | | | | | | | Typo in the release noteAkira Matsuda2019-05-081-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [ci skip]
* | | | | | | | Merge pull request #36202 from yahonda/log_transactionRyuta Kamizono2019-05-086-23/+15
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | Remove ignored_sql from SQLCounter by adding "TRANSACTION" to log name
| * | | | | | | Remove ignored_sql from SQLCounter by adding "TRANSACTION" to log nameYasuo Honda2019-05-086-23/+15
| | |_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit adds "TRANSACTION" to savepoint and commit, rollback statements because none of savepoint statements were removed by #36153 since they are not "SCHEMA" statements. Although, only savepoint statements can be labeled as "TRANSACTION" I think all of transaction related method should add this label. Follow up #36153
* | | | | | | Merge pull request #36201 from soartec-lab/fix_typo_dot_positionVipul A M2019-05-071-1/+1
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Fixed typo of dot position [skip ci]
| * | | | | | Fixed typo of dot position [skip ci]soartec-lab2019-05-071-1/+1
|/ / / / / /
* | | | | | Properly give defaults for DatabaseSelector optionsAkira Matsuda2019-05-071-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The initializer receives `nil` for these options when no cofigurations were given: https://github.com/rails/rails/blob/v6.0.0.rc1/activerecord/lib/active_record/railtie.rb#L91-L97
* | | | | | Merge pull request #36190 from kamipo/should_attempt_tx_callbacks_to_all_recordsRyuta Kamizono2019-05-074-18/+71
|\ \ \ \ \ \ | | | | | | | | | | | | | | Should attempt `committed!`/`rolledback!` to all enrolled records in the transaction
| * | | | | | Should attempt `committed!`/`rolledback!` to all enrolled records in the ↵Ryuta Kamizono2019-05-074-18/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | transaction Currently, `committed!`/`rolledback!` will only be attempted for the first enrolled record in the transaction, that will cause some problematic behaviors. The first one problem, `clear_transaction_record_state` won't be called even if the transaction is finalized except the first enrolled record. This means that de-duplicated records in the transaction won't refer latest state (e.g. won't happen rolling back record state). The second one problem, the enrolled order is not always the same as the order in which the actions actually happened, the first enrolled record may succeed no actions (e.g. `destroy` has already succeeded on another record during `before_destroy`), it will lose to fire any transactional callbacks. To avoid both problems, we should attempt `committed!`/`rolledback!` to all enrolled records in the transaction.
* | | | | | | Merge pull request #36191 from st0012/remove-useless-methodRyuta Kamizono2019-05-071-5/+1
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Remove unnecessary find_partial method
| * | | | | | Remove useless find_partial methodst00122019-05-071-5/+1
|/ / / / / /
* | | | | | Remove useless `GC.start` in `test/template/render_test.rb`Ryuta Kamizono2019-05-061-14/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `GC.start` was added at b29e893, but the finalizer has been removed at 7d0ce78 in #35036.
* | | | | | Merge pull request #36189 from st0012/fix-36154Ryuta Kamizono2019-05-061-4/+9
|\ \ \ \ \ \ | | | | | | | | | | | | | | Clear Resolvers' cache after RenderTestCases tests
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-02 15:33:49 +0000