| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Allow the connection pool's #table_exists? method to give the connections
|
| | | |/ / / /
| |/| | | |
| | | | | |
| | | | | | |
#table_exists? method a chance.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Fix several warnings: change version of nokogiri gem
|
| |/ / / / / / |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Patch for [3.1.0.rc1] App plugins initialized before engines and plugins inside engines
|
| |/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
and plugins inside engines
It seems that plugins inside a Rails 3.1 application proper (i.e. in
/vendor/plugins) are initialized before engines and plugins inside
engines.
After some debugging, I found the culprit in
Rails::Application::Railties#all:
def all(&block)
@all ||= railties + engines + super
@all.each(&block) if block
@all
end
The call to super here implicitly passes the &block argument, which
has the unfortunate side-effect of adding the plugin initializers
first (in front of other railties and engines) in the case of
Rails::Engine#initializers:
def initializers
initializers = []
railties.all { |r| initializers += r.initializers }
initializers += super
initializers
end
The solution here is to replace the super call with a call
to #plugins.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
@josevalim and @jhawthorn for the prompting.
|
| | | | | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
users just need to say whether they want compression or not, and a default will be chosen by a Railtie. In the case of CSS, this default is already chosen by the sass-rails gem.
Users can still explicitly choose a compressor in their application.rb if they have a preference, but will usually want to let plugins choose defaults in their Railties.
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Cherry-picking patch for https://github.com/rails/rails/issues/1460 from 3-1-stable to master
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
from 3-1-stable to master
[3.1.0.rc1] Plugins inside engines not eager-loaded properly and their
rake tasks ignored
Working with the new support for plugins inside engines in Rails 3.1,
I found that certain things that work for regular plugins don't work
for these new nested plugins. In particular, these methods in
Rails::Engine don't seem to understand that an engine could have
nested plugins:
#load_tasks
#load_generators
#load_console
#eager_load!
A solution which worked out for me is to move the calls to
railties.all { ... } from the overriding methods in Rails::Application
into Rails::Engine.
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Replace dev.rubyonrails.com plugin url with a dummy url
|
| |/ / / / / / / |
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Improve the legacy wild controller route in app templates
|
| | | | | | | | | |
|
| | | | | | | | | |
|
| |\ \ \ \ \ \ \ \
| |/ / / / / / /
|/| | | | | | | |
Bump mysql2 to 0.3.5
|
| |/ / / / / / / |
|
| |/ / / / / / |
|
| | | | | | | |
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Use assert_equal instead of assert in uploaded file test.
|
| |/ / / / / / |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Allow last argument to be a boolean in memoized methods
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
If in the memoized method, the last argument is a boolean, it's considered as the reload method.
Don't consider it like that if that's a normal method argument.
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Signed-off-by: Damien Mathieu <42@dmathieu.com>
|
| |/ / / / / /
| | | | | |
| | | | | |
| | | | | | |
Signed-off-by: Andrew White <andyw@pixeltrix.co.uk>
|
| | | | | | | |
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Removed warnings from while running tests in Ruby 1.9.2
|
| |/ / / / / / |
|
| |\ \ \ \ \ \
| |_|_|_|_|/
|/| | | | | |
Encode the uploaded file's name in utf8 - Closes #869
|
| | | | | | | |
|
| |/ / / / / |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
of linecache which is a dependency of ruby-debug. However, the latest release of linecache (0.45) omits the dependency from its gemspec, causing the build to fail. I have emailed the maintainer so we should remove this when it's fixed upstream.
|
| | | | | | |
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | | |
(example: Event.where(created_at: Time.now.whole_week)) [DHH]
|
| | | | | |
| | | | |
| | | | |
| | | | | |
friends [DHH]
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Remove "is_assed" with something more meaningful
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
removed duplicate code in tests
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | | |
|
| |\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
Namespace engine assets
|
